Repository navigation
Add databricks feedback command - #7724
Merged
Merged
Conversation
Adds a CLI-wide command that sends feedback as a fast_feedback_log event to /telemetry-ext of the authenticated workspace. --command names the command the feedback is about and selects the owning component; the agent and run ID ride in the standard user agent. Feedback written by a detected AI agent requires the user's confirmation. The upload is a single, bounded attempt so ambiguous failures never file the same feedback twice. Commands can opt into building the full command tree so that --command resolves nested commands. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 2 tests: regression=2 unreleased=0 coverage=0 failing=0
TestAccept/cmd/feedback: branch ✅ | main (1a68ed9) ❌ | latest (v1.26.0) ❌main (1a68ed9): latest (v1.26.0): TestAccept/help: branch ✅ | main (1a68ed9) ❌ | latest (v1.26.0) ❌main (1a68ed9): latest (v1.26.0): |
pietern
reviewed
Nov 17, 2026
Collaborator
✅ Integration test reportCommit: 66f0fa6
Top 6 slowest tests (at least 2 minutes):
|
The fuzz calls RunE without the exec ID that cmd/root always sets, and is meant for auto-generated commands; hand-written ones are listed in manualRoots. Co-authored-by: Isaac <no-reply@databricks.com>
Validate the message, --command and --run-id, and reject --target, before the workspace client is created, so a mistake is not hidden behind a login prompt or an auth error. --target is rejected because feedback never loads the bundle. The confirmation now shows every field the user approves: the message, with control characters escaped so none can hide part of it, and the command, run ID and contact opt-in. --run-id is sent in canonical form. Co-authored-by: Isaac <no-reply@databricks.com>
An AI agent without --yes and without a terminal is now refused with the other input checks, before the workspace client is created. The prompt escapes every non-graphic character except newlines and tabs, so bidi overrides and zero-width characters cannot reorder or hide the message. Since main made prompts independent of NO_COLOR, the approval test no longer asserts how cmdio decides that; it checks that the approval works with NO_COLOR and TERM=dumb. Tests now force a real TCP reset for the single-attempt case, and cover sending with DATABRICKS_CLI_DISABLE_TELEMETRY set. The API client takes a retries argument instead of two wrapper constructors. Co-authored-by: Isaac <no-reply@databricks.com>
The prompt also escapes variation selectors and the other code points Unicode marks as default ignorable, which terminals draw as nothing and which can carry hidden text. A message made only of such characters is rejected, so blank-looking feedback cannot be filed. An acceptance case now checks that an agent without --yes is refused before authenticating. Co-authored-by: Isaac <no-reply@databricks.com>
Declining the approval prompt now returns ErrAlreadyPrinted after "Feedback not sent.", so an agent that ran the command can tell a decline from a send by its exit code. The message is indented in the prompt so its lines cannot pass for the fields listed below it. A test drives send through the prompt: an approval sends exactly the message shown, a decline sends nothing. Co-authored-by: Isaac <no-reply@databricks.com>
TestSendAsksBeforeSending cleared the environment before starting its test server; on Windows, sockets then fail to initialize without SystemRoot. The server and client are now created first, and its handler uses assert, since it runs on the server's goroutine. An unquoted message arrives as several arguments; the error now says to quote it and shows the command. Send's authentication error no longer mentions telemetry, which confused users who disabled it. Co-authored-by: Isaac <no-reply@databricks.com>
When --command is given without quotes, its second word arrives as an argument. If --command plus that word name a real command, the error now says to quote --command, instead of suggesting a message that folds the subcommand in. Suggested commands are quoted with shellquote.BashArg, so pasting one cannot expand $ or backticks. The approval prompt also shows the workspace host the feedback is filed in, so the user sees where an agent's --profile sends it. Co-authored-by: Isaac <no-reply@databricks.com>
The argument errors now say what to put quotes around. A printed command dropped the user's other flags (a pasted one could file feedback under the default profile) and its quoting only worked in POSIX shells. The prompt names the workspace with its ID on a unified host, where the host alone does not identify it. checkArgs and resolveCommand share findCommand. Co-authored-by: Isaac <no-reply@databricks.com>
A 4xx from the server, or a response that accepted none of the logs, means nothing was stored, so the error now says the feedback was not sent instead of that it could not be confirmed. telemetry.Send returns a NotAcceptedError for the second case. The unquoted --command hint follows the arguments for as long as they still name a command, so it names the whole path, for example "bundle deployment bind". The tree looks the spec up once. Co-authored-by: Isaac <no-reply@databricks.com>
--command is now plain text: its first word picks the owning team (bundle, air), and the origin joins its words with underscores. Resolving a nested command path needed the full tree, so CommandSpec.NeedsFullTree, its tree tests and the CommandString export are removed and cmd/root matches main again, apart from the fuzz test's list of hand-written commands. An unquoted --command now gets the same hint as an unquoted message. Co-authored-by: Isaac <no-reply@databricks.com>
…cters Plain-text --command let flags, paths and argument values reach origin, let a "databricks" prefix or a typo route feedback to the wrong team, and let terminal control sequences rewrite the approval prompt. Its first word must now be a top-level command, found on the root without building the tree, and every word may only use lowercase letters, digits and dashes. An alias resolves to the command's name. The note for agents, and the help, also ask to show the user the flags that go with the message, such as --can-be-contacted. Co-authored-by: Isaac <no-reply@databricks.com>
pietern
approved these changes
Nov 17, 2026
telemetry.Send marks failures that happen before the request is sent (the payload, the API client, authentication, including its timeout), and the new telemetry.NotSent reports those, a rejected request, and a response that accepted none of the logs. feedback uses it, so a failed login no longer reads as "could not be confirmed as sent". Comments now say what --command validation does not cover (a plain word after the first), why the prompt needs only stdin to be a terminal, and why the minimal retry window does not cancel the request. TestConfirm is table-driven. Co-authored-by: Isaac <no-reply@databricks.com>
The summary and the question are written to stderr. With stderr redirected the user cannot see what they approve, so an agent then needs --yes. Co-authored-by: Isaac <no-reply@databricks.com>
A request is written only once its connection is set up, so a DNS, dial or TLS failure before then means the server cannot have stored the feedback. Co-authored-by: Isaac <no-reply@databricks.com>
Later words of --command are not checked against the command tree, so without a limit it could fill the approval prompt and the origin field. Co-authored-by: Isaac <no-reply@databricks.com>
Callers check NotSent; nothing outside the package uses the error type. Co-authored-by: Isaac <no-reply@databricks.com>
The SDK retries a failed host metadata lookup for minutes, which stalled the untrusted-certificate case now and then. Stubbing the lookup also removes the pooled connection the refused case could reuse. Co-authored-by: Isaac <no-reply@databricks.com>
--command is a free string again: its first word picks the team, and its words are still limited to command-name characters. Ctrl-D at the approval prompt now declines instead of printing a bare EOF error. Co-authored-by: Isaac <no-reply@databricks.com>
simonfaltum
marked this pull request as ready for review
November 17, 2026 20:40
Collaborator
❌ Integration test reportCommit: d93fc1e
39 interesting tests: 22 FAIL, 10 RECOVERED, 6 flaky, 1 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-tagging Bot
added a commit
that referenced
this pull request
Nov 19, 2026
## Release v1.27.0 ### Notable Changes * `databricks aitools install`, `update` and `uninstall` now exit with code 1 when they do nothing they were asked to. `install` fails when it sets up nothing: no coding agent is detected, every agent is skipped or fails to install, or no skill in the release can be installed (also with `--path`). `update` fails when every update or check it attempts fails, and `uninstall` when every removal it attempts fails. Scripts that ran these commands as a best-effort step and relied on exit code 0 should handle the new exit code. ([#7481](#7481)) * Add `file:<path>` selectors to `pipelines run` and pipeline `bundle run`. `--refresh` and `--full-refresh` now use space-separated lists, such as `--refresh "orders payments"`, instead of comma-separated lists. Single names containing spaces now require backticks, e.g. ``--refresh 'table:`order details`'``. ([#7184](#7184)) * The Databricks CLI is now available on PyPI as `databricks`: run it with `uvx databricks`, or install it with `uv tool install databricks`, `pipx install databricks` or `pip install databricks`. The package contains only the prebuilt CLI binary. Uninstall the legacy `databricks-cli` package first, since both install a `databricks` command. ([#7704](#7704), [#7777](#7777)) ### CLI * Add `databricks sandbox fs` commands (`cp`, `ls`, `cat`, `mkdir`, `rm`) to transfer files between your local filesystem and sandboxes using `<sandbox-id>:/path`. ([#7372](#7372)) * `databricks fs` commands retry reads (stat, list, open) and deletes on DBFS and Volumes when the server returns a transient error or does not respond within the HTTP timeout. ([#7556](#7556)) * Retry UC Volumes file operations (`fs cp`, `fs ls`, `fs rm`, bundle uploads to Volumes) when the Files API returns HTTP 408, 429, 502, 503 or 504 (for example "AWS S3 is throttling requests"), or on a transient network error; this regressed in v1.10.0. ([#7559](#7559)) * Stop warning when the host metadata request (`/.well-known/databricks-config`) times out; the CLI already falls back to your config, and the message is still shown with `--debug`. ([#7752](#7752)) * Add `databricks aitools auto-install disable` and `enable` to turn off (or back on) the automatic installation of Databricks AI tools on CLI upgrades. A global-scope `databricks aitools uninstall` also turns it off. ([#7701](#7701)) * Stop printing the Databricks AI tooling install hint on `auth`, `configure`, `current-user me`, `version`, `help`, and shell-completion commands. ([#7452](#7452)) * When Codex, Cursor, GitHub Copilot CLI, OpenCode, Gemini CLI, Antigravity, Pi, Goose or Kiro run the CLI without Databricks skills installed for that agent, the CLI now prints a one-line hint to install them with `databricks aitools install --agents <agent> --scope global`, previously shown only to Claude Code. ([#7586](#7586)) * `databricks aitools install` now rejects an unknown `--agents` name before it shows the scope prompt, instead of after. ([#7469](#7469)) * `databricks aitools install` no longer asks "Proceed?" after the agent picker; the picker selection confirms the plan. The picker title now shows the install scope, its hint says Enter installs, `--skills-only` runs label plugin agents "skills" and pre-check every agent whose config dir exists, and the plan summary after it is reduced to the scope line. ([#7478](#7478)) * `databricks aitools install --output json` reports more specific `error_category` values: `SKILLS_FETCH_FAILED`, `RELEASE_LOOKUP_FAILED`, `RATE_LIMITED`, `MANIFEST_INVALID`, `STATE_INVALID` and `PLUGIN_CLI_TIMEOUT`. A coding agent CLI that does not answer in time is now reported as `timed out after <duration>`, followed by any stderr it wrote before it was stopped. ([#7475](#7475)) * `databricks aitools install` no longer prompts when a coding agent runs it, even in a pseudo-terminal; it uses the non-interactive defaults instead and prints a note saying so. ([#7477](#7477)) * `databricks aitools install` now prints the directory it installed skills into (for example `Installed 1 skill in ~/.databricks/aitools/skills.`), so agents can open the installed `SKILL.md` files without searching for them. ([#7668](#7668)) * `databricks aitools install` now ends a failed install with a step to recover, in the text output and in a new `recovery` field of `--output json`. ([#7480](#7480)) * `databricks aitools install` now installs plugins for the other coding agents even when installing skill files fails. ([#7479](#7479)) * `databricks aitools install` now installs skill files for a detected coding agent whose CLI is not on PATH (for example a Claude Code desktop or IDE install), unless it already has the plugin, says how to switch to the plugin later, and warns when the current project also has the plugin. `databricks aitools update` no longer tries to install the plugin for such an agent, and no longer writes skill files next to a plugin that such an agent already has. ([#7482](#7482)) * Fix `databricks aitools install` waiting a long time on an unreachable or slow workspace while it resolves authentication for telemetry; that wait is now limited to a few seconds. ([#7468](#7468)) * `databricks aitools install`, `update` and `list` now refuse a skills manifest that names a skill or file outside the skills directory, before writing any skill files. A skill whose name or file paths are not portable is skipped with a warning, and `update` keeps its installed copy. ([#7722](#7722)) * `databricks aitools install` and `databricks aitools update` refresh only the marketplace the Databricks plugin is listed in, so another unreachable marketplace no longer blocks them. When that refresh fails, both commands warn, install or update the plugin from the local copy of the marketplace, and record the plugin version as unknown. ([#7473](#7473)) * `databricks aitools install` and `databricks aitools update` now wait up to 20 seconds instead of 5 for a coding agent's CLI to answer the plugin capability check, so a slow first start is less likely to report the agent as unavailable. ([#7472](#7472)) * `databricks aitools install` no longer fails a plugin-only install when the lookup of the latest skills release on GitHub fails or is rate-limited. The plugin is installed and its version is recorded as unknown. ([#7474](#7474)) * `databricks aitools` commands now send usage telemetry, and the CLI records when it recommends installing Databricks AI tools. When the configured workspace is slow or unreachable, `aitools install`, `update` and `uninstall` can take up to about 6 seconds longer, and `list`, `version` and runs that stop early up to about 3 seconds. Set `DATABRICKS_CLI_DISABLE_TELEMETRY=1` to opt out. ([#7467](#7467), [#7469](#7469), [#7470](#7470)) * `databricks aitools install` and `databricks aitools update` now report a coding agent CLI shim (`.cmd` or `.bat`) on Windows that prints its plugin help and then exits with an error as `shim-exited-with-error`, with the command to run to see the error, instead of reporting the CLI as not on PATH. ([#7476](#7476)) * `apps init` no longer suggests installing skills when every detected coding agent already has the Databricks plugin. ([#7467](#7467)) * `databricks auth login` now gives up on the optional workspace lookup after about 5 seconds instead of retrying for about 5 minutes, and explains the fallback to the manual workspace ID prompt. ([#7522](#7522)) * Throttle Claude Code's native plugin install hint separately from the text hint: it prints at most once per 10 minutes per session, so the install dialog still comes up when a subagent, a hook, or a command outside a Claude Code subprocess runs the session's first `databricks` command. ([#7692](#7692)) * Print Claude Code's native plugin install hint alongside the text hint, so Claude Code offers a one-click install of the Databricks plugin. Claude Code now counts as having the tooling only when it loads it: skills only in `~/.databricks/aitools/skills` don't count, and a project- or local-scope plugin counts only when the CLI runs inside that project. `auth token`, `auth docker token` and CLI subprocesses no longer print install hints. ([#7585](#7585)) * Interactive prompts and pagers now work in Git for Windows' bash and other MSYS2 shells when they run under ConPTY (the default since Git for Windows 2.47) or directly in a Windows console. ([#7699](#7699)) * Add the `databricks feedback` command to send feedback about the CLI to Databricks. ([#7724](#7724)) * Fix shell completion in `databricks fs` commands for local paths typed with a leading `./` or repeated separators, which previously offered no suggestions. ([#7679](#7679)) * Fix a panic in `databricks labs` commands when a non-string SDK setting such as `DATABRICKS_DEBUG_HEADERS` or `DATABRICKS_RATE_LIMIT` is set in the environment. ([#7673](#7673)) * Fix a panic in `databricks labs install` for projects whose `labs.yml` has no `install` section. ([#7673](#7673)) * `NO_COLOR` no longer disables prompts, spinners or the list pager; they run without color. ([#7700](#7700)) * Add the Beta `databricks pipelines test` command, which runs the tests of a pipeline, and the `testing` property of pipelines in bundles. ([#7429](#7429)) * Add `databricks sandbox forward`, which serves an app running in a sandbox at a local URL. ([#7395](#7395)) * Bound the whole telemetry upload at exit, including config resolution and authentication, by its timeout, so a stalled auth or telemetry endpoint no longer keeps a command from exiting. ([#7467](#7467)) * `databricks version --check` now suggests `databricks aitools install` on stderr when a coding agent is detected without the Databricks plugin or skills. ([#7471](#7471)) ### AI Runtime * `air get -o json` now reports `PENDING` while the run waits for compute, matching `air list`, and includes the run's `status_message`. ([#7455](#7455)) * Wrap long failure reasons and log lines in the `air list` info and logs panes, keep the MLflow link (labeled with its retry) when a run's last retry failed before starting, and point `air logs` at earlier retries when the last one has no logs. ([#7456](#7456)) * `databricks air logs --node` now reports an out-of-range node index when it can determine the run's node count, instead of looking like a successful run with no logs. ([#7516](#7516)) * Add experiment, duration, accelerator, and dashboard metadata to `air list --output json`. For retried runs, `started_at` now reports the latest attempt, matching `air get`. ([#7568](#7568)) * `air list` shortens MLflow run names and unnamed-run IDs by keeping their end behind a leading `…`, and its columns no longer overflow on wide (for example CJK) text; `air get` shows an unnamed run's full MLflow run ID. ([#7582](#7582)) * Shrink the Experiment and User columns of the interactive `air list` table to fit the terminal width, keeping the end of a shortened experiment name. ([#7583](#7583)) * Show the experiment, accelerators and configuration in the `air list` info pane for runs where it showed `N/A`. ([#7587](#7587)) * Strip terminal control characters from the MLflow run, experiment and user names shown by `air list` and `air get`, so a run name cannot clear or retitle the terminal of whoever lists it. ([#7601](#7601)) * `air logs`, `air get`, and `air run --watch` no longer make an extra credential-check request before fetching the run, and `air get` reuses the configured workspace ID instead of looking it up. ([#7613](#7613)) * `air list` no longer waits on extra current-user requests before listing runs, which makes the default list about 150ms faster. ([#7615](#7615)) * `air list --all-status` requests larger index pages, so it makes far fewer round trips once the server supports `page_size`. ([#7616](#7616)) * Fit the interactive `air list` table to narrow terminals: when the Experiment and User columns are at their floors, shorten Started to `MM-DD HH:MM` and size the MLflow column to its labels, then hide Accelerators, User, MLflow and Progress in that order, naming the hidden columns in the hint line. ([#7629](#7629)) * `air get -o json` now includes `mlflow_run_id` and `mlflow_experiment_id`, so a run can be handed to MLflow-based steps without parsing `mlflow_url`. They identify the MLflow run `mlflow_url` links to, including one from an earlier retry that `mlflow_retry` names. ([#7636](#7636)) * `air get` and the `air list` info pane now show the environment of runs on the Databricks AI environment (`databricks_ai_v*`) instead of `N/A`. ([#7637](#7637)) * `air run` now rejects a `code_source.include_paths` path that selects no files instead of uploading a snapshot without it; glob patterns and pathspec magic are left to git. ([#7643](#7643)) * `air convert-to-dabs` now suggests the `--output-dir` that converts a working-tree workload whose `code_source.root_path` is outside the bundle directory, instead of suggesting `sync.paths`. ([#7644](#7644)) * `air run` now lists a `code_source.root_path` outside a git repository relative to `root_path`, so running from a subdirectory of `root_path` no longer uploads an empty or partial snapshot. ([#7646](#7646)) * `air list --all-status` now fills `--limit` past purged or inaccessible indexed runs. ([#7743](#7743)) * `air run` now warns about missing PyTorch when a pinned snapshot's `include_paths` selects a Python file. ([#7744](#7744)) * `air cancel JOB_RUN_ID` now rejects run IDs that are not AI Runtime runs instead of cancelling unrelated Jobs runs. In `-o json` output, the `failed[].error` text for a run that does not exist or that you cannot view now starts with `failed to get run <id>:` instead of the cancel API error. ([#7569](#7569)) * `air get -o json` now reports `mlflow_retry` when the MLflow link comes from an earlier retry because the run's last retry never reached MLflow. ([#7620](#7620)) * `databricks air run --help` now shows how to install the databricks-ai-runtime coding agent skill. ([#7652](#7652)) * `air run --watch -o json` now reports each lifecycle `STATUS` transition once and never reports a non-terminal state after the run has ended, including when logs are served from MLflow artifacts. ([#7621](#7621)) * `air convert-to-dabs` now explains the `--output-dir` workaround when `code_source.root_path` resolves to the bundle root, and notes when the generated job carries the default `max_retries`. ([#7579](#7579)) * `air run` now refuses to upload a `code_source` snapshot that selects no files (for example when `root_path` is git-ignored) and explains the cause, and `--dry-run` runs the snapshot file selection and reports the file count. ([#7570](#7570)) * Repeat the Jobs run link after live log streaming ends. ([#7571](#7571)) * `air get -o json` includes run details including flat `accelerator_type` and `num_accelerators`. Use `--include-config` to include stored config, which may contain plaintext `env_variables` and parameters; downloads over 1 MiB are omitted, and config-dependent `max_retries` is otherwise null. ([#7624](#7624)) * `air get` and the `air list` info pane no longer show `Max Retries 0` when the Jobs API leaves the task's retry limit out. For a run submitted with `air run`, the limit now comes from the run's uploaded config, shown as `3 (CLI default)` when the config doesn't set `max_retries`; it shows `N/A` when the limit can't be known (job runs, multi-container runs, legacy runs with no explicit value, or an unreadable config). ([#7623](#7623)) * Reorganize `databricks air` help: subcommands are grouped by task, `air run` has examples, and YAML fields are listed under headings, with pool fields marked optional and `command`, `compute.num_accelerators`, and `compute.accelerator_type` correctly marked required. ([#7512](#7512)) * `air run -h config` now lists the environment variables AI Runtime sets on every node (such as `MLFLOW_RUN_ID` and `CODE_SOURCE_PATH`), and `air logs --help` notes that `--download-to` cannot be combined with `--tail` or `--minutes`. ([#7655](#7655)) * Support full workspace accelerator types in `air list` filters while preserving family matching, and reject invalid filter values. ([#7515](#7515)) * `databricks air list --all-status` now warns when the AI Runtime run index is unavailable and it falls back to scanning Jobs runs. That fallback scan is capped at 250 runs, and a stuck index request fails after 15 seconds instead of retrying for minutes. `--all-status --filter user=<your email>` now uses the run index instead of scanning the workspace's full run history. ([#7619](#7619)) * Return structured JSON errors for invalid `air list --filter` values when `-o json` is used. ([#7612](#7612)) * `air list --all-status` no longer fails when a listed run has been purged. ([#7523](#7523)) * **Behavior change:** `databricks air logs` now prints the logs available now and exits, also for an active run, matching `kubectl logs`, `docker logs` and `databricks apps logs`. Pass `--follow` (`-f`) to stream new lines until the run completes; `--tail N --follow` prints the last N lines first. `databricks air run --watch` still submits and streams. ([#7658](#7658)) * `databricks air logs -o json` and `databricks air run --watch -o json` now emit a `WAITING` event, for example `{"type":"WAITING","message":"Waiting for accelerator compute capacity..."}`, when the reported waiting status changes. ([#7695](#7695)) * `databricks air logs` on a run that ended in the last two minutes now waits for the log index to settle before printing, instead of sometimes dropping lines that were indexed late. ([#7663](#7663)) * `air logs` and `air run --watch` now print the waiting status (for example `Waiting for accelerator compute capacity...`) as a line on stderr when stderr is not a terminal, instead of printing nothing until the run produces logs. ([#7657](#7657)) * Route AIR log links to the MLflow Logs page instead of the hidden artifact path. ([#7491](#7491)) * Invalid `compute.accelerator_type` errors and `air run -h config.compute` no longer list the CLI's built-in accelerator types, which could differ from the workspace's. ([#7520](#7520)) * `databricks air --help` now notes that GPU pools are not required to run workloads. ([#7581](#7581)) * `air run` now prints the job run URL with the `?o=<workspace-id>` suffix, matching `air get` and `air list`; `dashboard_url` in `air run -o json` and the `--watch` events gains it too. When `air list` cannot resolve the workspace ID, its links now omit `?o=` instead of ending in `?o=0`. ([#7573](#7573)) * `databricks air run` now reports an unknown workload YAML key by its field path, suggests the closest valid field, and points to `-h config` instead of naming an internal Go type. ([#7574](#7574)) * `air run` (including `--dry-run`) now warns before submitting when the `code_source` imports `torch` but PyTorch is not declared: the environment is the Standard environment (version 5 or later) with no `torch` dependency, so the run may fail after it waits for a GPU. ([#7656](#7656)) ### Bundles * Add `isolation_mode` to the `catalogs` resource, so a catalog can be deployed as `OPEN` or `ISOLATED`. ([#7463](#7463)) * `bundle validate` no longer warns when resource permissions and top-level or target permissions name the same principal. ([#7291](#7291)) * Retry bundle file uploads, reads and deletes when the server does not respond within the HTTP timeout ("request timed out after ... of inactivity"). ([#7521](#7521)) * Show how to recover when `bundle deploy` fails because an app's service principal does not exist or was deleted. ([#7533](#7533)) * Retry transient server errors when creating Lakebase (`postgres_*`) resources in the direct deployment engine. ([#7557](#7557)) * Fix `bundle plan` reporting the `spark_conf` and `custom_tags` the backend derives from `is_single_node: true` as drift on clusters. ([#7577](#7577)) * Stop planning a spurious update for Lakeflow Connect pipelines whose `ingestion_definition.data_staging_options` is filled in by the backend. ([#7603](#7603)) * Retry the root path check in `bundle destroy` on transient errors, so a dropped connection no longer fails the destroy. ([#7597](#7597)) * Use the Lakebase branch when its create request times out but the branch was created, instead of failing the deploy, in the direct deployment engine. ([#7602](#7602)) * Retry transient server errors when deleting resources in the direct deployment engine. ([#7708](#7708)) * Use the Lakebase project when its create request times out but the project was created, instead of failing the deploy with "already exists", in the direct deployment engine. ([#7747](#7747)) * Use the feature, model serving endpoint or dashboard that a create request created despite timing out, instead of failing the deploy, in the direct deployment engine. ([#7757](#7757)) * Use the Lakebase role when its create request fails with a transient error but the role was created, instead of failing the deploy, in the direct deployment engine. ([#7767](#7767)) * Use the MCP service, model service or model provider service that a create request created despite failing with a timeout, a 499 or a reset stream, instead of failing the deploy, in the direct deployment engine. Create recovery for features, serving endpoints and dashboards now also covers 499 and reset streams. ([#7782](#7782)) * Retry app updates and deletes in the direct deployment engine when they fail with 400 BAD_REQUEST because the app compute is `UPDATING`, after waiting for the compute to settle. ([#7606](#7606)) * Enable drift detection for `source_code_path` and `git_source` on apps. ([#6399](#6399)) * `bundle destroy` and `bundle deploy` no longer fail with "internal error, missing in state" when the state holds an empty-ID entry left by an interrupted recreate in an older CLI. ([#7676](#7676)) * Fix a feature whose `full_name` contains uppercase letters being recreated on every deploy. ([#7398](#7398)) * Fix `bundle deployment bind` (and `bundle generate --bind`) failing with `no such node "resources.internal_immutable_snapshots.immutable"` when `workspace.sync_mode` is `immutable`, as reported in [#7306](#7306). ([#7329](#7329)) * Retry creating the deployment lock (without `--force-lock`) when the request fails with a transient server error, times out ("request timed out after ... of inactivity") or loses its connection ("unexpected EOF"). ([#7594](#7594)) * Fix a materialization set member whose `feature_name` contains uppercase letters failing to deploy, or recreating the set on every deploy. ([#7398](#7398)) * Delete the old resource when its name follows a renamed schema. ([#7718](#7718)) * Fix `pipelines dry-run` starting a real run when given a job KEY, and a crash in its shell completion. ([#7672](#7672)) * Rename schemas in place; schemas and volumes follow a renamed catalog or schema. ([#7343](#7343)) * Fix a panic when validating or deploying jobs with local libraries and serverless job clusters. ([#7725](#7725)) * Fix `tgz` artifacts with `git` set producing an empty tarball or failing when the bundle is in a subdirectory of the git repository. ([#7674](#7674)) * Apply `presets.trigger_pause_status` and the development mode pause default to `triggers[]` entries on jobs. ([#7450](#7450)) ### Dependency Updates * Bump dependencies with known vulnerabilities. ([#7750](#7750)) * Update the Go SDK to [v0.198.0](https://github.com/databricks/databricks-sdk-go/releases/tag/v0.198.0). ([#7530](#7530)) * Update the Go SDK to [v0.199.0](https://github.com/databricks/databricks-sdk-go/releases/tag/v0.199.0). ([#7584](#7584)) * Update the Go SDK to [v0.200.0](https://github.com/databricks/databricks-sdk-go/releases/tag/v0.200.0). ([#7653](#7653)) * Update the Go SDK to [v0.201.0](https://github.com/databricks/databricks-sdk-go/releases/tag/v0.201.0). ([#7769](#7769))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Users, and agents acting for them, can't report a CLI problem from the CLI. This adds
databricks feedback [--command "<command>"] MESSAGE, which sends the message to Databricks from the authenticated workspace. It supersedes #7567 and keeps its behavior.--commandnames the command the feedback is about, as a free string. Its first word picks the owning team:airgoes toModelTraining.AIRuntime,bundletoDeveloperEcosystem.CoreDabs, anything else toDeveloperEcosystem.DatabricksCLI. Its words may only use command-name characters, which rejects flags and paths, and it is at most 200 characters.originis the words joined with underscores (bundle_deploy).fast_feedback_logevent (the in-product feedback widget's) posted to/telemetry-ext, using existing fields only; the agent and--run-idride in the user agent.--yesotherwise. The prompt shows the message with invisible characters escaped, the workspace, and every choice sent with it. Declining, including Ctrl-D, prints "Feedback not sent." and exits 1. Humans are not prompted.--targetis rejected, because the bundle is never loaded. An unquoted message or--commandgets an error that says what to quote.-o json). A failure names the ID and says whether the feedback was definitely not sent: it failed before a connection was set up or while authenticating, or the server answered 4xx or accepted none of it.DATABRICKS_CLI_DISABLE_TELEMETRYset; the help says so.telemetry.Send,telemetry.NotSentandcmdio.IsErrorTTYare new, andDatabricksCliLogis taggedomitzeroso a feedback entry carries onlyfast_feedback_log(existing events always set it).Why
Feedback text is retained centrally, so an agent's text needs the user's approval before it is sent. A retry after an ambiguous failure could file the feedback twice, so the command makes one attempt and reports the ID on failure.
Decisions to review
--commandis not looked up in the command tree, which would mean building every command (the tree is lazy since Build commands only when an invocation needs them #7487). A typo, an argument or adatabricksprefix reachesoriginas typed, and a misspelledbundlegoes to the CLI team. Keeping only the first word would drop details likebundle_deploy.Textis user-authored, which telemetry normally never carries. That is the point of the event, and an agent's text needs the user's approval first.cmdio.IsPromptSupported, so it also works withTERM=dumband MSYS2 pipes. It escapes invisible characters instead of stripping them likecmd/air'sstripControl, so the user sees exactly what is sent.feedbackis exempt from the aitools install hint, like other one-shot commands.cmd/air/validateconfig.go; sharing it would touchcmd/airandexperimental/ssh.Tests
acceptance/cmd/feedback: routing, the JSON receipt, agent refusal and--yes, input errors (including without a login), telemetry disabled, and a broken bundle.TestSendMakesOneAttempt: one request each for success,numProtoSuccess: 0, HTTP 403, 500 and 503, and a TCP reset.TestSendFailingBeforeConnectingIsNotSent: a refused connection and an untrusted certificate count as not sent.TestSendTimeoutBoundsTokenAcquisition: a blocked token source stops at the deadline.NO_COLOR,TERM=dumband stderr redirected, escaping, and that a declined or ended prompt sends nothing. The full unit and acceptance suites,./task lintand./task checkspass locally.This pull request and its description were written by Isaac.