Repository navigation
Add thumbnail_path to the apps resource #7728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fjakobs
wants to merge
12
commits into
main
Choose a base branch
from
fjakobs/app-thumbnail
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8eac7c0
Add thumbnail_path to the apps resource
fjakobs c670d2f
Normalize the Windows missing-file error in thumbnail-invalid
fjakobs 4e69814
Merge branch 'main' into fjakobs/app-thumbnail
fjakobs cd10af6
Address review: musterr, update_file.py, cloud coverage, doc comments
fjakobs 9cedd3a
Merge remote-tracking branch 'origin/main' into fjakobs/app-thumbnail
fjakobs 857464d
Record source_code_path in app create body after merge with main
fjakobs d619f6c
Merge branch 'main' into fjakobs/app-thumbnail
fjakobs 41d8801
Merge branch 'main' into fjakobs/app-thumbnail
fjakobs 3dce1a3
Merge branch 'main' into fjakobs/app-thumbnail
fjakobs 5af2618
Merge branch 'main' into fjakobs/app-thumbnail
fjakobs 9eec126
Merge branch 'main' into fjakobs/app-thumbnail
fjakobs 45e5e50
Merge branch 'main' into fjakobs/app-thumbnail
fjakobs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| * Add `thumbnail_path` to the `apps` resource, so `bundle deploy` sets, updates and deletes the thumbnail shown for the app in the Apps UI. ([#7728](https://github.com/databricks/cli/pull/7728)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
acceptance/bundle/resources/apps/thumbnail-invalid/databricks.yml.tmpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| bundle: | ||
| name: test-bundle | ||
|
|
||
| resources: | ||
| apps: | ||
| myapp: | ||
| name: myappname | ||
| source_code_path: . | ||
| thumbnail_path: $THUMBNAIL_PATH |
2 changes: 2 additions & 0 deletions
2
acceptance/bundle/resources/apps/thumbnail-invalid/out.test.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Cloud = true | ||
| EnvMatrix.DMS = ["", "true"] |
42 changes: 42 additions & 0 deletions
42
acceptance/bundle/resources/apps/thumbnail-invalid/output.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
|
|
||
| === thumbnail_path: ./thumbnail.gif | ||
|
|
||
| >>> musterr [CLI] bundle validate | ||
| Error: app thumbnail thumbnail.gif must be a PNG or JPEG image, got image/gif | ||
| in databricks.yml:9:23 | ||
|
|
||
| Name: test-bundle | ||
| Target: default | ||
| Workspace: | ||
| User: [USERNAME] | ||
| Path: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default | ||
|
|
||
| Found 1 error | ||
|
|
||
| === thumbnail_path: ./large.png | ||
|
|
||
| >>> musterr [CLI] bundle validate | ||
| Error: app thumbnail large.png is 250001 bytes, larger than the limit of 250000 bytes | ||
| in databricks.yml:9:23 | ||
|
|
||
| Name: test-bundle | ||
| Target: default | ||
| Workspace: | ||
| User: [USERNAME] | ||
| Path: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default | ||
|
|
||
| Found 1 error | ||
|
|
||
| === thumbnail_path: ./missing.png | ||
|
|
||
| >>> musterr [CLI] bundle validate | ||
| Error: failed to read app thumbnail missing.png: open missing.png: no such file or directory | ||
| in databricks.yml:9:23 | ||
|
|
||
| Name: test-bundle | ||
| Target: default | ||
| Workspace: | ||
| User: [USERNAME] | ||
| Path: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default | ||
|
|
||
| Found 1 error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # One byte over the 250,000-byte limit, with a PNG signature. | ||
| python3 -c "import sys; sys.stdout.buffer.write(b'\x89PNG\r\n\x1a\n' + bytes(250_001 - 8))" > large.png | ||
|
|
||
| for THUMBNAIL_PATH in ./thumbnail.gif ./large.png ./missing.png; do | ||
| title "thumbnail_path: $THUMBNAIL_PATH" | ||
| export THUMBNAIL_PATH | ||
| envsubst < databricks.yml.tmpl > databricks.yml | ||
| trace musterr $CLI bundle validate | ||
| done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| RecordRequests = false | ||
| Cloud = true | ||
| Ignore = ["large.png"] | ||
|
|
||
| [[Repls]] | ||
| Old = 'The system cannot find the file specified.' | ||
| New = 'no such file or directory' |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions
9
acceptance/bundle/resources/apps/thumbnail-upload-fails/databricks.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| bundle: | ||
| name: test-bundle | ||
|
|
||
| resources: | ||
| apps: | ||
| mykey: | ||
| name: myappname | ||
| source_code_path: . | ||
| thumbnail_path: ./thumbnail.png |
2 changes: 2 additions & 0 deletions
2
acceptance/bundle/resources/apps/thumbnail-upload-fails/out.test.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Cloud = false | ||
| EnvMatrix.DMS = ["", "true"] |
38 changes: 38 additions & 0 deletions
38
acceptance/bundle/resources/apps/thumbnail-upload-fails/output.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
|
|
||
| === A failed upload after create keeps the app in state and leaves the thumbnail out of it | ||
|
|
||
| >>> [CLI] bundle deploy | ||
| Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files... | ||
| Warning: failed to upload the thumbnail of app myappname, the next deploy retries it: Unsupported image | ||
| Created apps.mykey | ||
| Files: 2 uploaded, 0 deleted | ||
| Resources: 1 created, 0 changed, 0 deleted, 0 unchanged | ||
|
|
||
| >>> jq .state["resources.apps.mykey"].state.thumbnail .databricks/bundle/default/resources.json | ||
| null | ||
|
|
||
| === The next deploy retries the upload | ||
|
|
||
| >>> [CLI] bundle plan | ||
| update apps.mykey | ||
|
|
||
| Plan: 0 to add, 1 to change, 0 to delete, 0 unchanged | ||
|
|
||
| >>> musterr [CLI] bundle deploy | ||
| Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files... | ||
| Error: cannot update resources.apps.mykey: updating id=myappname: Unsupported image (400 INVALID_PARAMETER_VALUE) | ||
|
|
||
| Endpoint: PATCH [DATABRICKS_URL]/api/2.0/apps/myappname/thumbnail | ||
| HTTP Status: 400 Bad Request | ||
| API error_code: INVALID_PARAMETER_VALUE | ||
| API message: Unsupported image | ||
|
|
||
| Files: 0 uploaded, 0 deleted | ||
|
|
||
| >>> [CLI] bundle destroy --auto-approve | ||
| The following resources will be deleted: | ||
| delete resources.apps.mykey | ||
|
|
||
| All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default | ||
|
|
||
| Destroy: 1 deleted |
12 changes: 12 additions & 0 deletions
12
acceptance/bundle/resources/apps/thumbnail-upload-fails/script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| cleanup() { | ||
| trace $CLI bundle destroy --auto-approve | ||
| } | ||
| trap cleanup EXIT | ||
|
|
||
| title "A failed upload after create keeps the app in state and leaves the thumbnail out of it" | ||
| trace $CLI bundle deploy | ||
| trace jq '.state["resources.apps.mykey"].state.thumbnail' .databricks/bundle/default/resources.json | ||
|
|
||
| title "The next deploy retries the upload" | ||
| trace $CLI bundle plan | ||
| trace musterr $CLI bundle deploy | ||
7 changes: 7 additions & 0 deletions
7
acceptance/bundle/resources/apps/thumbnail-upload-fails/test.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| RecordRequests = false | ||
| Ignore = [".databricks"] | ||
|
|
||
| [[Server]] | ||
| Pattern = "PATCH /api/2.0/apps/{name}/thumbnail" | ||
| Response.StatusCode = 400 | ||
| Response.Body = '''{"error_code": "INVALID_PARAMETER_VALUE", "message": "Unsupported image"}''' |
Binary file added
BIN
+87 Bytes
acceptance/bundle/resources/apps/thumbnail-upload-fails/thumbnail.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| print("Hello world!") |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| bundle: | ||
| name: test-bundle | ||
|
|
||
| resources: | ||
| apps: | ||
| mykey: | ||
| name: myappname | ||
| source_code_path: ./app | ||
| thumbnail_path: ./thumbnail.png |
38 changes: 38 additions & 0 deletions
38
acceptance/bundle/resources/apps/thumbnail/out.requests.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "method": "POST", | ||
| "path": "/api/2.0/apps", | ||
| "q": { | ||
| "no_compute": "true" | ||
| }, | ||
| "body": { | ||
| "description": "", | ||
| "name": "myappname", | ||
| "source_code_path": "/Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files/app" | ||
| } | ||
| } | ||
| { | ||
| "method": "PATCH", | ||
| "path": "/api/2.0/apps/myappname/thumbnail", | ||
| "body": { | ||
| "app_thumbnail": { | ||
| "thumbnail": "iVBORw0KGgoAAAANSUhEUgAAACAAAAASCAIAAAC1qksFAAAAHklEQVR42mNgYPhPYzRqwagFoxaMWjBqwagFdLAAAM9QPd+sTeHpAAAAAElFTkSuQmCC" | ||
| } | ||
| } | ||
| } | ||
| { | ||
| "method": "PATCH", | ||
| "path": "/api/2.0/apps/myappname/thumbnail", | ||
| "body": { | ||
| "app_thumbnail": { | ||
| "thumbnail": "iVBORw0KGgoAAAANSUhEUgAAACAAAAASCAIAAAC1qksFAAAAH0lEQVR42mP4z8BAU8QwasGoBaMWjFowasGoBfSwAABLGz3fTe+jHwAAAABJRU5ErkJggg==" | ||
| } | ||
| } | ||
| } | ||
| { | ||
| "method": "DELETE", | ||
| "path": "/api/2.0/apps/myappname/thumbnail" | ||
| } | ||
| { | ||
| "method": "DELETE", | ||
| "path": "/api/2.0/apps/myappname" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Cloud = false | ||
| EnvMatrix.DMS = ["", "true"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
|
|
||
| === Deploy with a thumbnail: the image is uploaded after the app is created | ||
|
|
||
| >>> [CLI] bundle deploy | ||
| Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files... | ||
| Created apps.mykey | ||
| Files: 5 uploaded, 0 deleted | ||
| Resources: 1 created, 0 changed, 0 deleted, 0 unchanged | ||
|
|
||
| >>> print_requests | ||
|
|
||
| >>> [CLI] apps get myappname | ||
| "/ajax-api/2.0/thumbnails/raw/apps/1000/SMALL_DEFAULT.png" | ||
|
|
||
| === State keeps only a hash of the image | ||
|
|
||
| >>> jq .state["resources.apps.mykey"].state.thumbnail .databricks/bundle/default/resources.json | ||
| "sha256:[HASH]" | ||
|
|
||
| === Redeploy with an unchanged image: no thumbnail request | ||
|
|
||
| >>> [CLI] bundle plan | ||
| Plan: 0 to add, 0 to change, 0 to delete, 1 unchanged | ||
|
|
||
| >>> [CLI] bundle deploy | ||
| Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files... | ||
| Files: 1 uploaded, 0 deleted | ||
| Resources: 0 created, 0 changed, 0 deleted, 1 unchanged | ||
|
|
||
| >>> print_requests | ||
|
|
||
| === New content at the same path: only the thumbnail is uploaded | ||
|
|
||
| >>> [CLI] bundle plan | ||
| update apps.mykey | ||
|
|
||
| Plan: 0 to add, 1 to change, 0 to delete, 0 unchanged | ||
|
|
||
| >>> [CLI] bundle deploy | ||
| Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files... | ||
| Updated apps.mykey | ||
| Files: 1 uploaded, 0 deleted | ||
| Resources: 0 created, 1 changed, 0 deleted, 0 unchanged | ||
|
|
||
| >>> print_requests | ||
|
|
||
| === Deploy from a saved plan: the plan carries the image, not its hash | ||
|
|
||
| >>> [CLI] bundle deploy --plan tmp.plan.json | ||
| Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files... | ||
| Updated apps.mykey | ||
| Files: 3 uploaded, 0 deleted | ||
| Resources: 0 created, 1 changed, 0 deleted, 0 unchanged | ||
|
|
||
| >>> print_requests.py //apps ^//api/2.0/bundle | ||
| iVBORw0KGgoA | ||
|
|
||
| === Remove thumbnail_path: the thumbnail is deleted | ||
|
|
||
| >>> [CLI] bundle plan | ||
| update apps.mykey | ||
|
|
||
| Plan: 0 to add, 1 to change, 0 to delete, 0 unchanged | ||
|
|
||
| >>> [CLI] bundle deploy | ||
| Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files... | ||
| Updated apps.mykey | ||
| Files: 1 uploaded, 0 deleted | ||
| Resources: 0 created, 1 changed, 0 deleted, 0 unchanged | ||
|
|
||
| >>> print_requests | ||
|
|
||
| >>> [CLI] apps get myappname | ||
| null | ||
|
|
||
| >>> [CLI] bundle destroy --auto-approve | ||
| The following resources will be deleted: | ||
| delete resources.apps.mykey | ||
|
|
||
| All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default | ||
|
|
||
| Destroy: 1 deleted | ||
|
|
||
| >>> print_requests |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| print_requests() { | ||
| print_requests.py //apps '^//api/2.0/bundle' | ||
| } | ||
|
|
||
| cleanup() { | ||
| trace $CLI bundle destroy --auto-approve | ||
| trace print_requests >> out.requests.json | ||
| } | ||
| trap cleanup EXIT | ||
|
|
||
| cp blue.png thumbnail.png | ||
|
|
||
| title "Deploy with a thumbnail: the image is uploaded after the app is created" | ||
| trace $CLI bundle deploy | ||
| trace print_requests > out.requests.json | ||
| trace $CLI apps get myappname | jq .thumbnail_url | ||
|
|
||
| title "State keeps only a hash of the image" | ||
| trace jq '.state["resources.apps.mykey"].state.thumbnail' .databricks/bundle/default/resources.json | ||
|
|
||
| title "Redeploy with an unchanged image: no thumbnail request" | ||
| trace $CLI bundle plan | ||
| trace $CLI bundle deploy | ||
| trace print_requests >> out.requests.json | ||
|
|
||
| title "New content at the same path: only the thumbnail is uploaded" | ||
| cp red.png thumbnail.png | ||
| trace $CLI bundle plan | ||
| trace $CLI bundle deploy | ||
| trace print_requests >> out.requests.json | ||
|
|
||
| title "Deploy from a saved plan: the plan carries the image, not its hash" | ||
| cp blue.png thumbnail.png | ||
| $CLI bundle plan -o json > tmp.plan.json | ||
| trace $CLI bundle deploy --plan tmp.plan.json | ||
| trace print_requests.py //apps '^//api/2.0/bundle' | jq -r '.body.app_thumbnail.thumbnail | .[0:12]' | ||
|
|
||
| title "Remove thumbnail_path: the thumbnail is deleted" | ||
| update_file.py databricks.yml $' thumbnail_path: ./thumbnail.png\n' '' | ||
| trace $CLI bundle plan | ||
| trace $CLI bundle deploy | ||
| trace print_requests >> out.requests.json | ||
| trace $CLI apps get myappname | jq .thumbnail_url |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Ignore = [".databricks", "thumbnail.png", "tmp.plan.json"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use
musterrThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kept
errcodehere deliberately: this deploy should exit 0. The app was already created, so failing the deploy would leave it out of the bundle state and the next deploy would try to create it again (name conflict). The warning keeps the app managed with the thumbnail left out of state, so the next deploy retries it — that retry is themusterrin the next section.