Skip to content

Preserve CLI review authorization and dispatch receipts - #7732

Closed
shreyas-goenka wants to merge 1 commit into
mainfrom
shreyas-goenka_data/shreyas/cli-review-audit-receipts
Closed

shreyas-goenka wants to merge 1 commit into
mainfrom
shreyas-goenka_data/shreyas/cli-review-audit-receipts

Conversation

@shreyas-goenka

Copy link
Copy Markdown
Contributor

CLI review dispatch currently loses the original requester's identity when the backend runs as a GitHub App. Preserve compact authorization receipts with stable account IDs, permission checks and timestamps, then record the exact backend run and dispatch App/installation IDs before waiting for completion. Pass the source receipt to the backend as explicitly unverified correlation context.

Requires the companion backend audit PR to merge first: GitHub rejects the new optional workflow input until the backend declares it. Existing eligibility/permission policy is unchanged. These 90-day workflow artifacts are operational evidence, not independently retained organization or Databricks audit logs.

Validation: all 15 Python authorization tests pass, including receipt assertions; actionlint passes with the existing custom-runner-label exemptions. No live workflow behavior is changed until merge.


This PR was created with GitHub MCP.

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: f2c9487

Run: 44163451926

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 270 15 7:33
💚​ aws-windows-latest-4core-16gb 1 272 13 6:18
💚​ azure linux-2core-8gb 1 269 15 7:41
💚​ azure-windows-latest-4core-16gb 1 271 13 6:26
💚​ gcp linux-2core-8gb 1 270 15 7:29
💚​ gcp-windows-latest-4core-16gb 1 272 13 6:02
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 4 slowest tests (at least 2 minutes):
duration env testname
3:51 aws-windows-latest-4core-16gb TestAccept
3:48 azure-windows-latest-4core-16gb TestAccept
3:06 gcp-windows-latest-4core-16gb TestAccept
2:11 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants