Repository navigation
acc: disable DMS heartbeats in bundle/dms recording tests - #7746
Merged
Merged
Conversation
Collaborator
✅ Integration test reportCommit: dbfb998
Top 3 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 18, 2026 05:57
denik
requested review from
Sankalp-Mittal,
andrewnester,
pietern and
renaudhartert-db
and removed request for
renaudhartert-db
November 18, 2026 05:57
Sankalp-Mittal
left a comment
Contributor
There was a problem hiding this comment.
[AI Generated] Review by review-factory (Claude Fable 5.2 + Claude Opus 5.5, cross-verified). Only points the reviewers agreed on are posted.
The heartbeat fires after 30s without a state write, so slow cloud deploys recorded an extra POST .../heartbeat at a random point. Add a test-only DATABRICKS_BUNDLE_DMS_HEARTBEAT_INTERVAL_MS override and set it to 1h for bundle/dms. cloud: TestAccept/bundle/dms
bundle/dms_fault/heartbeat sets the interval to 1ms, so the faulted heartbeat endpoint is actually called (DMS API called: yes) and deploys still succeed while every heartbeat fails. cloud: TestAccept/bundle/dms Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
dms-heartbeat-interval-env
branch
from
November 18, 2026 07:22
45460e2 to
dbfb998
Compare
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 26 tests: regression=1 unreleased=6 coverage=19 failing=0
TestAccept/bundle/dms/declined-deploy/DMS=true: branch ✅ | main (a9494c0) ✅ | latest (v1.26.0) ❌latest (v1.26.0): TestAccept/bundle/dms/deployment-metadata-change/DMS=true: branch ✅ | main (a9494c0) ✅ | latest (v1.26.0) ❌latest (v1.26.0): TestAccept/bundle/dms/empty-grants/DMS=true: branch ✅ | main (a9494c0) ✅ | latest (v1.26.0) ❌latest (v1.26.0): TestAccept/bundle/dms/failed-recreate/DMS=true: branch ✅ | main (a9494c0) ✅ | latest (v1.26.0) ❌latest (v1.26.0): TestAccept/bundle/dms/operation-upload-fails-once/DMS=true: branch ✅ | main (a9494c0) ✅ | latest (v1.26.0) ❌latest (v1.26.0): TestAccept/bundle/dms/successful-recreate/DMS=true: branch ✅ | main (a9494c0) ✅ | latest (v1.26.0) ❌latest (v1.26.0): TestAccept/bundle/dms_fault/heartbeat/DMS=true: branch ✅ | main (a9494c0) ❌ | latest (v1.26.0) ❌main (a9494c0): latest (v1.26.0): |
Sankalp-Mittal
left a comment
Contributor
There was a problem hiding this comment.
[AI Generated] Review by review-factory (Claude Fable 5.2 + Claude Opus 5.5, cross-verified). Only points the reviewers agreed on are posted.
No issues found.
andrewnester
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The DMS heartbeat (added in #7342) fires after 30s without a state write. On cloud, deploys in
bundle/dms/*sometimes go 30s without a write (e.g. a slow resource create), so the recorded requests get an extraPOST .../versions/<N>/heartbeatat a random point. This made the DMS=true recording tests flaky on every cloud, Linux and Windows.What
libs/dms/heartbeat.go:DATABRICKS_BUNDLE_DMS_HEARTBEAT_INTERVAL_MSoverrides the 30s interval (same pattern asDATABRICKS_BUNDLE_RETRY_INTERVAL_MS). Invalid or non-positive values keep the default.acceptance/bundle/dms/test.toml: sets it to 1h, so no heartbeat goes out within a test.Decision: an interval override rather than filtering heartbeat requests out of the recording. Filtering would also hide a heartbeat sent by mistake (e.g. a regression that sends one on every deploy); with the override, any heartbeat in these tests is still recorded and fails the test. Heartbeat timing stays covered by the synctest unit tests in
libs/dms/heartbeat_test.go.Tests
bundle/dms_fault/heartbeatsets the interval to 1ms, so its faulted heartbeat endpoint is actually called (DMS API called: yes, wasno). This proves the override reaches the CLI and that deploys succeed while heartbeats fail.bundle/dms/*pass; with the override at 1ms the heartbeat shows up in successful-recreate, confirming the env reaches the CLI.cloud: TestAccept/bundle/dms.Dashboard
+ "path": "/api/2.0/bundle/deployments/[DEPLOYMENT_ID]/versions/2/heartbeat",+ "body": {}{"method": "POST", "path": "/api/2.0/bundle/deployments/[DEPLOYMENT_ID]/versions/<N>/heartbeat", "body": {}}+{"method": "POST", "path": "/api/2.0/bundle/deployments/[DEPLOYMENT_ID]/versions/1/heartbeat", "body": {}} [[REPEATED 2 times]]This pull request and its description were written by Isaac.