Skip to content

acc: disable DMS heartbeats in bundle/dms recording tests - #7746

Merged
denik merged 2 commits into
mainfrom
dms-heartbeat-interval-env
Nov 18, 2026
Merged

denik merged 2 commits into
mainfrom
dms-heartbeat-interval-env

Conversation

@denik

@denik denik commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Why

The DMS heartbeat (added in #7342) fires after 30s without a state write. On cloud, deploys in bundle/dms/* sometimes go 30s without a write (e.g. a slow resource create), so the recorded requests get an extra POST .../versions/<N>/heartbeat at a random point. This made the DMS=true recording tests flaky on every cloud, Linux and Windows.

What

  • libs/dms/heartbeat.go: DATABRICKS_BUNDLE_DMS_HEARTBEAT_INTERVAL_MS overrides the 30s interval (same pattern as DATABRICKS_BUNDLE_RETRY_INTERVAL_MS). Invalid or non-positive values keep the default.
  • acceptance/bundle/dms/test.toml: sets it to 1h, so no heartbeat goes out within a test.

Decision: an interval override rather than filtering heartbeat requests out of the recording. Filtering would also hide a heartbeat sent by mistake (e.g. a regression that sends one on every deploy); with the override, any heartbeat in these tests is still recorded and fails the test. Heartbeat timing stays covered by the synctest unit tests in libs/dms/heartbeat_test.go.

Tests

  • New unit tests for the override and invalid values.
  • bundle/dms_fault/heartbeat sets the interval to 1ms, so its faulted heartbeat endpoint is actually called (DMS API called: yes, was no). This proves the override reaches the CLI and that deploys succeed while heartbeats fail.
  • Local: bundle/dms/* pass; with the override at 1ms the heartbeat shows up in successful-recreate, confirming the env reaches the CLI.
  • AWS cloud: successful-recreate, declined-deploy, stale-plan pass. The last commit asks CI to run cloud: TestAccept/bundle/dms.

Dashboard

error verbatim snippet
error/3310 + "path": "/api/2.0/bundle/deployments/[DEPLOYMENT_ID]/versions/2/heartbeat", + "body": {}
error/3464 {"method": "POST", "path": "/api/2.0/bundle/deployments/[DEPLOYMENT_ID]/versions/<N>/heartbeat", "body": {}}
error/3508 +{"method": "POST", "path": "/api/2.0/bundle/deployments/[DEPLOYMENT_ID]/versions/1/heartbeat", "body": {}} [[REPEATED 2 times]]

This pull request and its description were written by Isaac.

@denik denik added the ai-auto Deprecated: use factory-generated instead. label Nov 18, 2026
@github-actions github-actions Bot added the DABs DABs related issues label Nov 18, 2026
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: dbfb998

Run: 44258416553

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 299 30 4:45
💚​ aws-windows-latest-4core-16gb 1 301 28 6:02
💚​ azure linux-2core-8gb 1 298 30 4:25
💚​ azure-windows-latest-4core-16gb 1 300 28 5:55
💚​ gcp linux-2core-8gb 1 299 30 5:29
💚​ gcp-windows-latest-4core-16gb 1 301 28 6:11
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 3 slowest tests (at least 2 minutes):
duration env testname
4:23 aws-windows-latest-4core-16gb TestAccept
4:08 gcp-windows-latest-4core-16gb TestAccept
3:53 azure-windows-latest-4core-16gb TestAccept

@denik
denik marked this pull request as ready for review November 18, 2026 05:57
@denik
denik requested review from a team as code owners November 18, 2026 05:57

@review-oss-bot review-oss-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me — no issues found.

@Sankalp-Mittal Sankalp-Mittal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[AI Generated] Review by review-factory (Claude Fable 5.2 + Claude Opus 5.5, cross-verified). Only points the reviewers agreed on are posted.

Comment thread acceptance/bundle/dms/test.toml Resolved
denik and others added 2 commits November 18, 2026 07:15
The heartbeat fires after 30s without a state write, so slow cloud deploys
recorded an extra POST .../heartbeat at a random point. Add a test-only
DATABRICKS_BUNDLE_DMS_HEARTBEAT_INTERVAL_MS override and set it to 1h for
bundle/dms.

cloud: TestAccept/bundle/dms
bundle/dms_fault/heartbeat sets the interval to 1ms, so the faulted
heartbeat endpoint is actually called (DMS API called: yes) and deploys
still succeed while every heartbeat fails.

cloud: TestAccept/bundle/dms

Co-authored-by: Isaac <no-reply@databricks.com>
@denik
denik force-pushed the dms-heartbeat-interval-env branch from 45460e2 to dbfb998 Compare November 18, 2026 07:22
@github-actions

Copy link
Copy Markdown
Contributor

Commit: dbfb99872 | Workflow run

Regression test report

Selected 1 changed tests (limit=20, 0 not selected)

26 tests: regression=1 unreleased=6 coverage=19 failing=0
test branch main (a9494c0) latest (v1.26.0)
TestAccept/bundle/dms/bind-unbind/DMS=true ✅ ✅ ✅
TestAccept/bundle/dms/declined-deploy/DMS=true ✅ ✅ ❌
TestAccept/bundle/dms/depends-on/DMS=true ✅ ✅ ✅
TestAccept/bundle/dms/deployment-metadata-change/DMS=true ✅ ✅ ❌
TestAccept/bundle/dms/empty-grants/DMS=true ✅ ✅ ❌
TestAccept/bundle/dms/existing-state/DMS= ✅ ✅ ✅
TestAccept/bundle/dms/failed-delete/DMS=true ✅ ✅ ✅
TestAccept/bundle/dms/failed-recreate/DMS=true ✅ ✅ ❌
TestAccept/bundle/dms/failed-update-permissions/DMS=true ✅ ✅ ✅
TestAccept/bundle/dms/immutable-folder/DMS=true/READPLAN= ✅ ✅ ✅
TestAccept/bundle/dms/immutable-folder/DMS=true/READPLAN=1 ✅ ✅ ✅
TestAccept/bundle/dms/mismatch-before-read/DMS=true ✅ ✅ ✅
TestAccept/bundle/dms/multiple-resources/DMS=true ✅ ✅ ✅
TestAccept/bundle/dms/no-drift/DMS=true ✅ ✅ ✅
TestAccept/bundle/dms/no-resources/DMS=true ✅ ✅ ✅
TestAccept/bundle/dms/operation-upload-fails-once/DMS=true ✅ ✅ ❌
TestAccept/bundle/dms/plan-without-dms/DMS= ✅ ✅ ✅
TestAccept/bundle/dms/provenance/DMS=true ✅ ✅ ✅
TestAccept/bundle/dms/record-failure/DMS=true ✅ ✅ ✅
TestAccept/bundle/dms/stale-local-state/DMS= ✅ ✅ ✅
TestAccept/bundle/dms/stale-plan/DMS=true/READPLAN= ✅ ✅ ✅
TestAccept/bundle/dms/stale-plan/DMS=true/READPLAN=1 ✅ ✅ ✅
TestAccept/bundle/dms/state-features/DMS=true ✅ ✅ ✅
TestAccept/bundle/dms/successful-recreate/DMS=true ✅ ✅ ❌
TestAccept/bundle/dms/version-never-created/DMS=true ✅ ✅ ✅
TestAccept/bundle/dms_fault/heartbeat/DMS=true ✅ ❌ ❌
TestAccept/bundle/dms/declined-deploy/DMS=true: branch ✅ | main (a9494c0) ✅ | latest (v1.26.0) ❌

latest (v1.26.0):

acceptance_test.go:1384: Diff:
        --- bundle/dms/declined-deploy/output.txt
        +++ /tmp/TestAcceptbundledmsdeclined-deployDMS=true19723225/002/output.txt
        @@ -48,7 +48,7 @@
             "error_message": "",
             "resource_id": "main.dms_declined_deploy_schema_[UNIQUE_NAME]",
             "sequence_id": 0,
        -    "state": "{\"state\":{\"catalog_name\":\"main\",\"name\":\"dms_declined_deploy_schema_[UNIQUE_NAME]\",\"schema_id\":\"[UUID][0]\"}}",
        +    "state": "{\"state\":{\"catalog_name\":\"main\",\"name\":\"dms_declined_deploy_schema_[UNIQUE_NAME]\"}}",
             "status": "OPERATION_STATUS_SUCCEEDED"
           }
         }
        @@ -66,7 +66,7 @@
         {
           "plan_version": [PLAN_VERSION],
           "cli_version": "[CLI_VERSION]",
        -  "lineage": "[UUID][1]",
        +  "lineage": "[UUID]",
           "serial": 1,
           "features": {
             "deployment_history_shadow": {}
        @@ -90,7 +90,7 @@
         {
          "state_version": 3,
          "cli_version": "[CLI_VERSION]",
        - "lineage": "[UUID][1]",
        + "lineage": "[UUID]",
          "serial": 1,
          "features": {
           "deployment_history_shadow": {}
        @@ -100,8 +100,7 @@
            "__id__": "main.dms_declined_deploy_schema_[UNIQUE_NAME]",
            "state": {
             "catalog_name": "main",
        -    "name": "dms_declined_deploy_schema_[UNIQUE_NAME]",
        -    "schema_id": "[UUID][0]"
        +    "name": "dms_declined_deploy_schema_[UNIQUE_NAME]"
            }
           }
          }
        
    acceptance_test.go:1162: 
        LOG.catalog: {
        LOG.catalog:   "catalog_type": "MANAGED_CATALOG",
        LOG.catalog:   "created_at": 1794986998596,
        LOG.catalog:   "created_by": "tester@databricks.com",
        LOG.catalog:   "full_name": "dms_other_thdg2p2sovatldtgzcd3oizvq4",
        LOG.catalog:   "isolation_mode": "OPEN",
        LOG.catalog:   "metastore_id": "7a0e1213-cf88-5116-7a0e-1213cf88521e",
        LOG.catalog:   "name": "dms_other_thdg2p2sovatldtgzcd3oizvq4",
        LOG.catalog:   "owner": "tester@databricks.com",
        LOG.catalog:   "updated_at": 1794986998596,
        LOG.catalog:   "updated_by": "tester@databricks.com"
        LOG.catalog: }
TestAccept/bundle/dms/deployment-metadata-change/DMS=true: branch ✅ | main (a9494c0) ✅ | latest (v1.26.0) ❌

latest (v1.26.0):

acceptance_test.go:1384: Diff:
        --- bundle/dms/deployment-metadata-change/output.txt
        +++ /tmp/TestAcceptbundledmsdeployment-metadata-changeDMS=true2280190250/002/output.txt
        @@ -48,7 +48,7 @@
             "error_message": "",
             "resource_id": "main.dms_metadata_schema_[UNIQUE_NAME]",
             "sequence_id": 0,
        -    "state": "{\"state\":{\"catalog_name\":\"main\",\"name\":\"dms_metadata_schema_[UNIQUE_NAME]\",\"schema_id\":\"[UUID][0]\"}}",
        +    "state": "{\"state\":{\"catalog_name\":\"main\",\"name\":\"dms_metadata_schema_[UNIQUE_NAME]\"}}",
             "status": "OPERATION_STATUS_SUCCEEDED"
           }
         }
        @@ -66,7 +66,7 @@
         {
           "plan_version": [PLAN_VERSION],
           "cli_version": "[CLI_VERSION]",
        -  "lineage": "[UUID][1]",
        +  "lineage": "[UUID]",
           "serial": 1,
           "features": {
             "deployment_history_shadow": {}
        @@ -128,7 +128,7 @@
         {
           "plan_version": [PLAN_VERSION],
           "cli_version": "[CLI_VERSION]",
        -  "lineage": "[UUID][1]",
        +  "lineage": "[UUID]",
           "serial": 1,
           "features": {
             "deployment_history_shadow": {}
TestAccept/bundle/dms/empty-grants/DMS=true: branch ✅ | main (a9494c0) ✅ | latest (v1.26.0) ❌

latest (v1.26.0):

acceptance_test.go:1384: Diff:
        --- bundle/dms/empty-grants/output.txt
        +++ /tmp/TestAcceptbundledmsempty-grantsDMS=true4043394532/002/output.txt
        @@ -53,7 +53,7 @@
             "error_message": "",
             "resource_id": "main.dms_empty_grants_[UNIQUE_NAME]",
             "sequence_id": 0,
        -    "state": "{\"state\":{\"catalog_name\":\"main\",\"name\":\"dms_empty_grants_[UNIQUE_NAME]\",\"schema_id\":\"[UUID][0]\"}}",
        +    "state": "{\"state\":{\"catalog_name\":\"main\",\"name\":\"dms_empty_grants_[UNIQUE_NAME]\"}}",
             "status": "OPERATION_STATUS_SUCCEEDED"
           }
         }
        @@ -139,7 +139,7 @@
         {
           "plan_version": [PLAN_VERSION],
           "cli_version": "[CLI_VERSION]",
        -  "lineage": "[UUID][1]",
        +  "lineage": "[UUID]",
           "serial": 2,
           "features": {
             "deployment_history_shadow": {}
        @@ -166,7 +166,7 @@
         {
          "state_version": 3,
          "cli_version": "[CLI_VERSION]",
        - "lineage": "[UUID][1]",
        + "lineage": "[UUID]",
          "serial": 2,
          "features": {
           "deployment_history_shadow": {}
        @@ -176,8 +176,7 @@
            "__id__": "main.dms_empty_grants_[UNIQUE_NAME]",
            "state": {
             "catalog_name": "main",
        -    "name": "dms_empty_grants_[UNIQUE_NAME]",
        -    "schema_id": "[UUID][0]"
        +    "name": "dms_empty_grants_[UNIQUE_NAME]"
            }
           }
          }
TestAccept/bundle/dms/failed-recreate/DMS=true: branch ✅ | main (a9494c0) ✅ | latest (v1.26.0) ❌

latest (v1.26.0):

acceptance_test.go:1384: Diff:
        --- bundle/dms/failed-recreate/output.txt
        +++ /tmp/TestAcceptbundledmsfailed-recreateDMS=true4221406431/002/output.txt
        @@ -48,7 +48,7 @@
             "error_message": "",
             "resource_id": "main.dms_failed_recreate_schema_[UNIQUE_NAME]",
             "sequence_id": 0,
        -    "state": "{\"state\":{\"catalog_name\":\"main\",\"comment\":\"v1\",\"name\":\"dms_failed_recreate_schema_[UNIQUE_NAME]\",\"schema_id\":\"[UUID][0]\"}}",
        +    "state": "{\"state\":{\"catalog_name\":\"main\",\"comment\":\"v1\",\"name\":\"dms_failed_recreate_schema_[UNIQUE_NAME]\"}}",
             "status": "OPERATION_STATUS_SUCCEEDED"
           }
         }
        @@ -66,7 +66,7 @@
         {
           "plan_version": [PLAN_VERSION],
           "cli_version": "[CLI_VERSION]",
        -  "lineage": "[UUID][1]",
        +  "lineage": "[UUID]",
           "serial": 1,
           "features": {
             "deployment_history_shadow": {}
        @@ -93,7 +93,7 @@
         {
          "state_version": 3,
          "cli_version": "[CLI_VERSION]",
        - "lineage": "[UUID][1]",
        + "lineage": "[UUID]",
          "serial": 1,
          "features": {
           "deployment_history_shadow": {}
        @@ -104,8 +104,7 @@
            "state": {
             "catalog_name": "main",
             "comment": "v1",
        -    "name": "dms_failed_recreate_schema_[UNIQUE_NAME]",
        -    "schema_id": "[UUID][0]"
        +    "name": "dms_failed_recreate_schema_[UNIQUE_NAME]"
            }
           }
          }
        @@ -193,7 +192,7 @@
         {
          "state_version": 3,
          "cli_version": "[CLI_VERSION]",
        - "lineage": "[UUID][1]",
        + "lineage": "[UUID]",
          "serial": 2,
          "features": {
           "deployment_history_shadow": {}
        
    acceptance_test.go:1162: 
        LOG.catalog: {
        LOG.catalog:   "catalog_type": "MANAGED_CATALOG",
        LOG.catalog:   "created_at": 1794986994861,
        LOG.catalog:   "created_by": "tester@databricks.com",
        LOG.catalog:   "full_name": "dms_other_s4mtylflhfdbnesagjr2gxcpfi",
        LOG.catalog:   "isolation_mode": "OPEN",
        LOG.catalog:   "metastore_id": "7a0e1212-f0e5-67eb-7a0e-1212f0e56921",
        LOG.catalog:   "name": "dms_other_s4mtylflhfdbnesagjr2gxcpfi",
        LOG.catalog:   "owner": "tester@databricks.com",
        LOG.catalog:   "updated_at": 1794986994861,
        LOG.catalog:   "updated_by": "tester@databricks.com"
        LOG.catalog: }
    acceptance_test.go:1162: 
        LOG.plan_final: create schemas.foo
        LOG.plan_final: 
        LOG.plan_final: Plan: 1 to add, 0 to change, 0 to delete, 0 unchanged
TestAccept/bundle/dms/operation-upload-fails-once/DMS=true: branch ✅ | main (a9494c0) ✅ | latest (v1.26.0) ❌

latest (v1.26.0):

acceptance_test.go:1384: Diff:
        --- bundle/dms/operation-upload-fails-once/output.txt
        +++ /tmp/TestAcceptbundledmsoperation-upload-fails-onceDMS=true2119041452/002/output.txt
        @@ -13,7 +13,7 @@
         {
           "plan_version": [PLAN_VERSION],
           "cli_version": "[CLI_VERSION]",
        -  "lineage": "[UUID][0]",
        +  "lineage": "[UUID]",
           "serial": 1,
           "features": {
             "deployment_history_shadow": {}
        @@ -40,7 +40,7 @@
         {
          "state_version": 3,
          "cli_version": "[CLI_VERSION]",
        - "lineage": "[UUID][0]",
        + "lineage": "[UUID]",
          "serial": 1,
          "features": {
           "deployment_history_shadow": {}
        @@ -51,8 +51,7 @@
            "state": {
             "catalog_name": "main",
             "comment": "v1",
        -    "name": "dms_upload_fails_once_schema_[UNIQUE_NAME]",
        -    "schema_id": "[UUID][1]"
        +    "name": "dms_upload_fails_once_schema_[UNIQUE_NAME]"
            }
           }
          }
        @@ -104,7 +103,7 @@
         {
          "state_version": 3,
          "cli_version": "[CLI_VERSION]",
        - "lineage": "[UUID][0]",
        + "lineage": "[UUID]",
          "serial": 2,
          "features": {
           "deployment_history_shadow": {}
        @@ -115,8 +114,7 @@
            "state": {
             "catalog_name": "dms_other_[UNIQUE_NAME]",
             "comment": "v1",
        -    "name": "dms_upload_fails_once_schema_[UNIQUE_NAME]",
        -    "schema_id": "[UUID][2]"
        +    "name": "dms_upload_fails_once_schema_[UNIQUE_NAME]"
            }
           }
          }
        @@ -163,7 +161,7 @@
             "error_message": "",
             "resource_id": "dms_other_[UNIQUE_NAME].dms_upload_fails_once_schema_[UNIQUE_NAME]",
             "sequence_id": 0,
        -    "state": "{\"state\":{\"catalog_name\":\"dms_other_[UNIQUE_NAME]\",\"comment\":\"v1\",\"name\":\"dms_upload_fails_once_schema_[UNIQUE_NAME]\",\"schema_id\":\"[UUID][2]\"}}",
        +    "state": "{\"state\":{\"catalog_name\":\"dms_other_[UNIQUE_NAME]\",\"comment\":\"v1\",\"name\":\"dms_upload_fails_once_schema_[UNIQUE_NAME]\"}}",
             "status": "OPERATION_STATUS_SUCCEEDED"
           }
         }
        
    acceptance_test.go:1162: 
        LOG.catalog: {
        LOG.catalog:   "catalog_type": "MANAGED_CATALOG",
        LOG.catalog:   "created_at": 1794987006235,
        LOG.catalog:   "created_by": "tester@databricks.com",
        LOG.catalog:   "full_name": "dms_other_yexmqszv5fcs5nk7zmdfnhvrvm",
        LOG.catalog:   "isolation_mode": "OPEN",
        LOG.catalog:   "metastore_id": "7a0e1215-96d7-29a2-7a0e-121596d72aa4",
        LOG.catalog:   "name": "dms_other_yexmqszv5fcs5nk7zmdfnhvrvm",
        LOG.catalog:   "owner": "tester@databricks.com",
        LOG.catalog:   "updated_at": 1794987006235,
        LOG.catalog:   "updated_by": "tester@databricks.com"
        LOG.catalog: }
FAIL
TestAccept/bundle/dms/successful-recreate/DMS=true: branch ✅ | main (a9494c0) ✅ | latest (v1.26.0) ❌

latest (v1.26.0):

acceptance_test.go:1384: Diff:
        --- bundle/dms/successful-recreate/output.txt
        +++ /tmp/TestAcceptbundledmssuccessful-recreateDMS=true555668910/002/output.txt
        @@ -48,7 +48,7 @@
             "error_message": "",
             "resource_id": "main.dms_successful_recreate_schema_[UNIQUE_NAME]",
             "sequence_id": 0,
        -    "state": "{\"state\":{\"catalog_name\":\"main\",\"comment\":\"v1\",\"name\":\"dms_successful_recreate_schema_[UNIQUE_NAME]\",\"schema_id\":\"[UUID][0]\"}}",
        +    "state": "{\"state\":{\"catalog_name\":\"main\",\"comment\":\"v1\",\"name\":\"dms_successful_recreate_schema_[UNIQUE_NAME]\"}}",
             "status": "OPERATION_STATUS_SUCCEEDED"
           }
         }
        @@ -66,7 +66,7 @@
         {
           "plan_version": [PLAN_VERSION],
           "cli_version": "[CLI_VERSION]",
        -  "lineage": "[UUID][1]",
        +  "lineage": "[UUID]",
           "serial": 1,
           "features": {
             "deployment_history_shadow": {}
        @@ -93,7 +93,7 @@
         {
          "state_version": 3,
          "cli_version": "[CLI_VERSION]",
        - "lineage": "[UUID][1]",
        + "lineage": "[UUID]",
          "serial": 1,
          "features": {
           "deployment_history_shadow": {}
        @@ -104,8 +104,7 @@
            "state": {
             "catalog_name": "main",
             "comment": "v1",
        -    "name": "dms_successful_recreate_schema_[UNIQUE_NAME]",
        -    "schema_id": "[UUID][0]"
        +    "name": "dms_successful_recreate_schema_[UNIQUE_NAME]"
            }
           }
          }
        @@ -165,7 +164,7 @@
             "error_message": "",
             "resource_id": "dms_other_[UNIQUE_NAME].dms_successful_recreate_schema_[UNIQUE_NAME]",
             "sequence_id": 1,
        -    "state": "{\"state\":{\"catalog_name\":\"dms_other_[UNIQUE_NAME]\",\"comment\":\"v1\",\"name\":\"dms_successful_recreate_schema_[UNIQUE_NAME]\",\"schema_id\":\"[UUID][2]\"}}",
        +    "state": "{\"state\":{\"catalog_name\":\"dms_other_[UNIQUE_NAME]\",\"comment\":\"v1\",\"name\":\"dms_successful_recreate_schema_[UNIQUE_NAME]\"}}",
             "status": "OPERATION_STATUS_SUCCEEDED"
           }
         }
        @@ -183,7 +182,7 @@
         {
           "plan_version": [PLAN_VERSION],
           "cli_version": "[CLI_VERSION]",
        -  "lineage": "[UUID][1]",
        +  "lineage": "[UUID]",
           "serial": 2,
           "features": {
             "deployment_history_shadow": {}
        @@ -210,7 +209,7 @@
         {
          "state_version": 3,
          "cli_version": "[CLI_VERSION]",
        - "lineage": "[UUID][1]",
        + "lineage": "[UUID]",
          "serial": 2,
          "features": {
           "deployment_history_shadow": {}
        @@ -221,8 +220,7 @@
            "state": {
             "catalog_name": "dms_other_[UNIQUE_NAME]",
             "comment": "v1",
        -    "name": "dms_successful_recreate_schema_[UNIQUE_NAME]",
        -    "schema_id": "[UUID][2]"
        +    "name": "dms_successful_recreate_schema_[UNIQUE_NAME]"
            }
           }
          }
        
    acceptance_test.go:1162: 
        LOG.catalog: {
        LOG.catalog:   "catalog_type": "MANAGED_CATALOG",
        LOG.catalog:   "created_at": 1794987001099,
        LOG.catalog:   "created_by": "tester@databricks.com",
        LOG.catalog:   "full_name": "dms_other_g3et5cfwijhybb6thkcldyqwdy",
        LOG.catalog:   "isolation_mode": "OPEN",
        LOG.catalog:   "metastore_id": "7a0e1214-64b0-e6ee-7a0e-121464b0e7f8",
        LOG.catalog:   "name": "dms_other_g3et5cfwijhybb6thkcldyqwdy",
        LOG.catalog:   "owner": "tester@databricks.com",
        LOG.catalog:   "updated_at": 1794987001099,
        LOG.catalog:   "updated_by": "tester@databricks.com"
        LOG.catalog: }
TestAccept/bundle/dms_fault/heartbeat/DMS=true: branch ✅ | main (a9494c0) ❌ | latest (v1.26.0) ❌

main (a9494c0):

acceptance_test.go:1384: Diff:
        --- bundle/dms_fault/heartbeat/output.txt
        +++ /tmp/TestAcceptbundledms_faultheartbeatDMS=true1388131896/002/output.txt
        @@ -141,4 +141,4 @@
         
           Destroy: 2 deleted
         
        -DMS API called: yes
        +DMS API called: no
        
    acceptance_test.go:1162: 
        LOG.commands: 
        LOG.commands: commands: ('bundle', 'deploy', '--auto-approve')
        LOG.commands: exit=0
        LOG.commands: Uploading bundle files to /Workspace/Users/tester@databricks.com/.bundle/dms-fault-heartbeat-commands-enlhq2exsfaibi6l2mbwskidj4/files...
        LOG.commands: Current Deployment Version: http://127.0.0.1:45149/deployments/4000000000000450?version=1
        LOG.commands: Created jobs.foo
        LOG.commands: Created pipelines.bar
        LOG.commands: Files: 4 uploaded, 0 deleted
        LOG.commands: Resources: 2 created, 0 changed, 0 deleted, 0 unchanged
        LOG.commands: 
        LOG.commands: commands: ('workspace', 'get-status', '/Workspace/Users/tester@databricks.com/.bundle/dms-fault-heartbeat-commands-enlhq2exsfaibi6l2mbwskidj4/state/resources.deployment.json', '-o', 'json')
        LOG.commands: exit=0
        LOG.commands: {
        LOG.commands:   "object_id": 4000000000000450,
        LOG.commands:   "object_type": "BUNDLE_DEPLOYMENT",
        LOG.commands:   "path": "/Workspace/Users/tester@databricks.com/.bundle/dms-fault-heartbeat-commands-enlhq2exsfaibi6l2mbwskidj4/state/resources.deployment.json"
        LOG.commands: }
        LOG.commands: 
        LOG.commands: commands: ('bundle', 'deploy', '--auto-approve')
        LOG.commands: exit=0
        LOG.commands: Uploading bundle files to /Workspace/Users/tester@databricks.com/.bundle/dms-fault-heartbeat-commands-enlhq2exsfaibi6l2mbwskidj4/files...
        LOG.commands: Current Deployment Version: http://127.0.0.1:45149/deployments/4000000000000450?version=2
        LOG.commands: Updated jobs.foo
        LOG.commands: Updated pipelines.bar
        LOG.commands: Files: 3 uploaded, 0 deleted
        LOG.commands: Resources: 0 created, 2 changed, 0 deleted, 0 unchanged
        LOG.commands: 
        LOG.commands: commands: ('jobs', 'get', '8794986981471793048', '-o', 'json')
        LOG.commands: exit=0
        LOG.commands: {
        LOG.commands:   "created_time": 1794986981472,
        LOG.commands:   "creator_user_name": "tester@databricks.com",
        LOG.commands:   "job_id": 8794986981471793048,
        LOG.commands:   "run_as_user_name": "tester@databricks.com",
        LOG.commands:   "settings": {
        LOG.commands:     "deployment": {
        LOG.commands:       "deployment_id": "4000000000000450",
        LOG.commands:       "kind": "BUNDLE",
        LOG.commands:       "metadata_file_path": "/Workspace/Users/tester@databricks.com/.bundle/dms-fault-heartbeat-commands-enlhq2exsfaibi6l2mbwskidj4/state/metadata.json",
        LOG.commands:       "version_id": "2"
        LOG.commands:     },
        LOG.commands:     "description": "history-true",
        LOG.commands:     "edit_mode": "UI_LOCKED",
        LOG.commands:     "email_notifications": {},
        LOG.commands:     "format": "MULTI_TASK",
        LOG.commands:     "max_concurrent_runs": 1,
        LOG.commands:     "name": "updated-dms-fault-heartbeat-commands-enlhq2exsfaibi6l2mbwskidj4",
        LOG.commands:     "queue": {
        LOG.commands:       "enabled": true
        LOG.commands:     },
        LOG.commands:     "timeout_seconds": 0,
        LOG.commands:     "webhook_notifications": {}
        LOG.commands:   }
        LOG.commands: }
        LOG.commands: 
        LOG.commands: commands: ('pipelines', 'get', '7a0e120f-d2e7-c21c-7a0e-120fd2e7c31b', '-o', 'json')
        LOG.commands: exit=0
        LOG.commands: {
        LOG.commands:   "creator_user_name": "tester@databricks.com",
        LOG.commands:   "effective_publishing_mode": "DEFAULT_PUBLISHING_MODE",
        LOG.commands:   "last_modified": 1794986981473,
        LOG.commands:   "name": "updated-dms-fault-heartbeat-commands-enlhq2exsfaibi6l2mbwskidj4",
        LOG.commands:   "pipeline_id": "7a0e120f-d2e7-c21c-7a0e-120fd2e7c31b",
        LOG.commands:   "run_as_user_name": "tester@databricks.com",
        LOG.commands:   "spec": {
        LOG.commands:     "catalog": "main",
        LOG.commands:     "channel": "CURRENT",
        LOG.commands:     "deployment": {
        LOG.commands:       "deployment_id": "4000000000000450",
        LOG.commands:       "kind": "BUNDLE",
        LOG.commands:       "metadata_file_path": "/Workspace/Users/tester@databricks.com/.bundle/dms-fault-heartbeat-commands-enlhq2exsfaibi6l2mbwskidj4/state/metadata.json",
        LOG.commands:       "version_id": "2"
        LOG.commands:     },
        LOG.commands:     "edition": "ADVANCED",
        LOG.commands:     "id": "7a0e120f-d2e7-c21c-7a0e-120fd2e7c31b",
        LOG.commands:     "libraries": [
        LOG.commands:       {
        LOG.commands:         "file": {
        LOG.commands:           "path": "/Workspace/Users/tester@databricks.com/.bundle/dms-fault-heartbeat-commands-enlhq2exsfaibi6l2mbwskidj4/files/pipeline.sql"
        LOG.commands:         }
        LOG.commands:       }
        LOG.commands:     ],
        LOG.commands:     "name": "updated-dms-fault-heartbeat-commands-enlhq2exsfaibi6l2mbwskidj4",
        LOG.commands:     "schema": "default",
        LOG.commands:     "serverless": true
        LOG.commands:   },
        LOG.commands:   "state": "IDLE"
        LOG.commands: }
        LOG.commands: 
        LOG.commands: commands: ('bundle', 'summary')
        LOG.commands: exit=0
        LOG.commands: Name: updated-dms-fault-heartbeat-commands-enlhq2exsfaibi6l2mbwskidj4
        LOG.commands: Target: default
        LOG.commands: Workspace:
        LOG.commands:   User: tester@databricks.com
        LOG.commands:   Path: /Workspace/Users/tester@databricks.com/.bundle/dms-fault-heartbeat-commands-enlhq2exsfaibi6l2mbwskidj4
        LOG.commands: Resources:
        LOG.commands:   Jobs:
        LOG.commands:     foo:
        LOG.commands:       Name: updated-dms-fault-heartbeat-commands-enlhq2exsfaibi6l2mbwskidj4
        LOG.commands: ... (354 more lines truncated, raise DATABRICKS_CLI_TEST_MAX_LOG to see more)

latest (v1.26.0):

acceptance_test.go:1384: Diff:
        --- bundle/dms_fault/heartbeat/output.txt
        +++ /tmp/TestAcceptbundledms_faultheartbeatDMS=true1747621574/002/output.txt
        @@ -141,4 +141,4 @@
         
           Destroy: 2 deleted
         
        -DMS API called: yes
        +DMS API called: no
        
    acceptance_test.go:1162: 
        LOG.commands: 
        LOG.commands: commands: ('bundle', 'deploy', '--auto-approve')
        LOG.commands: exit=0
        LOG.commands: Uploading bundle files to /Workspace/Users/tester@databricks.com/.bundle/dms-fault-heartbeat-commands-k6ekdoervbdofpoyzjx4ukn3ya/files...
        LOG.commands: Current Deployment Version: http://127.0.0.1:38159/deployments/4000000000000450?version=1
        LOG.commands: Created pipelines.bar
        LOG.commands: Created jobs.foo
        LOG.commands: Files: 4 uploaded, 0 deleted
        LOG.commands: Resources: 2 created, 0 changed, 0 deleted, 0 unchanged
        LOG.commands: 
        LOG.commands: commands: ('workspace', 'get-status', '/Workspace/Users/tester@databricks.com/.bundle/dms-fault-heartbeat-commands-k6ekdoervbdofpoyzjx4ukn3ya/state/resources.deployment.json', '-o', 'json')
        LOG.commands: exit=0
        LOG.commands: {
        LOG.commands:   "object_id": 4000000000000450,
        LOG.commands:   "object_type": "BUNDLE_DEPLOYMENT",
        LOG.commands:   "path": "/Workspace/Users/tester@databricks.com/.bundle/dms-fault-heartbeat-commands-k6ekdoervbdofpoyzjx4ukn3ya/state/resources.deployment.json"
        LOG.commands: }
        LOG.commands: 
        LOG.commands: commands: ('bundle', 'deploy', '--auto-approve')
        LOG.commands: exit=0
        LOG.commands: Uploading bundle files to /Workspace/Users/tester@databricks.com/.bundle/dms-fault-heartbeat-commands-k6ekdoervbdofpoyzjx4ukn3ya/files...
        LOG.commands: Current Deployment Version: http://127.0.0.1:38159/deployments/4000000000000450?version=2
        LOG.commands: Updated pipelines.bar
        LOG.commands: Updated jobs.foo
        LOG.commands: Files: 3 uploaded, 0 deleted
        LOG.commands: Resources: 0 created, 2 changed, 0 deleted, 0 unchanged
        LOG.commands: 
        LOG.commands: commands: ('jobs', 'get', '8794986999496159346', '-o', 'json')
        LOG.commands: exit=0
        LOG.commands: {
        LOG.commands:   "created_time": 1794986999496,
        LOG.commands:   "creator_user_name": "tester@databricks.com",
        LOG.commands:   "job_id": 8794986999496159346,
        LOG.commands:   "run_as_user_name": "tester@databricks.com",
        LOG.commands:   "settings": {
        LOG.commands:     "deployment": {
        LOG.commands:       "deployment_id": "4000000000000450",
        LOG.commands:       "kind": "BUNDLE",
        LOG.commands:       "metadata_file_path": "/Workspace/Users/tester@databricks.com/.bundle/dms-fault-heartbeat-commands-k6ekdoervbdofpoyzjx4ukn3ya/state/metadata.json",
        LOG.commands:       "version_id": "2"
        LOG.commands:     },
        LOG.commands:     "description": "history-true",
        LOG.commands:     "edit_mode": "UI_LOCKED",
        LOG.commands:     "email_notifications": {},
        LOG.commands:     "format": "MULTI_TASK",
        LOG.commands:     "max_concurrent_runs": 1,
        LOG.commands:     "name": "updated-dms-fault-heartbeat-commands-k6ekdoervbdofpoyzjx4ukn3ya",
        LOG.commands:     "queue": {
        LOG.commands:       "enabled": true
        LOG.commands:     },
        LOG.commands:     "timeout_seconds": 0,
        LOG.commands:     "webhook_notifications": {}
        LOG.commands:   }
        LOG.commands: }
        LOG.commands: 
        LOG.commands: commands: ('pipelines', 'get', '7a0e1214-04f3-0b1b-7a0e-121404f30c2c', '-o', 'json')
        LOG.commands: exit=0
        LOG.commands: {
        LOG.commands:   "creator_user_name": "tester@databricks.com",
        LOG.commands:   "effective_publishing_mode": "DEFAULT_PUBLISHING_MODE",
        LOG.commands:   "last_modified": 1794986999492,
        LOG.commands:   "name": "updated-dms-fault-heartbeat-commands-k6ekdoervbdofpoyzjx4ukn3ya",
        LOG.commands:   "pipeline_id": "7a0e1214-04f3-0b1b-7a0e-121404f30c2c",
        LOG.commands:   "run_as_user_name": "tester@databricks.com",
        LOG.commands:   "spec": {
        LOG.commands:     "catalog": "main",
        LOG.commands:     "channel": "CURRENT",
        LOG.commands:     "deployment": {
        LOG.commands:       "deployment_id": "4000000000000450",
        LOG.commands:       "kind": "BUNDLE",
        LOG.commands:       "metadata_file_path": "/Workspace/Users/tester@databricks.com/.bundle/dms-fault-heartbeat-commands-k6ekdoervbdofpoyzjx4ukn3ya/state/metadata.json",
        LOG.commands:       "version_id": "2"
        LOG.commands:     },
        LOG.commands:     "edition": "ADVANCED",
        LOG.commands:     "id": "7a0e1214-04f3-0b1b-7a0e-121404f30c2c",
        LOG.commands:     "libraries": [
        LOG.commands:       {
        LOG.commands:         "file": {
        LOG.commands:           "path": "/Workspace/Users/tester@databricks.com/.bundle/dms-fault-heartbeat-commands-k6ekdoervbdofpoyzjx4ukn3ya/files/pipeline.sql"
        LOG.commands:         }
        LOG.commands:       }
        LOG.commands:     ],
        LOG.commands:     "name": "updated-dms-fault-heartbeat-commands-k6ekdoervbdofpoyzjx4ukn3ya",
        LOG.commands:     "schema": "default",
        LOG.commands:     "serverless": true
        LOG.commands:   },
        LOG.commands:   "state": "IDLE"
        LOG.commands: }
        LOG.commands: 
        LOG.commands: commands: ('bundle', 'summary')
        LOG.commands: exit=0
        LOG.commands: Name: updated-dms-fault-heartbeat-commands-k6ekdoervbdofpoyzjx4ukn3ya
        LOG.commands: Target: default
        LOG.commands: Workspace:
        LOG.commands:   User: tester@databricks.com
        LOG.commands:   Path: /Workspace/Users/tester@databricks.com/.bundle/dms-fault-heartbeat-commands-k6ekdoervbdofpoyzjx4ukn3ya
        LOG.commands: Resources:
        LOG.commands:   Jobs:
        LOG.commands:     foo:
        LOG.commands:       Name: updated-dms-fault-heartbeat-commands-k6ekdoervbdofpoyzjx4ukn3ya
        LOG.commands: ... (354 more lines truncated, raise DATABRICKS_CLI_TEST_MAX_LOG to see more)

@Sankalp-Mittal Sankalp-Mittal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[AI Generated] Review by review-factory (Claude Fable 5.2 + Claude Opus 5.5, cross-verified). Only points the reviewers agreed on are posted.

No issues found.

@denik
denik added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 56f8a02 Nov 18, 2026
27 checks passed
@denik
denik deleted the dms-heartbeat-interval-env branch November 18, 2026 11:24
@denik denik added factory-generated and removed ai-auto Deprecated: use factory-generated instead. labels Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues factory-generated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants