Repository navigation
Stop integration go test before the CI runner's 6h job limit - #7749
Merged
Merged
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: da0d0f0
Top 3 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 18, 2026 06:02
denik
requested review from
Sankalp-Mittal,
andrewnester and
rugpanov
and removed request for
rugpanov
November 18, 2026 06:02
andrewnester
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Lower the
go testtimeout of theintegrationandintegration-shorttasks from 12h to 5h20m.Why
The integration jobs run on GitHub-hosted runners, which cancel a job after 6h. Since 2026-11-16, most main runs during working hours need more than 6h: every test is about 1.65x slower (median) under the current CI load, and some, such as
bundle/resources/job_runs/failed_run, take about 45 minutes instead of 2. Off-peak runs still finish in about 3h10m to 3h50m.The runner cancels the job about 350 minutes into the test step. With
-timeout=12hthe Go timeout never fires, so the cancelled job leaves:[package]failure with no output;FAIL ... (-1.00s)(about 350 tests per job);At 5h20m,
go testpanics first. Its output lists the tests that were still running, and the reporting steps still have about 25 minutes before the job limit. This makes slow runs readable; it does not make them faster. CI load is outside this repo.The 12h timeout came from #5658, when the goal was to stop
go testfrom cutting runs short at 2h. Nothing on these runners can use more than 6h. The slowest off-peak run I found took 4h47m of test-step time, which fits under 5h20m.Dashboard:
ERROR failed to interrupt 'go test': not supported by windows/FAIL Package acceptance (5h46m59.789s)/DONE 2985 tests, 1348 skipped, 353 failures in 20937.308s/##[error]The operation was canceled.Tests
No behavior change outside CI. I checked that
task --list-allstill parses the Taskfile. The next long main run shows the effect.This pull request and its description were written by Isaac.