Repository navigation
acc: wait for RUNNING before planning in clusters/resize-terminated-fallback - #7751
Merged
Merged
Conversation
…allback The planner chooses resize only when the cluster is RUNNING at plan time. On cloud the cluster is sometimes not RUNNING right after deploy, so the plan says update and the golden (Resized + /clusters/resize) mismatches. Wait for RUNNING before planning and record the planned action. cloud: TestAccept/bundle/resources/clusters/resize-terminated-fallback Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=0 unreleased=0 coverage=2 failing=0
|
Collaborator
✅ Integration test reportCommit: 88b192d
Top 11 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 18, 2026 08:38
denik
requested review from
Sankalp-Mittal,
andrewnester,
anton-107 and
rugpanov
and removed request for
anton-107 and
rugpanov
November 18, 2026 08:38
denik
enabled auto-merge
November 18, 2026 08:38
Sankalp-Mittal
left a comment
Contributor
There was a problem hiding this comment.
[AI Generated] Review by review-factory (Claude Fable 5.2 + Claude Opus 5.5, cross-verified). Only points the reviewers agreed on are posted.
Waiting for the first RUNNING still left a window where the cluster could leave RUNNING before the plan read it. Retry the plan itself until it says resize, using the retry helper (MSYS_NO_PATHCONV-safe on Windows). cloud: TestAccept/bundle/resources/clusters/resize-terminated-fallback Co-authored-by: Isaac <no-reply@databricks.com>
andrewnester
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
bundle/resources/clusters/resize-terminated-fallbackplans a resize and then terminates the cluster to exercise the resize to edit fallback. The planner choosesresizeonly if the cluster is RUNNING at plan time (OverrideChangeDescinbundle/direct/dresources/cluster.go). Deploy waits for RUNNING after create, but on cloud the cluster is sometimes not RUNNING yet when the plan runs. The plan then saysupdate, the saved plan skips resize, and the golden doesn't match.This PR:
bundle plan(up to 60 × 10s, via theretryhelper) until it plansresize. The saved plan decides the apply path, so the cluster's state after the plan is saved doesn't matter. Waiting for RUNNING before planning would not be enough: the cluster can still leave RUNNING before the plan reads it;resize) in the output.The CLI behavior is correct: a non-running cluster should get edit, not resize. Only the test setup was racy.
Why
It flakes on main, on aws and azure. Both variants are affected:
-Resized clusters.test_cluster/+Updated clusters.test_clusterTests: TestAccept/bundle/resources/clusters/resize-terminated-fallback/DMS=, TestAccept/bundle/resources/clusters/resize-terminated-fallback/DMS=true
Tests
Local run passes. The commit message has a
cloud:line, so this PR's cloud CI runs the test on every cloud.This pull request and its description were written by Isaac.