Repository navigation
Follow up on #6399 review: shorter changelog entry, show app state in test - #7761
Merged
Merged
Conversation
Shorten the changelog fragment to one line, as suggested in review. In source-code-path-update, print the stored source_code_path after the redeploy so the test shows that the update sends no request but still records the new value in the deployment state. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=0 unreleased=2 coverage=0 failing=0
TestAccept/bundle/resources/apps/source-code-path-update/DMS=: branch ✅ | main (75c0a4c) ✅ | latest (v1.26.0) ❌latest (v1.26.0): TestAccept/bundle/resources/apps/source-code-path-update/DMS=true: branch ✅ | main (75c0a4c) ✅ | latest (v1.26.0) ❌latest (v1.26.0): |
Collaborator
✅ Integration test reportCommit: f2844ee
Top 3 slowest tests (at least 2 minutes):
|
pietern
approved these changes
Nov 18, 2026
Collaborator
❌ Integration test reportCommit: 1b7a413
1245 interesting tests: 1227 MISS, 7 RECOVERED, 6 PANIC, 5 FAIL
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #6399. Shortens the changelog entry as suggested in review.
source_code_pathinsource-code-path-update, so the test shows the update sends no request but still records the new value in state.Why
Addresses the open review threads on #6399.
update-source-code-path-cloudis kept: it is the real-workspace run of the same rule.Tests
source-code-path-update(both DMS variants) andupdate-source-code-path-cloudacceptance tests.🤖 Generated with Claude Code