Repository navigation
acc: make the suite runnable against DMS in Litebox - #7762
Open
shreyas-goenka wants to merge 3 commits into
Open
shreyas-goenka wants to merge 3 commits into
shreyas-goenka wants to merge 3 commits into
Conversation
Two cases cannot run when Litebox serves DMS and the workspace API: one stubs a DMS route that Litebox never routes to the stub, and one creates a snapshot through the testserver-only snapshots API that Litebox's workspace fake cannot see. Add a `Litebox = false` test.toml setting that skips such a case when DMS_CLI_ENDPOINTS_FILE settings are found, and materialize it in out.test.toml. Litebox also allocates two-digit tree ids, so a literal replacement for a deployment id matched inside UUIDs and cut them up. Word-bound all-digit literal replacements in libs/testdiff and in the repls.py mirror. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 3 tests: regression=0 unreleased=0 coverage=3 failing=0
|
Collaborator
✅ Integration test reportCommit: 4358098
Top 33 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac <no-reply@databricks.com>
…reasons Co-authored-by: Isaac <no-reply@databricks.com>
shreyas-goenka
marked this pull request as ready for review
November 19, 2026 11:10
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets the acceptance suite run against DMS in Litebox (universe's
bundle/metadata-service/acceptancerunner, see databricks-eng/universe#3144526). Adds aLitebox = falsetest.toml setting that skips a case when Litebox connection settings are found, and sets it on the twobundle/dmscases that only work on the fake: one stubs a DMS route with[[Server]], one creates a snapshot through the testserver-only snapshots API.Scope: only
bundle/dmsis marked, since that is all the Litebox job runs; other dirs that stub Litebox-routed paths are not. Local runs are unaffected; in Litebox the other 19bundle/dmsvariants pass and these two skip.This pull request and its description were written by Isaac.