Skip to content

acc: make the suite runnable against DMS in Litebox - #7762

Open
shreyas-goenka wants to merge 3 commits into
mainfrom
shreyas/dms-litebox-harness
Open

shreyas-goenka wants to merge 3 commits into
mainfrom
shreyas/dms-litebox-harness

Conversation

@shreyas-goenka

@shreyas-goenka shreyas-goenka commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Lets the acceptance suite run against DMS in Litebox (universe's bundle/metadata-service/acceptance runner, see databricks-eng/universe#3144526). Adds a Litebox = false test.toml setting that skips a case when Litebox connection settings are found, and sets it on the two bundle/dms cases that only work on the fake: one stubs a DMS route with [[Server]], one creates a snapshot through the testserver-only snapshots API.
Scope: only bundle/dms is marked, since that is all the Litebox job runs; other dirs that stub Litebox-routed paths are not. Local runs are unaffected; in Litebox the other 19 bundle/dms variants pass and these two skip.

This pull request and its description were written by Isaac.

Two cases cannot run when Litebox serves DMS and the workspace API: one stubs
a DMS route that Litebox never routes to the stub, and one creates a snapshot
through the testserver-only snapshots API that Litebox's workspace fake cannot
see. Add a `Litebox = false` test.toml setting that skips such a case when
DMS_CLI_ENDPOINTS_FILE settings are found, and materialize it in out.test.toml.

Litebox also allocates two-digit tree ids, so a literal replacement for a
deployment id matched inside UUIDs and cut them up. Word-bound all-digit
literal replacements in libs/testdiff and in the repls.py mirror.

Co-authored-by: Isaac <no-reply@databricks.com>
@github-actions github-actions Bot added DABs DABs related issues test-only-fix PRs that update failing of flaky tests without changing CLI code. labels Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Commit: 435809819 | Workflow run

Regression test report

Selected 2 changed tests (limit=20, 0 not selected)

3 tests: regression=0 unreleased=0 coverage=3 failing=0
test branch main (934ffd3) latest (v1.26.0)
TestAccept/bundle/dms/immutable-folder/DMS=true/READPLAN= ✅ ✅ ✅
TestAccept/bundle/dms/immutable-folder/DMS=true/READPLAN=1 ✅ ✅ ✅
TestAccept/bundle/dms/version-never-created/DMS=true ✅ ✅ ✅

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 4358098

Run: 44312300252

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 272 21 17:43
💚​ aws-windows-latest-4core-16gb 1 274 19 10:55
💚​ azure linux-2core-8gb 1 271 21 16:27
💚​ azure-windows-latest-4core-16gb 1 273 19 11:41
💚​ gcp linux-2core-8gb 1 272 21 13:07
💚​ gcp-windows-latest-4core-16gb 1 274 19 9:12
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 33 slowest tests (at least 2 minutes):
duration env testname
5:17 aws linux-2core-8gb TestFilerRecursiveDelete/workspace_files
3:53 aws-windows-latest-4core-16gb TestImportDirDoesNotOverwrite
3:43 aws-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsStat
3:37 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsDelete
3:34 azure-windows-latest-4core-16gb TestExportDir
3:32 aws-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
3:29 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsRead
3:21 azure-windows-latest-4core-16gb TestAccept
3:08 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsRead
3:07 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
3:06 gcp-windows-latest-4core-16gb TestAccept
3:05 azure linux-2core-8gb TestFilerWorkspaceNotebook/sqlJupyterNotebook.ipynb
3:04 aws linux-2core-8gb TestSyncIncrementalFileSync
3:01 azure-windows-latest-4core-16gb TestImportDir
3:01 aws linux-2core-8gb TestFilerRecursiveDelete/workspace_files_extensions
2:55 aws-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files
2:53 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsStat
2:47 aws-windows-latest-4core-16gb TestAccept
2:45 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsRead
2:45 aws-windows-latest-4core-16gb TestFilerReadDir/workspace_files_extensions
2:42 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsStat
2:41 azure linux-2core-8gb TestSyncFullFileSync
2:30 gcp-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files
2:29 gcp linux-2core-8gb TestFilerRecursiveDelete/workspace_files
2:28 gcp-windows-latest-4core-16gb TestImportDir
2:18 azure linux-2core-8gb TestImportDirDoesNotOverwrite
2:18 azure-windows-latest-4core-16gb TestSyncFullFileSync
2:15 gcp-windows-latest-4core-16gb TestExportDir
2:14 aws linux-2core-8gb TestExportDirWithOverwriteFlag
2:11 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
2:10 azure linux-2core-8gb TestFilerRecursiveDelete/workspace_files
2:08 aws-windows-latest-4core-16gb TestSyncIncrementalSyncFileToPythonNotebook
2:07 azure linux-2core-8gb TestImportDirWithOverwriteFlag

shreyas-goenka and others added 2 commits November 18, 2026 12:18
Co-authored-by: Isaac <no-reply@databricks.com>
…reasons

Co-authored-by: Isaac <no-reply@databricks.com>
@github-actions github-actions Bot removed the test-only-fix PRs that update failing of flaky tests without changing CLI code. label Nov 18, 2026
@shreyas-goenka
shreyas-goenka marked this pull request as ready for review November 19, 2026 11:10
@shreyas-goenka
shreyas-goenka requested review from a team as code owners November 19, 2026 11:10

@review-oss-bot review-oss-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me — no issues found.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants