Skip to content

acc: word-bound all-digit literal replacements - #7768

Open
shreyas-goenka wants to merge 2 commits into
mainfrom
shreyas/acc-numeric-literal-repls
Open

shreyas-goenka wants to merge 2 commits into
mainfrom
shreyas/acc-numeric-literal-repls

Conversation

@shreyas-goenka

@shreyas-goenka shreyas-goenka commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

A script-registered literal replacement for a short numeric id also matches inside UUIDs and cuts them up. Seen running bundle/dms/no-drift against DMS in Litebox, where deployment ids are two digits: "lineage": "842521b7-a159-4c[DEPLOYMENT_ID]-849b-24f82c5ce190". All-digit literals now match only at word boundaries, in libs/testdiff and the repls.py mirror.
Unit test added; the local bundle/ acceptance suite output is unchanged.

This pull request and its description were written by Isaac.

A script registers a resource id as a literal replacement, applied before the
harness patterns. A short id (a LITE workspace fake allocates two-digit ones)
then also matches inside UUIDs and timestamps and cuts them up. Match an
all-digit literal only at word boundaries, in libs/testdiff and its repls.py
mirror.

Co-authored-by: Isaac <no-reply@databricks.com>
@github-actions github-actions Bot added the test-only-fix PRs that update failing of flaky tests without changing CLI code. label Nov 18, 2026
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: e8094cb

Run: 44312308559

Env 🔄​flaky 💚​RECOVERED ✅​pass 🙈​skip Time
🔄​ aws linux-2core-8gb 1 1 271 19 20:04
💚​ aws-windows-latest-4core-16gb 1 274 17 9:06
💚​ azure linux-2core-8gb 1 271 19 16:54
💚​ azure-windows-latest-4core-16gb 1 273 17 10:10
💚​ gcp linux-2core-8gb 1 272 19 15:07
💚​ gcp-windows-latest-4core-16gb 1 274 17 9:31
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🔄​ TestImportDir 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p
Top 32 slowest tests (at least 2 minutes):
duration env testname
4:02 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
4:01 azure-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files
3:55 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsRead
3:49 aws linux-2core-8gb TestFilerRecursiveDelete/workspace_files_extensions
3:35 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsRead
3:29 gcp-windows-latest-4core-16gb TestAccept
3:29 azure linux-2core-8gb TestImportDirDoesNotOverwrite
3:21 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
3:06 aws-windows-latest-4core-16gb TestAccept
3:00 azure-windows-latest-4core-16gb TestAccept
2:56 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
2:42 aws-windows-latest-4core-16gb TestLock
2:36 aws linux-2core-8gb TestFilerRecursiveDelete/workspace_files
2:33 gcp linux-2core-8gb TestFilerWorkspaceFilesExtensionsDelete
2:32 aws-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files_extensions
2:31 aws-windows-latest-4core-16gb TestSyncFullFileSync
2:29 aws-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsRead
2:25 aws-windows-latest-4core-16gb TestSyncIncrementalFileSync
2:25 azure-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files_extensions
2:22 gcp linux-2core-8gb TestFilerWorkspaceNotebook/rNb.r
2:21 gcp linux-2core-8gb TestFilerRecursiveDelete/workspace_files
2:21 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsDelete
2:16 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsStat
2:16 aws linux-2core-8gb TestLock
2:15 gcp linux-2core-8gb TestExportDir
2:15 gcp linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
2:15 gcp-windows-latest-4core-16gb TestImportDirWithOverwriteFlag
2:14 aws-windows-latest-4core-16gb TestFilerReadDir/workspace_files_extensions
2:12 azure linux-2core-8gb TestExportDir
2:10 azure-windows-latest-4core-16gb TestLock
2:05 aws linux-2core-8gb TestWorkpaceExportPrintsContents
2:01 aws-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir

…it check

Co-authored-by: Isaac <no-reply@databricks.com>
@shreyas-goenka
shreyas-goenka marked this pull request as ready for review November 19, 2026 11:10
@shreyas-goenka
shreyas-goenka requested a review from a team as a code owner November 19, 2026 11:10

@review-oss-bot review-oss-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me — no issues found.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-only-fix PRs that update failing of flaky tests without changing CLI code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants