Repository navigation
Forward /review comment IDs for progress reactions - #7772
Draft
janniklasrose wants to merge 1 commit into
Draft
janniklasrose wants to merge 1 commit into
janniklasrose wants to merge 1 commit into
Conversation
Collaborator
✅ Integration test reportCommit: 397fe36
Top 35 slowest tests (at least 2 minutes):
|
shreyas-goenka
approved these changes
Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Forward the original
/reviewcomment ID to the review backend. Automatic reviews send an empty comment ID.Why
Let the review bot acknowledge CLI review requests with 👀 and replace it with 🎉 only after publishing the review. Reaction failures do not block reviews.
Requires https://github.com/databricks-eng/eng-dev-ecosystem/pull/1622 to merge first so the backend accepts the new optional input.
Tests
This PR was created with GitHub MCP.