Repository navigation
Open a tracking issue when a workflow fails on main - #7773
Draft
janniklasrose wants to merge 1 commit into
Draft
janniklasrose wants to merge 1 commit into
janniklasrose wants to merge 1 commit into
Conversation
A failed run on main is only visible in the Actions tab, so breakages that the merge queue does not catch (Windows- or macOS-only test failures, the changelog preview, snapshot builds) can go unnoticed. Add a workflow_run handler that reuses the report-failure action from the dependency bumpers to open one issue per breakage and comment on it for each further failure. Integration tests are not covered: they run in another repository and are not expected to always be green. The action gains optional "workflow" and "run-url" inputs so a workflow_run handler can report on behalf of the failed run; the bumpers keep the current-run defaults. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: f89ccae
Top 34 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add a
Report main failureworkflow that opens a tracking issue when one of the workflows that run onmainfails, and comments on that issue for every further failure until someone closes it. It coversbuild,check,python build,Changelog Preview,conftestandrelease-build, triggered viaworkflow_runon push and the nightly schedule.The issue logic is the existing
report-failurecomposite action used by the dependency bumpers. It gains two optional inputs,workflowandrun-url, so aworkflow_runhandler can report on behalf of the failed run. The bumpers keep the current-run defaults. Since severalmainworkflows now share one action, the repeat-failure comment names the workflow and the issue body no longer says "scheduled".Integration tests are deliberately not covered: they run in another repository and are not expected to be green at all times.
Why
A failed run on
mainis only visible in the Actions tab, so nobody is notified. The merge queue catches most breakages before a commit lands, but not all: the Windows and macOS test cells only run on push, the changelog preview is not a merge-queue check, andrelease-buildsnapshots only run onmain. We have hadmaingo red in these ways in the past.A separate
workflow_runhandler, rather than a failure job in each affected workflow, keeps the issue logic in one place and avoids grantingissues: writeto the test workflows.Design notes:
branches: [main]filter onworkflow_runmatches the head branch of the triggering run, so a fork PR from a branch namedmainwould match too. The job additionally checks the triggering event ispushorschedule.concurrencygroup serializes the reporter so one push that failsbuildandcheckat the same time opens a single issue instead of two.github-actionsdoes not notify the team's members.Tests
yamlfmt -lintand the whitespace validator.actions/checkout, pinned to the SHA already used inpush.yml, so the conftest pinning policy holds.workflow_runhandlers only fire from the default branch, so the behavior cannot be exercised on this PR. It takes effect once merged. The next failure onmainis the first real test. I will close the issue it opens if it turns out to be a false positive.No changelog fragment: this is CI-only.
This pull request and its description were written by Isaac.