Repository navigation
acc: print the invariant tests' LOG.*.err files on failure - #7779
Merged
Merged
Conversation
The "*.err" ignore pattern is matched before the LOG prefix, so the stderr of a failing `bundle plan` was never printed and the test log showed only "Exit code: 1". Every .err file these tests write is a LOG.* file. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: 7c53dd9
Top 13 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 18, 2026 17:53
denik
requested review from
Sankalp-Mittal,
andrewnester,
janniklasrose and
rclarey
and removed request for
rclarey
November 18, 2026 17:53
andrewnester
approved these changes
Nov 18, 2026
Sankalp-Mittal
approved these changes
Nov 18, 2026
Sankalp-Mittal
left a comment
Contributor
There was a problem hiding this comment.
[AI Generated] Review by review-factory (Claude Fable 5.2 + Claude Opus 5.5, cross-verified). Only points the reviewers agreed on are posted.
No issues found.
Collaborator
❌ Integration test reportCommit: e822544
23 interesting tests: 14 RECOVERED, 8 FAIL, 1 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
acceptance/bundle/invariant/test.tomlno longer ignores*.err. The harness checks the ignore patterns before theLOGprefix, so theLOG.*.errfiles these scripts write (bundle plan -o json > ... 2>LOG.plan_initial.err,LOG.planjson.err, ...) were never printed. A failing plan then left onlyExit code: 1in the test log. Every.errfile underacceptance/bundle/invariantis aLOG.*file, so no test gains an unexpected output file.Why
Split out of #7770 at review. This makes the silent invariant failures behind error/1045 diagnosable. It does not fix them: the recent ones have different causes (a vector search endpoint plan, an app plan).
Tests
TestAccept/bundle/invariantpasses locally.Dashboard
expected: "INPUT_CONFIG_OK\n",actual : "\nExit code: 1\n"This pull request and its description were written by Isaac.