Repository navigation
fs cp -r: retry transient directory errors - #7787
Draft
yuanjieding-db wants to merge 1 commit into
Draft
yuanjieding-db wants to merge 1 commit into
yuanjieding-db wants to merge 1 commit into
Conversation
yuanjieding-db
force-pushed
the
yuanjieding-db/fs-cp-breaker
branch
from
November 18, 2026 18:14
af4903e to
717bb8b
Compare
yuanjieding-db
force-pushed
the
yuanjieding-db/fs-cp-walk-retry
branch
from
November 18, 2026 18:14
a7c5b35 to
e704d85
Compare
Contributor
|
Commit: Regression test reportSelected 7 changed tests (limit=20, 0 not selected) 7 tests: regression=7 unreleased=0 coverage=0 failing=0
TestAccept/cmd/fs/cp-r-keep-going/burst-retry-after: branch ✅ | main (4e503ea) ❌ | latest (v1.26.0) ❌main (4e503ea): latest (v1.26.0): same output as main (4e503ea) TestAccept/cmd/fs/cp-r-keep-going/mkdir-500: branch ✅ | main (4e503ea) ❌ | latest (v1.26.0) ❌main (4e503ea): latest (v1.26.0): TestAccept/cmd/fs/cp-r-keep-going/outage-past-stall: branch ✅ | main (4e503ea) ❌ | latest (v1.26.0) ❌main (4e503ea): latest (v1.26.0): TestAccept/cmd/fs/cp-r-keep-going/persistent-500: branch ✅ | main (4e503ea) ❌ | latest (v1.26.0) ❌main (4e503ea): latest (v1.26.0): TestAccept/cmd/fs/cp-r-keep-going/single-500: branch ✅ | main (4e503ea) ❌ | latest (v1.26.0) ❌main (4e503ea): latest (v1.26.0): TestAccept/cmd/fs/cp-r-requests: branch ✅ | main (4e503ea) ❌ | latest (v1.26.0) ❌main (4e503ea): latest (v1.26.0): same output as main (4e503ea) TestAccept/cmd/fs/cp/dir-to-dir: branch ✅ | main (4e503ea) ❌ | latest (v1.26.0) ❌main (4e503ea): latest (v1.26.0): same output as main (4e503ea) |
Collaborator
✅ Integration test reportCommit: 9b1f622
Top 21 slowest tests (at least 2 minutes):
|
yuanjieding-db
force-pushed
the
yuanjieding-db/fs-cp-breaker
branch
from
November 18, 2026 19:03
717bb8b to
7c7d3c8
Compare
yuanjieding-db
force-pushed
the
yuanjieding-db/fs-cp-walk-retry
branch
from
November 18, 2026 19:03
e704d85 to
0aa78e6
Compare
This was referenced Nov 18, 2026
yuanjieding-db
force-pushed
the
yuanjieding-db/fs-cp-breaker
branch
from
November 18, 2026 19:38
7c7d3c8 to
bdcee00
Compare
yuanjieding-db
force-pushed
the
yuanjieding-db/fs-cp-walk-retry
branch
from
November 18, 2026 19:38
0aa78e6 to
0909349
Compare
yuanjieding-db
force-pushed
the
yuanjieding-db/fs-cp-breaker
branch
from
November 18, 2026 19:54
bdcee00 to
4a552ce
Compare
yuanjieding-db
force-pushed
the
yuanjieding-db/fs-cp-walk-retry
branch
from
November 18, 2026 19:54
0909349 to
a7cefac
Compare
A 500 on one Mkdir or source listing used to end the whole copy. A retryable error on a target Mkdir or a source directory listing during the walk is now retried in place, one call at a time, with the breaker's 2s to 30s backoff and Retry-After, until the call has failed for the stall timeout. A non-retryable error, or one that outlasts the timeout, still stops the copy. Co-authored-by: Isaac <no-reply@databricks.com>
yuanjieding-db
force-pushed
the
yuanjieding-db/fs-cp-breaker
branch
from
November 18, 2026 20:05
4a552ce to
54d8012
Compare
yuanjieding-db
force-pushed
the
yuanjieding-db/fs-cp-walk-retry
branch
from
November 18, 2026 20:06
a7cefac to
9b1f622
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack. Each PR is based on the one before it, so its diff shows only its own change.
This is part 6.
Changes
A 500 on one
Mkdiror source listing used to end the whole copy. A retryable error on a targetMkdir, a source listing, or the walk'sStatof the source root is now retried in place:Retry-After.Why
The goal is a large copy that finishes despite transient 5xx errors. A directory call is one of the requests that can hit one.
Tests
TestRecursiveCopyWalkRetry(fake clock):Mkdir500 is retried in place;cmd/fs/cp-r-keep-going/mkdir-500.Self-review
Isaac review, 1 finding:
/code-review(medium), 9 findings:Statof the source root wasn't retried. It's retried again, as in the validated build.Mkdir500. Listing retries and DBFS errors have unit tests.This pull request and its description were written by Isaac.