Repository navigation
acc: purge alerts created by bind/alert and generate/alert - #7796
Merged
Merged
Conversation
bind/alert never deleted the alert it created, and generate/alert only deleted the parent directory, which trashes the alert but keeps it. Both leaked an alert per cloud run; the Azure workspace hit its alert quota. aws: TestAccept/bundle/deployment/bind/alert TestAccept/bundle/generate/alert Co-authored-by: Isaac <no-reply@databricks.com>
denik
added a commit
that referenced
this pull request
Nov 19, 2026
go/cli/dashboard/error/3781 (42 failures in 8 main runs) and go/cli/dashboard/error/3782 (20 failures in 3 main runs), Azure only, failing since 2026-11-18 21:00Z: "The quota for the number of INTERNAL_HIDDEN jobs has been reached. The current quota for ALERT is 5000." Leaks are fixed in #7796; the tests stay red on Azure until the leaked alerts are purged from the workspace. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 4 tests: regression=0 unreleased=0 coverage=4 failing=0
|
Collaborator
✅ Integration test reportCommit: 2db4206
7 interesting tests: 7 RECOVERED
Top 3 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Nov 19, 2026
Sankalp-Mittal
approved these changes
Nov 19, 2026
Sankalp-Mittal
left a comment
Contributor
There was a problem hiding this comment.
[AI Generated] Review by review-factory (Claude Opus 5.5 + Claude Fable 5.2, cross-verified). Only points the reviewers agreed on are posted.
No blocking or major issues found.
Collaborator
❌ Integration test reportCommit: 9f607a3
1058 interesting tests: 1034 MISS, 11 RECOVERED, 5 FAIL, 4 PANIC, 4 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
idelafuente-oc
pushed a commit
to idelafuente-oc/cli
that referenced
this pull request
Nov 20, 2026
Follow-up to the review comment on databricks#7796: a trashed alert is deleted for good after 30 days, not kept until purged. This PR changes only that comment. Dashboard: [error/3781](http://go/cli/dashboard/error/3781?main=1&pr=1&end=2026-11-19T11:00:00Z&last=2d) (`The quota for the number of INTERNAL_HIDDEN jobs has been reached. The current quota for ALERT is 5000.`) This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
bundle/deployment/bind/alert: purge the alert the script creates (EXIT trap). Before,unbindleft it in the workspace on every cloud run.bundle/generate/alert: purge the alert (EXIT trap) beforescript.cleanupdeletes its parent directory. Deleting the directory only moves the alert to trash, and a trashed alert stays until it is purged (seecmd/workspace/alerts-v2-not-found).bundle destroyalready purges alerts (Purge: trueinbundle/direct/dresources/alert.go), so the deploy/destroy alert tests do not leak.Why
The Azure integration workspace has reached its alert quota, so every test that creates an alert fails there:
Error: The quota for the number of INTERNAL_HIDDEN jobs has been reached. The current quota for ALERT is 5000.Error: cannot create resources.alerts.[NAME]: The quota for the number of INTERNAL_HIDDEN jobs has been reached. The current quota for ALERT is 5000. (400 QUOTA_EXCEEDED)This PR stops the leaks. The alerts that have already leaked still need to be purged from the Azure workspace before these tests pass there again. Judgment call: I purge with
trash-alert --purgeinstead of adding abundle destroy, because the alert in both tests was created outside the bundle.Tests
Ran both tests locally and on AWS (
DMS=andDMS=true). They pass, and the golden output shows the purge call. Azure cannot be checked until the quota is freed.Dashboard:
This pull request and its description were written by Isaac.