Repository navigation
Conversation
Move the health-checked transport from bundle/config to libs/httptransport and use it in the shared integration-test workspace client and in the acceptance test proxy. Both live for the whole test process and share one connection pool, so a silently dropped connection made every later test in the job hang until the inactivity timeout. aws: TestAccept/bundle/resources/permissions/jobs/delete_one Co-authored-by: Isaac <no-reply@databricks.com>
Also keep a caller's transport in the test proxy, fix a stale pointer in libs/retry and add tests for the proxy transport. aws: TestAccept/bundle/resources/permissions/jobs/delete_one Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: d17f5e5
Top 3 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 19, 2026 10:41
denik
requested review from
Sankalp-Mittal,
andrewnester and
parthban-db
and removed request for
parthban-db
November 19, 2026 10:41
andrewnester
approved these changes
Nov 19, 2026
Sankalp-Mittal
left a comment
Contributor
There was a problem hiding this comment.
[AI Generated] Review by review-factory (Claude Opus 5.5 + Claude Fable 5.2, cross-verified). Only points the reviewers agreed on are posted.
…proxy transport aws: TestAccept/bundle/resources/permissions/jobs/delete_one Co-authored-by: Isaac <no-reply@databricks.com>
Sankalp-Mittal
left a comment
Contributor
There was a problem hiding this comment.
[AI Generated] Follow-up review by review-factory (Claude Opus 5.5 + Claude Fable 5.2, cross-verified). Only points the reviewers agreed on are posted.
No new issues found.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Stacked on #7723.
bundle/configto a newlibs/httptransportpackage and export it ashttptransport.HealthChecked(insecureSkipVerify). The code is unchanged; theWorkspace.Clienttest stays inbundle/config.integration/internal/acc: the shared workspace client of the integration tests (wt.W).libs/testproxy: the recording proxy that acceptance tests put in front of the real workspace.Why
These request timeouts are the same dead-connection failure that #7723 fixes, in the test harness instead of the CLI. The SDK uses one process-wide default transport. Both clients above share it for every test in the
go testprocess, so when the runner's connection to the workspace is silently dropped, every later request goes out over the same dead connection. Each one then times out after the 60s inactivity limit:integration/cmd/synctests from 02:29 to 02:35 in one Azure job, and 8 from 17:57 to 18:04 in one GCP Windows job.1m0s ... (500 UNKNOWN)below). The CLI's own client has a 1m30s timeout.#7723 covers only the CLI's bundle client, which issues the 1m30s variants. With this PR, a dead connection in the test harness is closed within 45s and the next request dials a new one. At most the in-flight request fails, not every test that follows.
Judgment calls:
libs/rather than importingbundle/configfrom the test harness.skip_verify; the integration tests and the proxy don't use it.cloudWorkspaceclient, which makes two calls once per process, and the CLI's non-bundle commands (production behavior; the SDK default transport is the long-term home for the health check).Tests
libs/httptransport,bundle/config), as does lint. Newlibs/testproxytests check the proxy's transport.bundle/resources/permissions/jobs/delete_one,selftest,bundle/deploy/files.testme: acceptancebundle/resources/permissions/jobs/delete_one(goes through the proxy) and integrationcmd/syncTestSyncEnsureRemotePathIsUsable*. The last commit runs the acceptance test on AWS in CI.libs/httptransporttests reproduce it with a blackhole proxy.Dashboard:
Received unexpected error: Get "[DATABRICKS_URL]/api/2.0/preview/scim/v2/Me": request timed out after 1m0s of inactivityReceived unexpected error: Post "[DATABRICKS_URL]/api/2.0/dbfs/mkdirs": request timed out after 1m0s of inactivityError: Post "[DATABRICKS_URL]/api/2.0/workspace-files/import-file/[PATH]": request timed out after 1m0s of inactivity (500 UNKNOWN)This pull request and its description were written by Isaac.