Skip to content

Show status and endpoint for API errors without a message; retry pipeline events reads - #7800

Merged
denik merged 6 commits into
mainfrom
generr-empty-message
Nov 19, 2026
Merged

denik merged 6 commits into
mainfrom
generr-empty-message

Conversation

@denik

@denik denik commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Changes

  • cmd/root: when an API error response has no message field, the SDK leaves APIError.Message empty and the CLI printed a bare Error: . Now it prints the HTTP status, error_code and endpoint, e.g. Error: API request failed with 500 Internal Server Error (INTERNAL_ERROR) from POST /api/2.0/lakeview/dashboards. This applies only when the whole error would print as nothing. Errors whose wrappers add their own text are left as they are (e.g. genie ask already explains a 500 with no details).
  • pipelines run / bundle run: the reads made while waiting for an update (the progress events, the update status, and the events read after completion) are now retried on transient errors (libs/retry.IsTransientRead) instead of aborting the run.

Why

Two main-branch integration test failures with opaque messages:

  • lakeview create (dashboard bind tests, before the first traced command) and alerts-v2 create-alert failed with an empty error message, so the logs don't show which request failed or why. This PR doesn't fix the backend failure itself. It makes the next occurrence show the status, code and endpoint.
  • pipelines run failed with Error: An unexpected error happened. right after the update reached INITIALIZING. That text is the message of a 500 INTERNAL_ERROR from the pipeline events list API. It is a read, so retrying is safe. The update itself kept running.

Decision: both fixes are in one PR because they come from the same investigation (generic or empty errors on main) and each is small.

Tests

  • New acceptance test cmd/empty-error-message: errors without a message (with and without error_code) and a normal error.
  • New acceptance test pipelines/run/events-500: one injected 500 on the events API is retried and the run completes.
  • Unit tests for describeEmptyAPIError.
  • The last commit asks CI to run pipelines/run/refresh-flags and bundle/deployment/bind/alert on AWS.

Dashboard

error verbatim snippet
error/98 >>> [CLI] alerts-v2 create-alert --json @alert.json / Error: / Exit code: 1
error/3627 update_progress INFO "Update 535c12 is INITIALIZING." / Error: An unexpected error happened.

Tests: TestAccept/bundle/deployment/bind/alert/DMS=, TestAccept/bundle/deployment/bind/dashboard/DMS=/READPLAN=, TestAccept/bundle/deployment/bind/dashboard/recreation/DMS=/READPLAN=1, TestAccept/pipelines/run/refresh-flags

This pull request and its description were written by Isaac.

…line events reads

An error response whose JSON body has no "message" field leaves the SDK's
APIError.Message empty, so the CLI printed a bare "Error: ". Print the HTTP
status, error_code and endpoint instead.

`pipelines run` / `bundle run` aborted when the events API returned a transient
500 ("An unexpected error happened.") while polling an update. Retry that read
with libs/retry, as other read paths do.

aws: TestAccept/pipelines/run/refresh-flags TestAccept/bundle/deployment/bind/alert

Co-authored-by: Isaac <no-reply@databricks.com>
@denik denik added the ai-auto Deprecated: use factory-generated instead. label Nov 19, 2026
@github-actions github-actions Bot added the DABs DABs related issues label Nov 19, 2026
aws: TestAccept/pipelines/run/refresh-flags TestAccept/bundle/deployment/bind/alert

Co-authored-by: Isaac <no-reply@databricks.com>
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Commit: 265587f84 | Workflow run

Regression test report

Selected 2 changed tests (limit=20, 0 not selected)

3 tests: regression=2 unreleased=0 coverage=1 failing=0
test branch main (70d24e3) latest (v1.27.0)
TestAccept/cmd/empty-error-message ✅ ❌ ❌
TestAccept/pipelines/run/events-500 ✅ ❌ ❌
TestAccept/pipelines/run/refresh-flags ✅ ✅ ✅
TestAccept/cmd/empty-error-message: branch ✅ | main (70d24e3) ❌ | latest (v1.27.0) ❌

main (70d24e3):

acceptance_test.go:1388: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1388
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1129
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:674
        	Error:      	Not equal: 
        	            	expected: "\n>>> errcode [CLI] lakeview create --display-name test\nError: API request failed with 500 Internal Server Error (INTERNAL_ERROR) from POST /api/2.0/lakeview/dashboards\n\nExit code: 1\n\n>>> errcode [CLI] lakeview get 1234\nError: API request failed with 404 Not Found from GET /api/2.0/lakeview/dashboards/1234\n\nExit code: 1\n\n>>> errcode [CLI] secrets list-scopes\nError: no access\n\nExit code: 1\n"
        	            	actual  : "\n>>> errcode [CLI] lakeview create --display-name test\nError: \n\nExit code: 1\n\n>>> errcode [CLI] lakeview get 1234\nError: \n\nExit code: 1\n\n>>> errcode [CLI] secrets list-scopes\nError: no access\n\nExit code: 1\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -2,3 +2,3 @@
        	            	 >>> errcode [CLI] lakeview create --display-name test
        	            	-Error: API request failed with 500 Internal Server Error (INTERNAL_ERROR) from POST /api/2.0/lakeview/dashboards
        	            	+Error: 
        	            	 
        	            	@@ -7,3 +7,3 @@
        	            	 >>> errcode [CLI] lakeview get 1234
        	            	-Error: API request failed with 404 Not Found from GET /api/2.0/lakeview/dashboards/1234
        	            	+Error: 
        	            	 
        	Test:       	TestAccept/cmd/empty-error-message
        	Messages:   	cmd/empty-error-message/output.txt vs /tmp/TestAcceptcmdempty-error-message3161449786/002/output.txt

latest (v1.27.0): same output as main (70d24e3)

TestAccept/pipelines/run/events-500: branch ✅ | main (70d24e3) ❌ | latest (v1.27.0) ❌

main (70d24e3):

acceptance_test.go:1388: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1388
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1129
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:674
        	Error:      	Not equal: 
        	            	expected: "\n>>> [CLI] pipelines deploy\nUploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-pipeline-run-flags/default/files...\nCreated pipelines.my_pipeline\nFiles: 2 uploaded, 0 deleted\nResources: 1 created, 0 changed, 0 deleted, 0 unchanged\nView your pipeline my_pipeline here: [DATABRICKS_URL]/pipelines/[UUID][0]?w=[WORKSPACE_ID]\n\n=== A 500 from the events API while polling the update is retried\n\n>>> [CLI] pipelines run\nRecommendation: This command runs the last deployed version of the code\n\nIf you've made local changes, run 'databricks pipelines deploy' first to ensure they are included.\n\nUpdate URL: [DATABRICKS_URL]/#joblist/pipelines/[UUID][0]/updates/[UUID][1]\n\nWarn: retrying after 500 Internal Server Error from GET /api/2.0/pipelines/[UUID][0]/events\nUpdate ID: [UUID][1]\n\nUpdate for pipeline completed successfully.\n\nPipeline configurations for this update:\n• All tables are refreshed\n"
        	            	actual  : "\n>>> [CLI] pipelines deploy\nUploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-pipeline-run-flags/default/files...\nCreated pipelines.my_pipeline\nFiles: 2 uploaded, 0 deleted\nResources: 1 created, 0 changed, 0 deleted, 0 unchanged\nView your pipeline my_pipeline here: [DATABRICKS_URL]/pipelines/[UUID][0]?w=[WORKSPACE_ID]\n\n=== A 500 from the events API while polling the update is retried\n\n>>> [CLI] pipelines run\nRecommendation: This command runs the last deployed version of the code\n\nIf you've made local changes, run 'databricks pipelines deploy' first to ensure they are included.\n\nUpdate URL: [DATABRICKS_URL]/#joblist/pipelines/[UUID][0]/updates/[UUID][1]\n\nError: Fault injected by test.\n\nExit code: 1\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -17,9 +17,5 @@
        	            	 
        	            	-Warn: retrying after 500 Internal Server Error from GET /api/2.0/pipelines/[UUID][0]/events
        	            	-Update ID: [UUID][1]
        	            	+Error: Fault injected by test.
        	            	 
        	            	-Update for pipeline completed successfully.
        	            	+Exit code: 1
        	            	 
        	            	-Pipeline configurations for this update:
        	            	-• All tables are refreshed
        	            	-
        	Test:       	TestAccept/pipelines/run/events-500
        	Messages:   	pipelines/run/events-500/output.txt vs /tmp/TestAcceptpipelinesrunevents-5003899944052/002/output.txt

latest (v1.27.0): same output as main (70d24e3)

Don't branch on the text of wrapping errors: only a bare API error with an
empty message is described. Also retry the update status read in the poll
loop and the events read after the update completes.

aws: TestAccept/pipelines/run/refresh-flags TestAccept/bundle/deployment/bind/alert

Co-authored-by: Isaac <no-reply@databricks.com>
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 265587f

Run: 44536869208

Env 🤯​MISS 🔄​flaky 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 273 21 12:21
💚​ aws-windows-latest-4core-16gb 1 275 19 9:04
🤯​ azure linux-2core-8gb 1 1 271 21 12:01
🤯​ azure-windows-latest-4core-16gb 1 1 273 19 9:59
🤯​ gcp linux-2core-8gb 1 2 1 270 21 9:12
🤯​ gcp-windows-latest-4core-16gb 1 1 274 19 7:14
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🤯​ TestAccept/pipelines/run/refresh-flags ✅​p ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🔄​ TestFsCpFileToDirWithOverwriteFlag ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p
🔄​ TestFsCpFileToDirWithOverwriteFlag/uc-volumes_to_dbfs ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p
Top 13 slowest tests (at least 2 minutes):
duration env testname
5:15 aws-windows-latest-4core-16gb TestAccept/pipelines/run/refresh-flags
4:03 aws linux-2core-8gb TestAccept/pipelines/run/refresh-flags
3:58 gcp-windows-latest-4core-16gb TestAccept
3:44 aws-windows-latest-4core-16gb TestAccept
3:41 azure-windows-latest-4core-16gb TestAccept
3:21 gcp linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
3:15 azure-windows-latest-4core-16gb TestSyncFullFileSync
2:44 azure-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files_extensions
2:33 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsRead
2:05 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
2:03 azure linux-2core-8gb TestSyncFullFileSync
2:02 aws-windows-latest-4core-16gb TestImportDirWithOverwriteFlag
2:01 aws linux-2core-8gb TestFilerRecursiveDelete/workspace_files

denik and others added 2 commits November 19, 2026 11:54
aws: TestAccept/pipelines/run/refresh-flags TestAccept/bundle/deployment/bind/alert

Co-authored-by: Isaac <no-reply@databricks.com>
Generated commands return the API error wrapped without extra text, so a bare
type check missed it.

aws: TestAccept/pipelines/run/refresh-flags TestAccept/bundle/deployment/bind/alert

Co-authored-by: Isaac <no-reply@databricks.com>
@denik
denik marked this pull request as ready for review November 19, 2026 12:26
@denik
denik requested review from a team as code owners November 19, 2026 12:26
@denik
denik requested review from Sankalp-Mittal, andrewnester and maksim-zuev-db and removed request for maksim-zuev-db November 19, 2026 12:26
Comment thread bundle/run/pipeline.go Resolved

@Sankalp-Mittal Sankalp-Mittal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[AI Generated] Review by review-factory (Claude Opus 5.5 + Claude Fable 5.2, cross-verified). Only points the reviewers agreed on are posted.

Comment thread cmd/pipelines/run.go Resolved
Comment thread cmd/root/api_error.go Resolved
…reads

- Share the status and endpoint formatting between libs/retry and cmd/root via libs/diag.
- Retry the error-events read and the post-run GetUpdate too.
- Assert the retry warning in pipelines/run/events-500.
- Mention update status reads in the changelog entry.

aws: TestAccept/pipelines/run/refresh-flags

Co-authored-by: Isaac <no-reply@databricks.com>
@denik
denik added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit ac6b85d Nov 19, 2026
30 checks passed
@denik
denik deleted the generr-empty-message branch November 19, 2026 14:25
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

❌ Integration test report

Commit: ac6b85d

Run: 44543822932

Env 💥​PANIC ❌​FAIL 🟨​KNOWN 🤯​MISS 💚​RECOVERED ✅​pass 🙈​skip Time
💥​ aws linux-2core-8gb 1 2 657 20 950 1407 320:00
💥​ aws-windows-latest-4core-16gb 1 794 21 730 1435 320:00
🟨​ azure linux-2core-8gb 6 635 14 955 1415 320:00
💥​ azure-windows-latest-4core-16gb 1 619 3 903 1443 320:00
💥​ gcp linux-2core-8gb 1 2 614 20 980 1413 320:00
💥​ gcp-windows-latest-4core-16gb 1 695 9 828 1441 320:00
1354 interesting tests: 1339 MISS, 6 KNOWN, 5 PANIC, 4 FAIL
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
🤯​ TestAccept 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/apps/compute_size 🤯​M ✅​p ✅​p ✅​p ✅​p ✅​p
🤯​ TestAccept/bundle/apps/compute_size/DMS= 🤯​M ✅​p ✅​p ✅​p ✅​p ✅​p
🤯​ TestAccept/bundle/apps/compute_size/DMS=true 🤯​M ✅​p ✅​p ✅​p ✅​p ✅​p
🤯​ TestAccept/bundle/apps/job_permissions 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/apps/job_permissions/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/apps/job_permissions/DMS=true 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_doesnot_exist 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_doesnot_exist/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_doesnot_exist/DMS=true 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_not_deployed 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_not_deployed/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_not_deployed/DMS=true 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/cli_defaults 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/cli_defaults/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/cli_defaults/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_cross_target 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_cross_target/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_cross_target/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_permissions 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_permissions/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_permissions/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_remote_addition 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_remote_addition/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_remote_addition/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/config_edits 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/config_edits/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/config_edits/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/dashboard_etag 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/dashboard_etag/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/dashboard_etag/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/external_cluster_policy_cross_target 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/external_cluster_policy_cross_target/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/external_cluster_policy_cross_target/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/flushed_cache 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/flushed_cache/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/flushed_cache/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/formatting_preserved 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/formatting_preserved/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/formatting_preserved/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/job_fields 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/job_fields/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/job_fields/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/job_multiple_tasks 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/job_multiple_tasks/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/job_multiple_tasks/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/job_params_variables 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/job_params_variables/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/job_params_variables/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/job_pipeline_task 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/job_pipeline_task/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/job_pipeline_task/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/json_status_missing_state 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/json_status_missing_state/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/json_status_missing_state/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/json_status_selectors 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/json_status_selectors/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/json_status_selectors/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/multiple_files 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/multiple_files/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/multiple_files/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/multiple_resources 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/multiple_resources/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/multiple_resources/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/output_json 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/output_json/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/output_json/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/output_no_changes 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/output_no_changes/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/output_no_changes/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/pipeline_fields 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/pipeline_fields/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/pipeline_fields/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/policy_injected_cluster_fields 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/policy_injected_cluster_fields/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/policy_injected_cluster_fields/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/resolve_variables 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/resolve_variables/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/resolve_variables/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/select_basic 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/select_basic/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/select_basic/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/select_multiple 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/select_multiple/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/select_multiple/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/skip_deployment 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/skip_deployment/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/skip_deployment/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/skip_permissions 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/skip_permissions/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/skip_permissions/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/target_override 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/target_override/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/target_override/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/task_rename_revert 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/task_rename_revert/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/task_rename_revert/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/debug/fetch-repository-info 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/debug/fetch-repository-info/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/debug/fetch-repository-info/DMS=true 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/empty-bundle 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/empty-bundle/DATABRICKS_BUNDLE_ENABLE_EXPERIMENTAL_YAML_SYNC=/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/empty-bundle/DATABRICKS_BUNDLE_ENABLE_EXPERIMENTAL_YAML_SYNC=/DMS=true 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/empty-bundle/DATABRICKS_BUNDLE_ENABLE_EXPERIMENTAL_YAML_SYNC=true/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/empty-bundle/DATABRICKS_BUNDLE_ENABLE_EXPERIMENTAL_YAML_SYNC=true/DMS=true 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/files/no-snapshot-sync 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/files/no-snapshot-sync/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/files/no-snapshot-sync/DMS=true 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/basic 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/basic/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/breakglass 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/breakglass/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/can-manage 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/can-manage/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/destroy-redeploy 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/destroy-redeploy/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/dev-mode 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/dev-mode/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/legacy-state 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/legacy-state/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/missing-snapshot 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/missing-snapshot/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/no-artifacts 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/no-artifacts/DMS=/READPLAN= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/no-artifacts/DMS=/READPLAN=1 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/permissions-change 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/permissions-change/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/select 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/select/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/mlops-stacks 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/mlops-stacks/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/mlops-stacks/DMS=true 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/spark-jar-task 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/spark-jar-task/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/spark-jar-task/DMS=true 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deployment/bind/alert 🤯​M 💚​R 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deployment/bind/alert/DMS= 🤯​M 💚​R 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deployment/bind/alert/DMS=true 🤯​M 💚​R 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deployment/bind/catalog 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deployment/bind/catalog/DMS= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deployment/bind/catalog/DMS=true 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deployment/bind/cluster 🤯​M ✅​p 🤯​M 🤯​M ✅​p 🤯​M
🤯​ TestAccept/bundle/deployment/bind/cluster/DMS= 🤯​M ✅​p 🤯​M 🤯​M ✅​p 🤯​M
🤯​ TestAccept/bundle/deployment/bind/cluster/DMS=true 🤯​M ✅​p 🤯​M 🤯​M ✅​p 🤯​M
🤯​ TestAccept/bundle/deployment/bind/dashboard 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deployment/bind/dashboard/DMS=/READPLAN= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deployment/bind/dashboard/DMS=/READPLAN=1 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deployment/bind/dashboard/DMS=true/READPLAN= 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deployment/bind/dashboard/DMS=true/READPLAN=1 🤯​M ✅​p 🤯​M 🤯​M 🤯​M 🤯​M
Top 50 slowest tests (at least 2 minutes):
duration env testname
16:40 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
15:22 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
15:22 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
15:10 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
13:36 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=schema_uppercase_name.yml.tmpl/READPLAN=
13:23 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
13:22 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
12:59 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
12:31 azure-windows-latest-4core-16gb TestAccept/bundle/resources/schemas/rename_then_change/DMS=true
12:18 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=
11:57 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
11:42 gcp linux-2core-8gb TestAccept/bundle/resources/schemas/rename_then_change/DMS=
11:35 azure linux-2core-8gb TestAccept/bundle/resources/schemas/rename_then_change/DMS=true
11:13 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
10:53 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/materialization_sets/immutable/DMS=
10:40 aws linux-2core-8gb TestAccept/bundle/resources/materialization_sets/immutable/DMS=
10:26 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
9:37 gcp linux-2core-8gb TestAccept/bundle/resources/schemas/rename_then_change/DMS=true
9:23 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=vector_search_endpoint.yml.tmpl/READPLAN=1
9:20 aws linux-2core-8gb TestAccept/bundle/resources/schemas/rename_then_change/DMS=true
9:17 gcp linux-2core-8gb TestAccept/bundle/resources/materialization_sets/batch/DMS=true
9:15 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=sql_warehouse.yml.tmpl/READPLAN=1
9:13 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started-toggle/DMS=
8:59 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=
8:56 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=1
8:55 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=schema_tf_compat.yml.tmpl/READPLAN=
8:49 aws linux-2core-8gb TestAccept/bundle/resources/materialization_sets/immutable/DMS=true
8:49 aws linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
8:48 gcp linux-2core-8gb TestAccept/bundle/resources/registered_models/basic/DMS=true
8:47 azure linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
8:45 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/resize-terminated-fallback/DMS=true
8:44 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
8:39 azure-windows-latest-4core-16gb TestAccept/bundle/templates/default-python/integration_classic/DMS=/UV_PYTHON=3.10
8:39 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
8:37 azure linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=
8:37 azure-windows-latest-4core-16gb TestAccept/bundle/templates/default-python/combinations/serverless/DLT=yes/DMS=/NBOOK=no/PY=yes/READPLAN=1
8:34 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=schema_grant_ref.yml.tmpl/READPLAN=1
8:29 azure-windows-latest-4core-16gb TestAccept/bundle/templates/default-python/combinations/classic/DLT=yes/DMS=/NBOOK=no/PY=no/READPLAN=1
8:27 gcp linux-2core-8gb TestAccept/bundle/resources/materialization_sets/immutable/DMS=true
8:25 azure linux-2core-8gb TestAccept/bundle/resources/clusters/deploy/data_security_mode/DMS=true
8:23 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=volume_path_job_ref.yml.tmpl/READPLAN=1
8:18 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=true
8:18 azure linux-2core-8gb TestAccept/bundle/resources/clusters/resize-terminated-fallback/DMS=
8:17 aws linux-2core-8gb TestAccept/bundle/templates/default-python/integration_classic/DMS=/UV_PYTHON=3.12
8:15 gcp linux-2core-8gb TestAccept/bundle/templates/default-python/combinations/serverless/DLT=no/DMS=/NBOOK=no/PY=no/READPLAN=
8:14 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=schema.yml.tmpl/READPLAN=1
8:13 azure linux-2core-8gb TestAccept/bundle/resources/clusters/deploy/data_security_mode/DMS=
8:11 gcp-windows-latest-4core-16gb TestAccept/bundle/quiet-levels/DMS=true
8:08 aws-windows-latest-4core-16gb TestAccept/bundle/deploy/spark-jar-task/DMS=true
8:05 azure-windows-latest-4core-16gb TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=1
(1205 table rows omitted to keep the report under 60000 bytes)

@denik denik added factory-generated and removed ai-auto Deprecated: use factory-generated instead. labels Nov 20, 2026
idelafuente-oc pushed a commit to idelafuente-oc/cli that referenced this pull request Nov 20, 2026
… is sent (databricks#7820)

## Changes

In `waitForTestUpdate` (`databricks pipelines test`), a read that fails
with `context.Canceled` now also carries the wait context's cause
(`errTestWaitTimeout`). The read's own error stays wrapped. Other read
errors are returned unchanged, even if the context was canceled by then.
The command's caller still checks `context.Cause` as a fallback.

## Why

`TestWaitForTestUpdateTimeout` failed once on main on Windows:

```
Target error should be in err chain:
expected: "test wait timed out"
in chain: "failed to fetch pipeline events: failed in rate limiter: context canceled"
```

The 20ms timeout can pass between two reads. Windows timers are coarse,
so this happens there. A request that is already in flight gets the
cancel cause from `net/http`. But the SDK rate limiter checks the
context before sending, and it fails with a bare `context canceled`,
which hides the timeout. The command itself reported this case
correctly, because it checked `context.Cause` separately. The function
didn't, so the test was flaky.

This is not a regression from
[databricks#7800](databricks#7800): that PR changed
`pipelines run` and `bundle run` (`cmd/pipelines/run.go`,
`bundle/run/`). It did not change `pipelines test`'s wait loop
(`cmd/pipelines/test.go`, `test_events.go`). The flaky test came with
[databricks#7426](databricks#7426).

## Tests

New `TestWaitReadError` covers: a real error is kept, and a context
error gets the cause and keeps its message. New
`TestWaitForTestUpdateTimeoutBeforeRead`: the wait context is already
canceled with the timeout cause, so the first read fails in the rate
limiter. Without the fix it fails with the same message as on CI; with
the fix it passes. The other `TestWaitForTestUpdate*` tests and the
`pipelines` acceptance tests pass.

Decision: this does not change one existing behavior. If the timeout
fires during the final events read after the update has already ended,
the run is still reported as timed out. That is unchanged from main and
rare, since it needs the timeout to hit that exact read.

## Dashboard

| error | verbatim snippet |
|---|---|
|
[error/3790](http://go/cli/dashboard/error/3790?main=1&pr=1&end=2026-11-19T16:00:00Z&last=2d)
| `Target error should be in err chain: expected "test wait timed out",
in chain: "failed to fetch pipeline events: failed in rate limiter:
context canceled"` |

Test:
[cmd/pipelines.TestWaitForTestUpdateTimeout](http://go/cli/dashboard/test/cmd/pipelines.TestWaitForTestUpdateTimeout?main=1&pr=1&end=2026-11-19T16:00:00Z&last=2d)

This pull request and its description were written by Isaac.

---------

Co-authored-by: Isaac <no-reply@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues factory-generated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants