Repository navigation
integration: isolate uv Python installs in setup-local provision test - #7803
Merged
Merged
Conversation
`uv python install` re-creates the minor-version links of every managed Python in its install dir. On Windows that is a non-atomic junction delete and recreate, so the acceptance harness's concurrent `uv build` of the databricks-bundles wheel intermittently fails to import stdlib modules. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: ab6259a
Top 5 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 19, 2026 12:25
denik
requested review from
Sankalp-Mittal,
abdelrahmanomar1515 and
andrewnester
and removed request for
abdelrahmanomar1515
November 19, 2026 12:25
andrewnester
approved these changes
Nov 19, 2026
Collaborator
❌ Integration test reportCommit: ccaea75
1323 interesting tests: 1314 MISS, 6 PANIC, 3 FAIL
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TestSetupLocalServerlessProvisionnow runsenvironments setup-localwith its own uv Python install dir (UV_PYTHON_INSTALL_DIR,UV_PYTHON_BIN_DIR) and with Windows registry entries turned off (UV_PYTHON_INSTALL_REGISTRY=0).Why
On Windows,
acceptance.TestAcceptsometimes fails before any test runs: the harness'suv buildof the databricks-bundles wheel fails becauseflit_corecan't import some stdlib module. The module changes from run to run (types,email,encodings,tarfile,re._casefix).The cause is
integration/cmd/environments, which runs in parallel with./acceptancein the same job:setup-localrunsuv python install 3.12. Even when 3.12 is already installed, uv re-creates the minor-version link (cpython-3.X-<platform>) of every managed Python in the install dir. I confirmed this with strace on Linux: the 3.10, 3.12 and 3.13 links all get replaced.replace_with_junctionin uv-fs), so for a short time the link is missing.uv buildinpython/picks the newest managed interpreter through thecpython-3.13link, so its isolated build env loses its stdlib during that gap.In all 6 failures (aws, azure and gcp, all Windows),
TestSetupLocalServerlessProvisionstarted 1-2s before the failinguv buildfinished. The second attempt always passes.With this change, the test installs Python into a temp dir and leaves the shared installs alone. The test still covers the same thing (real
uv python install+uv sync). The cost is one Python download per run.Tests
TestSetupLocal*passes on aws. The sharedcpython-3.*links' mtimes are unchanged after the run.Dashboard
error/1234
This pull request and its description were written by Isaac.