Repository navigation
acc: match skill/bad instead of bad in cmd/skills-invoked - #7807
Merged
Merged
Conversation
The user agent carries a random hex cmd-exec-id UUID, which contains "bad" in roughly 1% of runs and failed the negative check. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=0 unreleased=0 coverage=1 failing=0
|
Collaborator
✅ Integration test reportCommit: 95489bc
Top 33 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Nov 19, 2026
Collaborator
❌ Integration test reportCommit: 3ad2af9
1325 interesting tests: 1298 MISS, 10 RECOVERED, 7 KNOWN, 6 PANIC, 4 FAIL
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
In
acceptance/cmd/skills-invoked, the "Invalid entries are dropped" case asserted!badagainst the whole request dump. The user agent includescmd-exec-id/<random UUID>, and hex digits spellbadin about 1% of runs (~32 positions × 1/4096), which fails the test. The check now asserts!skill/bad, which still catches the invalidbad name!entry leaking into the user agent.Error 3640 (Git Bash path conversion on Windows) was PR #7730's own failure and is already fixed by
MSYS_NO_PATHCONV=1in the script, so this PR doesn't touch it.Dashboard
contains error: 'bad' was not expected: '"cli/[CLI_VERSION] databricks-sdk-go/[SDK_VERSION] go/[GO_VERSION] os/darwin cmd/current-user_me cmd-exec-id/[UUID] interactive/none skill/databricks-core auth/pat cicd/github"'Test: TestAccept/cmd/skills-invoked
Tests
go test ./acceptance -run TestAccept/cmd/skills-invokedpasses locally.This pull request and its description were written by Isaac.