Repository navigation
Fix flaky keyring store tests on loaded CI runners - #7808
Merged
Merged
Conversation
The fake keyring backend answers at once, but newTestStore gave it a 100ms timeout. On Windows CI the withTimeout goroutine sometimes took longer than that to run, so Put failed with "keyring set timed out". Use a one-minute timeout for these tests. Keep 100ms only for the tests whose backend blocks forever. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: b51076e
Top 26 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 19, 2026 14:51
denik
requested review from
Sankalp-Mittal,
andrewnester and
maksim-zuev-db
and removed request for
maksim-zuev-db
November 19, 2026 14:51
denik
enabled auto-merge
November 19, 2026 14:51
andrewnester
approved these changes
Nov 19, 2026
Collaborator
❌ Integration test reportCommit: a46b381
1309 interesting tests: 1270 MISS, 16 FAIL, 9 KNOWN, 9 RECOVERED, 5 PANIC
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
In
libs/auth/storage/keyring_test.go, the tests that use the fake keyring backend without blocking now get a one-minute timeout instead of 100ms. The three*_TimesOuttests and the timeout cases ofTestProbeKeyringandTestProbeKeyringReadkeep a short timeout, 100ms. Their backend blocks forever, so they still finish quickly.Why
fakeBackendanswers at once, butkeyringStore.withTimeoutruns each call in a goroutine and races it againsttime.After(timeout). On a busy Windows runner that goroutine sometimes took more than 100ms to run, soPutreturnedkeyring set timed out. All 4 failures in the last 3 days were ontask test (windows, ...), in 4 unrelated PRs, and each took 0.10-0.13s, which is the timeout firing. They all passed on retry. No production code changes; the CLI's real timeout is still 3s.Dashboard:
Tests
go test -race -count=3 ./libs/auth/storage/passes.This pull request and its description were written by Isaac.