Repository navigation
acc: show what starting a bundle-created app does to its deployments - #7809
Draft
janniklasrose wants to merge 1 commit into
Draft
janniklasrose wants to merge 1 commit into
janniklasrose wants to merge 1 commit into
Conversation
Four cloud tests for apps created with source_code_path (#6399): a plain apps start, bundle run, and lifecycle.started on create and on update. The goldens hold what the bundle asks for, so a cloud diff shows a deployment the bundle did not make or a command that fails because of one. cloud: TestAccept/bundle/resources/apps/start-triggered-deployment Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 4 changed tests (limit=20, 0 not selected) 4 tests: regression=0 unreleased=0 coverage=4 failing=0
|
Collaborator
❌ Integration test reportCommit: 173b8be
Top 37 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds four cloud acceptance tests under
acceptance/bundle/resources/apps/start-triggered-deployment. Each creates an app withsource_code_pathand an inlineconfig, starts its compute, and prints the deployments on the app:apps-start:bundle deploy, then a plainapps start. The source folder has anapp.yamlthat runs, with a different env var than the inline config.bundle-run:bundle deploy, thenbundle run. Noapp.yamlin the source folder.lifecycle-started-on-create:lifecycle.started: truefrom the first deploy. Noapp.yaml.lifecycle-started-on-update: created withstarted: false, then set totrue. Noapp.yaml.Why
Since #6399 the Create request records
source_code_pathon the app, and the nightlyinline_configtest fails withapp exited unexpectedlywhilebundle runwaits on a deployment it did not make (see #7780). These tests are meant to show on a real workspace which commands are affected and what the app ends up with.This is a diagnostic draft, not meant to merge as is. The goldens are generated against the local test server, which does not deploy on start, so they hold what the bundle asks for: the only deployment is the one the CLI makes, with the inline config. I expect the cloud run to fail, and the diffs are the result.
Tests
The four tests pass locally. The last commit message asks the cloud run to run them on every cloud.
This pull request and its description were written by Isaac.