Repository navigation
acc: make dms recreate tests independent of DMS write coalescing - #7810
Merged
Merged
Conversation
The operation buffer merges a write still waiting to be sent into the next one for the same resource, so a recreate's PENDING drop write is either sent on its own (two PATCHes, sequence_id 0 and 1) or merged into the save/failure (one PATCH at sequence_id 0), depending on timing. Fold the PENDING write and drop operation sequence_ids in these two tests so both outcomes print the same. aws: TestAccept/bundle/dms/successful-recreate Co-authored-by: Isaac <no-reply@databricks.com>
aws: TestAccept/bundle/dms/successful-recreate Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 2 tests: regression=0 unreleased=0 coverage=2 failing=0
|
Collaborator
✅ Integration test reportCommit: 2444e08
Top 36 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Nov 19, 2026
Collaborator
❌ Integration test reportCommit: 828e0b1
1340 interesting tests: 1323 MISS, 9 KNOWN, 6 PANIC, 2 FAIL
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
bundle/dms/failed-recreateandbundle/dms/successful-recreaterecord the deployment-history PATCHes of a recreate. A recreate writes the operation twice: the drop marks itOPERATION_STATUS_PENDING, then the save (or failure) finishes it.libs/dms/operation_buffer.gouploads writes on a background goroutine and, by design, merges a write still waiting inpendinginto the next one for the same resource. So, depending on timing, the service gets either:sequence_id0, then the final write atsequence_id1 (what the goldens recorded), orsequence_id0 (seen on slow runners, Windows and Linux).The final state the service ends up with is the same either way, so the CLI is fine; the test was timing-dependent.
This adds
print_requests.py --fold-pending, which drops a PENDING operation PATCH when a later PATCH to the same operation follows and dropssequence_idfrom operation PATCHes, and uses it in the two tests' recreate step. The final write (state cleared on failure, new state on success) is still recorded in full.Judgment call: I fixed this in the test, not the CLI. Turning off coalescing for PENDING writes would make the recording deterministic, but it adds a request per recreate in production only to make a test stable.
Not a regression from a recent PR: coalescing has been in the buffer since it was added; the flake depends on runner speed.
Tests
go test ./acceptance -run 'TestAccept/bundle/dms/(failed|successful)-recreate' -count=15passes locally.successful-recreatepasses on AWS (testme-aws), and the last commit names it for the PR's AWS run.print_requests.pycover both the merged and the unmerged sequence.Dashboard
error/1394, bundle/dms/successful-recreate/DMS=true, bundle/dms/failed-recreate/DMS=true
This pull request and its description were written by Isaac.