Repository navigation
Conversation
Contributor
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 4 tests: regression=4 unreleased=0 coverage=0 failing=0
TestAccept/bundle/validate/variables/numeric_defaults/DMS=: branch ✅ | main (828e0b1) ❌ | latest (v1.27.0) ❌main (828e0b1): latest (v1.27.0): same output as main (828e0b1) TestAccept/bundle/validate/variables/numeric_defaults/DMS=true: branch ✅ | main (828e0b1) ❌ | latest (v1.27.0) ❌main (828e0b1): latest (v1.27.0): TestAccept/bundle/validate/yaml_numeric_strings/DMS=: branch ✅ | main (828e0b1) ❌ | latest (v1.27.0) ❌main (828e0b1): latest (v1.27.0): TestAccept/bundle/validate/yaml_numeric_strings/DMS=true: branch ✅ | main (828e0b1) ❌ | latest (v1.27.0) ❌main (828e0b1): latest (v1.27.0): same output as main (828e0b1) |
Collaborator
✅ Integration test reportCommit: 2157c5b
Top 46 slowest tests (at least 2 minutes):
|
The YAML loader records the original text of scalars it resolves to
int, float or bool. String fields and ${var.x} interpolation use it
instead of formatting the parsed value, so policy_id: 0012345678901234
stays as written instead of becoming 12345678901234.
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Bools keep normalizing to true/false so notebook code comparing widget values with "true" is unaffected. Add tests for toTypedString, value copies, negatives and aliases; note the deploy-time change in the changelog. Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/yaml-keep-source-text
branch
from
November 19, 2026 15:40
b6408f6 to
2157c5b
Compare
denik
marked this pull request as ready for review
November 19, 2026 15:40
andrewnester
approved these changes
Nov 19, 2026
Sankalp-Mittal
left a comment
Contributor
There was a problem hiding this comment.
[AI Generated] Review by review-factory (Claude Opus 5.5 + Claude Fable 5.2, cross-verified). Only points the reviewers agreed on are posted.
| # string-typed fields. Each value is written twice: unquoted and quoted ("q_"). | ||
| # The quoted value is kept verbatim; the unquoted one is converted from the | ||
| # resolved number and may not match the source text. | ||
| # Both must keep the source text verbatim. |
Contributor
There was a problem hiding this comment.
[AI Generated] nit: bool_title: True on line 36 still comes out as "true" (output.txt:7), so "Both must keep the source text verbatim" does not hold for bools. Can the comment say only numbers (and timestamps) are kept verbatim?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The YAML loader now records the source text of unquoted scalars it resolves to an int or float. String fields and
${var.x}interpolation use that text instead of formatting the parsed number. Int and float fields still get the parsed value; bools are unchanged (Truestill becomes"true").Why
policy_id: 0012345678901234became12345678901234,version: 3.10became3.1, andid-${var.x}with such a default becameid-1.2345678901234e+13. See #7793 and the cases recorded in #7811.This changes deployed values for configs that relied on the old conversion, e.g.
1.0or1_000in a string field is now sent as written. Not covered:.variables.*.valueinbundle validate -o jsonand values passed to PyDABs stay numbers, andvariable-overrides.json(JSON) has no source text.Tests
Goldens from #7811 now show the source text kept; unit tests in
dyn,yamlloader,convertanddynvar.This pull request and its description were written by Isaac.