Skip to content

Share bundle metadata for deployment history - #7816

Open
shreyas-goenka wants to merge 1 commit into
mainfrom
shreyas-goenka_data/shreyas-goenka/out-of-band-dms-metadata
Open

shreyas-goenka wants to merge 1 commit into
mainfrom
shreyas-goenka_data/shreyas-goenka/out-of-band-dms-metadata

Conversation

@shreyas-goenka

@shreyas-goenka shreyas-goenka commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Share the bundle name, target, mode, and workspace identity through bundleMetadata. Deployment-specific file paths stay in deploymentMetadata.

Why

Bind needs the same identity as deploy, but has no uploaded files or immutable snapshot path to publish. This prerequisite only extracts that common metadata.

Tests

  • Focused metadata and existing version-parser tests pass.
  • Bind/unbind, immutable-bind, and DMS fault acceptance cases pass on the stack.

This PR was written by Codex.

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 5ea65ac

Run: 44589238062

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 272 19 15:20
💚​ aws-windows-latest-4core-16gb 1 274 17 9:13
💚​ azure linux-2core-8gb 1 271 19 15:17
💚​ azure-windows-latest-4core-16gb 1 273 17 10:48
💚​ gcp linux-2core-8gb 1 272 19 12:56
💚​ gcp-windows-latest-4core-16gb 1 274 17 10:14
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 29 slowest tests (at least 2 minutes):
duration env testname
4:24 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsStat
4:18 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsDelete
3:59 aws-windows-latest-4core-16gb TestAccept
3:56 gcp-windows-latest-4core-16gb TestAccept
3:50 gcp-windows-latest-4core-16gb TestFilerReadDir/workspace_files_extensions
3:45 gcp linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
3:35 azure-windows-latest-4core-16gb TestAccept
3:32 azure linux-2core-8gb TestFilerRecursiveDelete/workspace_files_extensions
3:31 aws linux-2core-8gb TestFilerReadWrite/workspace_files_extensions
3:30 gcp-windows-latest-4core-16gb TestImportDir
3:17 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
3:15 azure linux-2core-8gb TestFilerRecursiveDelete/workspace_files
2:58 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsStat
2:55 azure-windows-latest-4core-16gb TestFilerReadWrite/workspace_files_extensions
2:47 aws linux-2core-8gb TestImportDirWithOverwriteFlag
2:42 azure linux-2core-8gb TestImportDirDoesNotOverwrite
2:39 aws-windows-latest-4core-16gb TestFilerWorkspaceNotebook/rJupyterNb.ipynb
2:39 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
2:34 azure linux-2core-8gb TestImportDir
2:31 gcp linux-2core-8gb TestSyncFullFileSync
2:23 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
2:23 aws linux-2core-8gb TestFilerWorkspaceNotebook/rNb.r
2:18 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsRead
2:17 aws linux-2core-8gb TestFilerReadWrite/workspace_files
2:16 aws-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
2:12 aws-windows-latest-4core-16gb TestSyncNestedFolderDoesntFailOnNonEmptyDirectory
2:02 gcp linux-2core-8gb TestAccept
2:01 azure-windows-latest-4core-16gb TestFilerReadDir/workspace_files
2:00 aws linux-2core-8gb TestFilerWorkspaceNotebook/scalaJupyterNb.ipynb

@shreyas-goenka
shreyas-goenka force-pushed the shreyas-goenka_data/shreyas-goenka/out-of-band-dms-metadata branch from fa22f79 to 5ea65ac Compare November 19, 2026 18:32
@shreyas-goenka shreyas-goenka changed the title Share metadata and version requests for out-of-band history Share bundle metadata for deployment history Nov 19, 2026
@shreyas-goenka
shreyas-goenka marked this pull request as ready for review November 20, 2026 08:31
@shreyas-goenka
shreyas-goenka requested review from a team as code owners November 20, 2026 08:31

@review-oss-bot review-oss-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review at 5ea65ac. Each finding was verified against the code.

No blocking issues found.

This PR extracts bundleMetadata from deploymentMetadata to separate bundle-identity fields (name, target, mode, workspace root) from deployment-specific file paths. The refactoring is behavior-preserving: the pointer aliasing through ws := p.Workspace correctly propagates mutations, and the reordered git-folder logic touches independent fields. No correctness issues were found.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants