Repository navigation
Share bundle metadata for deployment history - #7816
Open
shreyas-goenka wants to merge 1 commit into
Open
shreyas-goenka wants to merge 1 commit into
shreyas-goenka wants to merge 1 commit into
Conversation
This was referenced Nov 19, 2026
Collaborator
✅ Integration test reportCommit: 5ea65ac
Top 29 slowest tests (at least 2 minutes):
|
shreyas-goenka
force-pushed
the
shreyas-goenka_data/shreyas-goenka/out-of-band-dms-metadata
branch
from
November 19, 2026 18:32
fa22f79 to
5ea65ac
Compare
shreyas-goenka
marked this pull request as ready for review
November 20, 2026 08:31
There was a problem hiding this comment.
Automated review at 5ea65ac. Each finding was verified against the code.
No blocking issues found.
This PR extracts bundleMetadata from deploymentMetadata to separate bundle-identity fields (name, target, mode, workspace root) from deployment-specific file paths. The refactoring is behavior-preserving: the pointer aliasing through ws := p.Workspace correctly propagates mutations, and the reordered git-folder logic touches independent fields. No correctness issues were found.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Share the bundle name, target, mode, and workspace identity through
bundleMetadata. Deployment-specific file paths stay indeploymentMetadata.Why
Bind needs the same identity as deploy, but has no uploaded files or immutable snapshot path to publish. This prerequisite only extracts that common metadata.
Tests
This PR was written by Codex.