Repository navigation
bundle: report deployment history drain wait time - #7821
Draft
shreyas-goenka wants to merge 1 commit into
Draft
shreyas-goenka wants to merge 1 commit into
shreyas-goenka wants to merge 1 commit into
Conversation
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=1 unreleased=0 coverage=0 failing=0
TestAccept/bundle/dms/multiple-resources/DMS=true: branch ✅ | main (de394ed) ❌ | latest (v1.27.0) ❌main (de394ed): latest (v1.27.0): |
Collaborator
✅ Integration test reportCommit: 5d8d246
Top 38 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Record the foreground wait spent draining deployment-history updates as
dms.operation_buffer_drainin the existing deploy timing telemetry. Preserve zero waits and include timeout waits; uploads that overlap resource deployment are excluded.Why
Queue counts cannot tell us how many seconds history recording adds to a deployment. The temporary performance dashboard needs this measurement to show drain latency separately from the whole deploy phase.
Tests
go test ./libs/dms ./bundle/phasesgo test ./acceptance -run '^TestAccept/bundle/dms/multiple-resources'(timer emitted with a buffer; omitted without one)This PR was written with Codex.