Skip to content

air: Note in config help that some parameter floats load as strings - #7827

Open
caroline-db wants to merge 2 commits into
mainfrom
air-parameters-float-help
Open

caroline-db wants to merge 2 commits into
mainfrom
air-parameters-float-help

Conversation

@caroline-db

Copy link
Copy Markdown
Contributor

Changes

air run -h config.parameters now adds one sentence to the field help: "Floats such as 2e-5 and 1e6 can load as strings in Python." The rest of the help text, and the field summary in air run -h config, are unchanged.

Why

air run re-encodes parameters before uploading them, and go-yaml writes floats below 1e-4 or at least 1e6 in exponent form, usually without a decimal point (1e-05, 1e+06). PyYAML's yaml.safe_load, the usual way scripts read this file, follows YAML 1.1 and returns that form as a string, so training scripts that don't convert the value crash at optimizer setup. This PR documents that behavior without changing how the file is written.

Tests

  • Checked air run -h config.parameters output with a local build. The acceptance snapshot (acceptance/air/config-help) covers only the field summary, which is unchanged, and go test ./acceptance -run TestAccept/air/config-help still passes.

This pull request and its description were written by Isaac.

air run re-encodes parameters, writing floats such as 2e-5 and 1e6 in exponent
form without a decimal point, which PyYAML's yaml.safe_load reads as strings.

Co-authored-by: Isaac <no-reply@databricks.com>
@caroline-db
caroline-db requested review from a team as code owners November 19, 2026 20:22
@github-actions github-actions Bot added the AIR Databricks AI Runtime CLI label Nov 19, 2026
Co-authored-by: Isaac <no-reply@databricks.com>
@caroline-db
caroline-db force-pushed the air-parameters-float-help branch from ad0db94 to 5ca5521 Compare November 19, 2026 20:35
@caroline-db caroline-db changed the title [CNXT-2700] air: Note in config help that some parameter floats load as strings air: Note in config help that some parameter floats load as strings Nov 19, 2026
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 5ca5521

Run: 44610415790

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 272 19 8:56
💚​ aws-windows-latest-4core-16gb 1 274 17 7:15
💚​ azure linux-2core-8gb 1 271 19 9:45
💚​ azure-windows-latest-4core-16gb 1 273 17 6:06
💚​ gcp linux-2core-8gb 1 272 19 11:18
💚​ gcp-windows-latest-4core-16gb 1 274 17 6:35
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 8 slowest tests (at least 2 minutes):
duration env testname
4:02 azure-windows-latest-4core-16gb TestAccept
4:01 aws-windows-latest-4core-16gb TestAccept
3:48 gcp-windows-latest-4core-16gb TestAccept
2:38 gcp linux-2core-8gb TestFilerReadWrite/workspace_files
2:22 aws-windows-latest-4core-16gb TestImportDirWithOverwriteFlag
2:17 aws-windows-latest-4core-16gb TestFilerReadWrite/workspace_files
2:02 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsRead
2:02 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsDelete

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AIR Databricks AI Runtime CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants