Repository navigation
air: Note in config help that some parameter floats load as strings - #7827
Open
caroline-db wants to merge 2 commits into
Open
caroline-db wants to merge 2 commits into
caroline-db wants to merge 2 commits into
Conversation
air run re-encodes parameters, writing floats such as 2e-5 and 1e6 in exponent form without a decimal point, which PyYAML's yaml.safe_load reads as strings. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
caroline-db
force-pushed
the
air-parameters-float-help
branch
from
November 19, 2026 20:35
ad0db94 to
5ca5521
Compare
Collaborator
✅ Integration test reportCommit: 5ca5521
Top 8 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
air run -h config.parametersnow adds one sentence to the field help: "Floats such as 2e-5 and 1e6 can load as strings in Python." The rest of the help text, and the field summary inair run -h config, are unchanged.Why
air runre-encodesparametersbefore uploading them, and go-yaml writes floats below 1e-4 or at least 1e6 in exponent form, usually without a decimal point (1e-05,1e+06). PyYAML'syaml.safe_load, the usual way scripts read this file, follows YAML 1.1 and returns that form as a string, so training scripts that don't convert the value crash at optimizer setup. This PR documents that behavior without changing how the file is written.Tests
air run -h config.parametersoutput with a local build. The acceptance snapshot (acceptance/air/config-help) covers only the field summary, which is unchanged, andgo test ./acceptance -run TestAccept/air/config-helpstill passes.This pull request and its description were written by Isaac.