Skip to content

Accept the AI Runtime GPU types in ssh connect --accelerator - #7833

Open
apeforest wants to merge 3 commits into
databricks:mainfrom
apeforest:ssh-connect-accept-any-gpu-accelerator
Open

apeforest wants to merge 3 commits into
databricks:mainfrom
apeforest:ssh-connect-accept-any-gpu-accelerator

Conversation

@apeforest

@apeforest apeforest commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Changes

databricks ssh connect --accelerator now accepts every AI Runtime GPU type the CLI knows, the list databricks air uses in cmd/air/compute.go: GPU_1xA10, GPU_1xH100, GPU_8xH100, GPU_8xB300 and GPU_1xRTX6000. The list is exported as aircmd.KnownGPUTypes() so both commands share one definition, and the flag help and the validation error list the accepted values.

Why

The ssh client had its own allowlist of two GPU types, so newer AI Runtime GPUs such as RTX6000 were rejected before the SSH server job was submitted, even though the server never looks at the accelerator and the Jobs API accepts the type. Reusing the air list means adding a GPU type in one place covers both commands.

Tests

  • Unit: the Validate tests gain a GPU_1xRTX6000 case and a well-formed but unknown GPU_2xA10 case, and the invalid-value message lists the accepted types. go test ./cmd/air/ ./experimental/ssh/... passes; parseGPUType now reads the shared list and its existing tests still pass.
  • Manual: with this change, databricks ssh connect --accelerator=GPU_1xRTX6000 --environment-version=6 started the SSH server job on a 1xRTX6000 serverless GPU in a staging workspace and the SSH handshake completed. The unpatched CLI fails the same command with invalid accelerator value.
  • CI note: validate-generated and task test-exp-ssh fail in their setup step because fork PRs get no OIDC token for the JFrog proxy, before they reach this change.

This pull request and its description were written by Isaac.

The client only allowed GPU_1xA10 and GPU_8xH100, so newer AI Runtime GPU
types such as GPU_1xRTX6000 were rejected before the job was submitted even
though the server side never looks at the accelerator. Validate the
GPU_<count>x<model> shape instead and let the workspace decide which types
it offers.

Co-authored-by: Isaac <no-reply@databricks.com>
@apeforest
apeforest requested review from a team as code owners November 20, 2026 00:20
Co-authored-by: Isaac <no-reply@databricks.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution! This pull request was opened from a fork.

If you're a member of the Databricks organization, please request access to the cli-contrib team and open your pull request from a branch in this repository instead of a fork — fork PRs don't run integration tests automatically and have reduced CI access.

If you're an external contributor, no action is needed; a maintainer will review your pull request.

Export the accelerator types `databricks air` accepts as KnownGPUTypes and
reuse them in the ssh client instead of a shape regex, so the two commands
agree on the GPU types they offer.

Co-authored-by: Isaac <no-reply@databricks.com>
@apeforest
apeforest requested a review from a team as a code owner November 20, 2026 00:32
@github-actions github-actions Bot added the AIR Databricks AI Runtime CLI label Nov 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

An authorized user can trigger integration tests manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 7833
  • Commit SHA: 65263e6555b26e71704a95a74de6a177c874c1a2

Checks will be approved automatically on success.

@apeforest apeforest changed the title Accept any serverless GPU type in ssh connect --accelerator Accept the AI Runtime GPU types in ssh connect --accelerator Nov 20, 2026
Comment thread cmd/air/compute.go
// KnownGPUTypes lists the accelerator types this CLI accepts, in the order they are shown
// to users. `ssh connect --accelerator` validates against the same list, so the two entry
// points to AI Runtime GPUs agree on the types they offer.
func KnownGPUTypes() []string {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we call AICM's ListComputeOptions to get the list of gpu types available to the user in their workspace? AIR CLI does this already.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When Jobs provisions the SSH session, AICM’s CreateSession already checks whether the workspace can use the requested GPU. Do we really need the check in CLI using one additional RPC call?

Comment thread cmd/air/compute.go
// which ones a workspace can use comes from the server, not this CLI.
func parseGPUType(value string) (gpuType, error) {
switch gpuType(value) {
case gpuType1xA10, gpuType8xH100, gpuType1xH100, gpuType8xB300, gpuType1xRTX6000:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caroline-db I thought you already removed this list from the CLI client code in favor of the server-side GPU type list. Is this one still used?

if o.Accelerator != "" && o.Accelerator != "GPU_1xA10" && o.Accelerator != "GPU_8xH100" {
return fmt.Errorf("invalid accelerator value: %q, expected %q or %q", o.Accelerator, "GPU_1xA10", "GPU_8xH100")
// The same GPU types `databricks air` accepts; the workspace still decides which it offers.
if o.Accelerator != "" && !slices.Contains(aircmd.KnownGPUTypes(), o.Accelerator) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation is more nuanced: Not all environment versions work with all GPU types. For example, B300 requires v6+. Can you change the validation here to check each environment-version × accelerator combination?

Even better: move the validation to server side (AI Training) and then we can add more GPU types any time without asking the users to upgrade CLI.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AIR Databricks AI Runtime CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants