Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -708,18 +708,26 @@ tasks:
- acceptance/experimental/aitools/**
- "{{.EMBED_SOURCES}}"
cmds:
# cmd/root runs aitools hooks on every command, cmd, cmd/apps and

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] The comment lists every added package and explicitly justifies excluding cmd/air, but ./cmd/experimental (line 721) is silently included. It belongs here because cmd/experimental/experimental.go imports experimental/aitools/cmd—worth a short clause so a future reader doesn't wonder why it's there or remove it.

# cmd/version print aitools text, and the root package imports aitools,
# so their tests run here too: a change under the sources above does not
# trigger the `test` job. cmd/air is left out: its only aitools call is
# covered by the air/image-push golden below, and its unit tests take
# over a minute without touching aitools.
- |
{{.GO_TOOL}} gotestsum \
--format ${GOTESTSUM_FORMAT:-pkgname-and-test-fails} \
--no-summary=skipped \
--packages "./cmd/aitools/... ./libs/aitools/... ./experimental/aitools/..." \
--packages "./cmd/aitools/... ./libs/aitools/... ./experimental/aitools/... ./cmd ./cmd/apps ./cmd/experimental ./cmd/root ./cmd/version ." \
-- -timeout=${LOCAL_TIMEOUT:-60m}
# The goldens of help, cmd/version, quickstart and air help print aitools text;
# air/image-push runs a child process with the aitools self-exec environment.
- |
{{.GO_TOOL}} gotestsum \
--format ${GOTESTSUM_FORMAT:-pkgname-and-test-fails} \
--no-summary=skipped \
--packages ./acceptance/... \
-- -timeout=${LOCAL_TIMEOUT:-60m} -run "TestAccept/apps|TestAccept/cmd/aitools|TestAccept/experimental/aitools"
-- -timeout=${LOCAL_TIMEOUT:-60m} -run "TestAccept/apps|TestAccept/cmd/aitools|TestAccept/experimental/aitools|TestAccept/help$|TestAccept/cmd/version|TestAccept/quickstart|TestAccept/air/help|TestAccept/air/config-help|TestAccept/air/image-push"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] TestAccept/help$ is correctly anchored with $, but the other new patterns (TestAccept/air/help, TestAccept/cmd/version, TestAccept/quickstart, etc.) are not. Go's -run is an unanchored regex, so TestAccept/air/help would also select a future TestAccept/air/help-debug. Either anchor all the new patterns with $ or drop the anchor on help so the style is consistent.


test-exp-ssh:
desc: Run experimental SSH unit and acceptance tests
Expand Down
Loading