Repository navigation
aitools: run aitools-dependent cmd tests and goldens in test-exp-aitools #7848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -708,18 +708,26 @@ tasks: | |
| - acceptance/experimental/aitools/** | ||
| - "{{.EMBED_SOURCES}}" | ||
| cmds: | ||
| # cmd/root runs aitools hooks on every command, cmd, cmd/apps and | ||
| # cmd/version print aitools text, and the root package imports aitools, | ||
| # so their tests run here too: a change under the sources above does not | ||
| # trigger the `test` job. cmd/air is left out: its only aitools call is | ||
| # covered by the air/image-push golden below, and its unit tests take | ||
| # over a minute without touching aitools. | ||
| - | | ||
| {{.GO_TOOL}} gotestsum \ | ||
| --format ${GOTESTSUM_FORMAT:-pkgname-and-test-fails} \ | ||
| --no-summary=skipped \ | ||
| --packages "./cmd/aitools/... ./libs/aitools/... ./experimental/aitools/..." \ | ||
| --packages "./cmd/aitools/... ./libs/aitools/... ./experimental/aitools/... ./cmd ./cmd/apps ./cmd/experimental ./cmd/root ./cmd/version ." \ | ||
| -- -timeout=${LOCAL_TIMEOUT:-60m} | ||
| # The goldens of help, cmd/version, quickstart and air help print aitools text; | ||
| # air/image-push runs a child process with the aitools self-exec environment. | ||
| - | | ||
| {{.GO_TOOL}} gotestsum \ | ||
| --format ${GOTESTSUM_FORMAT:-pkgname-and-test-fails} \ | ||
| --no-summary=skipped \ | ||
| --packages ./acceptance/... \ | ||
| -- -timeout=${LOCAL_TIMEOUT:-60m} -run "TestAccept/apps|TestAccept/cmd/aitools|TestAccept/experimental/aitools" | ||
| -- -timeout=${LOCAL_TIMEOUT:-60m} -run "TestAccept/apps|TestAccept/cmd/aitools|TestAccept/experimental/aitools|TestAccept/help$|TestAccept/cmd/version|TestAccept/quickstart|TestAccept/air/help|TestAccept/air/config-help|TestAccept/air/image-push" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nit] |
||
|
|
||
| test-exp-ssh: | ||
| desc: Run experimental SSH unit and acceptance tests | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] The comment lists every added package and explicitly justifies excluding
cmd/air, but./cmd/experimental(line 721) is silently included. It belongs here becausecmd/experimental/experimental.goimportsexperimental/aitools/cmd—worth a short clause so a future reader doesn't wonder why it's there or remove it.