Repository navigation
Treat bundle paths that are not valid URLs as local paths - #7851
Merged
Merged
Conversation
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=2 unreleased=0 coverage=0 failing=0
TestAccept/bundle/paths/notebook_name_with_colon/DMS=: branch ✅ | main (03bedcb) ❌ | latest (v1.27.0) ❌main (03bedcb): latest (v1.27.0): TestAccept/bundle/paths/notebook_name_with_colon/DMS=true: branch ✅ | main (03bedcb) ❌ | latest (v1.27.0) ❌main (03bedcb): latest (v1.27.0): |
Contributor
|
The AI agent (opus5.5, isaac_claude) |
andrewnester
approved these changes
Nov 20, 2026
Collaborator
✅ Integration test reportCommit: d122a47
Top 5 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
NormalizePathsandTranslatePathscallurl.Parseonly to skip paths that have a scheme, such asdbfs:/.... A path that does not parse as a URL is now treated as a local path instead of failing the command.Why
New workspace notebooks get default names like
New Notebook 2026-10-28 12:17:43.ipynb. When a job task refers to one by its bare name, every bundle command, includingbundle config-remote-sync, fails with:Go's
url.Parserejects a relative reference whose first segment contains a colon. Such a path has no scheme, so it is local;isRemoteStorageSchemeinbundle/librariesalready treats a parse error the same way../New Notebook ...andsrc/New Notebook ...were never affected.Names whose colon follows a scheme-like word, such as
Notes:2026.ipynb, still parse as a URL with a scheme and are left as they are. That was already the case; telling them apart from Windows drive paths likeC:\dirneeds its own change.Tests
New acceptance test
bundle/paths/notebook_name_with_colonvalidates a bundle whose notebook task points at a bare name with colons; it fails without the fix. The script creates the notebook because Windows does not allow colons in file names, so the test is skipped there.go test ./bundle/..., thebundle/paths,config-remote-sync,validate,librariesandartifactsacceptance tests,lint-qandfmt-qpass locally.eebdc0dNotes:2026.ipynb, pre-existing, see Why); auto review: approve, its Codex reviewer produced no resulteebdc0dRIGHT-SIZED: turns the parse error into "no scheme" at the only two call siteseebdc0dd122a47(latest)d122a47(latest)d122a47(latest)✅ success · ⏳ pending ·⚠️ warning · ❌ failed · ➖ n/a
This pull request and its description were written by Isaac.