Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
TIMEtocom.databricks.sdk.service.catalog.ColumnTypeNameso that Unity Catalog columns of typeTIMEdeserialize to a proper enum value instead ofnull.Why
Unity Catalog returns
type_name: "TIME"forTIMEcolumns (e.g. fromtables().list()/tables().get()), butColumnTypeNamehas noTIMEconstant. Because the SDK's ObjectMapper enablesREAD_UNKNOWN_ENUM_VALUES_AS_NULL,ColumnInfo.getTypeName()silently becomesnullfor these columns.Callers that switch on the type name then fail with a
NullPointerException, and there is no way to tell aTIMEcolumn apart from a genuinely missing type without falling back to parsingtype_text.ColumnTypeNameis generated from the OpenAPI spec, so the lasting fix is to addTIMEto the spec; this PR is the equivalent change to the generated code.What changed
Interface changes
ColumnTypeName.TIME: new enum constant.Behavioral changes
ColumnInfo.getTypeName()(and otherColumnTypeNamefields) returnsColumnTypeName.TIMEinstead ofnullforTIMEcolumns.Internal changes
None.
How is this tested?
mvn -pl databricks-sdk-java compilepasses. No unit tests were run or added; the change is a single generated enum constant.🤖 Generated with Claude Code