[SEA-NodeJS] Rename SEA → kernel across the driver (useSEA → useKernel)#415
Open
msrathore-db wants to merge 1 commit into
Open
[SEA-NodeJS] Rename SEA → kernel across the driver (useSEA → useKernel)#415msrathore-db wants to merge 1 commit into
msrathore-db wants to merge 1 commit into
Conversation
The kernel backend can sit on top of any wire protocol (today SEA/Statement
Execution API, tomorrow others), so the driver should not brand its path "SEA".
This renames the driver-layer surface to "kernel" while preserving genuine
references to the SEA wire protocol the kernel happens to speak.
- Public option `useSEA` → `useKernel` (matches the python connector's
`use_kernel=True`).
- `lib/sea/` → `lib/kernel/`, `Sea*` classes/types → `Kernel*`
(KernelBackend, KernelSessionBackend, KernelOperationBackend, KernelAuth,
KernelNativeLoader, KernelServerInfo, KernelPositionalParams, …).
- `tests/unit/sea/` → `tests/unit/kernel/`, `tests/e2e/sea/` →
`tests/e2e/kernel/` (+ Sea*-named test files renamed).
- `native/sea/` → `native/kernel/` (binding dir) with build:native / prepack /
loader require path / .gitignore / .prettierignore / .npmignore /
.gitattributes / kernel-e2e.yml all updated. The committed napi artifacts
(index.d.ts / index.js) are restored byte-for-byte from the generated
originals so the kernel-e2e drift-guard still matches a fresh build.
- Driver-prose comments ("SEA backend/path/operation/-only", binding error
messages, …) → "kernel". PRESERVED the ~8 genuine protocol references
("the SEA REST protocol", "Statement Execution API (SEA)", "SEA wire",
SEA `CreateSession` wire fields) since those describe the actual protocol,
not our path.
Stacked on the KERNEL_REV pin PR. tsc + lint + prettier clean; full unit
suite green (1148); `useKernel: true` validated end-to-end against a live
warehouse. No public `useSEA` references remain anywhere in the tree.
Co-authored-by: Isaac
Signed-off-by: Madhavendra Rathore <madhavendra.rathore@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #414 (the
KERNEL_REVpin). Top of the SEA stack: #412 (merged) → #413 → #414 → this.Why
The kernel backend can sit on top of any wire protocol (today SEA / Statement Execution API, later others), so the driver shouldn't brand its path "SEA". This renames the driver-layer surface to
kernel, matching the python connector'suse_kernel=True(databricks-sql-python #787), while preserving genuine references to the SEA wire protocol the kernel speaks.What changed (mechanical, no behavior change)
useSEA→useKernel.lib/sea/→lib/kernel/;Sea*classes/types →Kernel*(KernelBackend,KernelSessionBackend,KernelOperationBackend,KernelAuth,KernelNativeLoader,KernelServerInfo,KernelPositionalParams, …).tests/unit/sea/→tests/unit/kernel/,tests/e2e/sea/→tests/e2e/kernel/(+Sea*-named test files).native/sea/→native/kernel/— withbuild:native,prepack, loader require path,.gitignore,.prettierignore,.npmignore,.gitattributes, andkernel-e2e.ymlall updated.index.d.ts/index.js) are restored byte-for-byte from the generated originals, so the [SEA-NodeJS] Pin the kernel by SHA (KERNEL_REV) + kernel-e2e CI #414 kernel-e2e drift-guard still matches a fresh build.Deliberately preserved
The ~8 genuine protocol references — "the SEA REST protocol", "Statement Execution API (SEA)", "SEA wire", SEA
CreateSessionwire fields — because those describe the actual protocol, not our path. A blindSEA→kernelsed would have made these factually wrong.Verification
tsc+eslint+prettierclean.useKernel: truevalidated end-to-end against a live warehouse.git grep useSEA→ no results anywhere in the tree.This pull request and its description were written by Isaac.