Repository navigation
Complete configured Volume transfers through the native backend #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
836b8d8
49f32ae
531e8a0
bd3d68c
3a01877
fc0ac1d
b7e0be6
3c6a8cc
0f5be1e
4bf828a
381f4e0
f8df87c
d58e929
191582b
0d84261
2e2c4c7
745f36f
efc0e10
a4f1649
11b1d72
6be0b76
7537263
0a266a2
9003e80
3bf5367
86319e7
7787206
9f511fb
dea2867
08d2e83
5e80236
2de1567
c960aa4
e0d4aaf
c842040
c0e8f45
8f7882e
e2611e0
816d808
40c34bf
e48dfc9
1d03dbe
113f7ad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| dac32e2bf44468bdab06747dad4f289d1c0a18bd | ||
| c2ddddc61bd41d9529dd19f36546d603ba21150d |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -108,12 +108,17 @@ export default class DBSQLSession implements IDBSQLSession { | |
| // If `stagingAllowedLocalPath` is not provided - don't do anything to the operation. In a case of regular | ||
| // operation, everything will work as usual. In a case of staging operation, it will be processed like any | ||
| // other query - it will be possible to get data from it as usual, or use other operation methods. | ||
| // Backends with explicit staging completion handle it before metadata is fetched. | ||
| if (options.stagingAllowedLocalPath !== undefined) { | ||
| const allowedLocalPath = Array.isArray(options.stagingAllowedLocalPath) | ||
| ? options.stagingAllowedLocalPath | ||
| : [options.stagingAllowedLocalPath]; | ||
| if (opBackend.completeStagingOperation) { | ||
| await this.runBackend(() => opBackend.completeStagingOperation!(allowedLocalPath)); | ||
|
aakash-saravanan-db marked this conversation as resolved.
Resolved
aakash-saravanan-db marked this conversation as resolved.
Resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 Low — If native completion rejects, executeStatement throws after the operation was registered. The operation, and its native statement, stays open until the session closes. The Thrift staging path behaves the same way. Best-effort close the operation on failure and rethrow the original error. 🔀 Found by GPT-6.1 Sol · confirmed by the judge There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 Low — The operation is registered by wrapOperation before completion runs. If completion throws, the caller never gets a handle and the statement stays open until session close. Best-effort close the operation when completion fails, and rethrow the original error. 🔀 Found by GPT-6.1 Sol · confirmed by the judge |
||
| return operation; | ||
| } | ||
| const metadata = await operation.getResultMetadata(); | ||
| if (metadata.isStagingOperation) { | ||
| const allowedLocalPath = Array.isArray(options.stagingAllowedLocalPath) | ||
| ? options.stagingAllowedLocalPath | ||
| : [options.stagingAllowedLocalPath]; | ||
| return this.handleStagingOperation(operation, allowedLocalPath, metadata); | ||
| } | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -523,14 +523,8 @@ export function buildKernelHttpOptions(options: ConnectionOptions): KernelHttpOp | |
| headers.push({ name: 'User-Agent', value: buildUserAgentString(userAgentEntry) }); | ||
|
|
||
| const http: KernelHttpOptions = { customHeaders: headers }; | ||
| // Per-connection socket read timeout (ms). The public `socketTimeout` | ||
| // ConnectionOption maps onto the kernel napi `socketTimeoutMs` | ||
| // (kernel `HttpConfig::request_timeout` / reqwest `Client::timeout`). | ||
| // Only forward a POSITIVE value: `socketTimeout: 0` means "disabled / wait | ||
| // indefinitely" on the Thrift path, but forwarding `0` would make reqwest | ||
| // time out immediately, so we omit it and let the kernel keep its (large) | ||
| // default — preserving the "effectively no idle timeout" semantics. | ||
| if (typeof socketTimeout === 'number' && socketTimeout > 0) { | ||
| // Preserve zero so native storage inactivity can be disabled like Thrift. | ||
| if (typeof socketTimeout === 'number' && socketTimeout >= 0) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Medium — socketTimeout: 0 is now forwarded as socketTimeoutMs: 0. Bindings that still treat the value as the reqwest total timeout (the currently pinned ones) would time out immediately. The change has no unit test. Gate it on the coordinated binding release, add tests for 0 and positive values, and add a changelog note. 🔀 Found by Claude Opus 5.5 · confirmed by the judge There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 Low — socketTimeout 0 is now forwarded to the binding, and positive values also set the storage idle timeout. There is no unit test for buildKernelHttpOptions covering this, and the CHANGELOG has no entry for it. Add tests for 0 and positive values, and a CHANGELOG note that it needs the new native release. 🔀 Found by Claude Opus 5.5 · confirmed by the judge There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Medium — socketTimeout: 0 is now forwarded to the native layer. A pre-change binding would treat 0 as an immediate reqwest timeout, and no test covers 0 or positive values. Add buildKernelHttpOptions tests and tie this change to the coordinated native release. 🔀 Found by Claude Opus 5.5 · confirmed by the judge There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Medium — 🔀 Found by Claude Opus 5.5 · confirmed by the judge |
||
| http.socketTimeoutMs = socketTimeout; | ||
| } | ||
| return http; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 Low — The changelog entry doesn't say a published kernel package bump is required. It also doesn't mention that
socketTimeout: 0is now forwarded and that the timeout now bounds storage idle time. Add both notes as separate entries.🔀 Found by Claude Opus 5.5 · confirmed by the judge