Repository navigation
Materialize Arrow batches directly into result chunks - #641
Closed
vuanhphung wants to merge 3 commits into
Closed
vuanhphung wants to merge 3 commits into
vuanhphung wants to merge 3 commits into
Conversation
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
vuanhphung
temporarily deployed
to
azure-prod
November 20, 2026 01:09 — with
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
November 20, 2026 01:09 — with
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
November 20, 2026 01:09 — with
GitHub Actions
Inactive
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
vuanhphung
temporarily deployed
to
azure-prod
November 20, 2026 01:18 — with
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
November 20, 2026 01:18 — with
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
November 20, 2026 01:18 — with
GitHub Actions
Inactive
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com> Co-authored-by: Isaac <no-reply@databricks.com>
vuanhphung
temporarily deployed
to
azure-prod
November 20, 2026 02:02 — with
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
November 20, 2026 02:02 — with
GitHub Actions
Inactive
vuanhphung
temporarily deployed
to
azure-prod
November 20, 2026 02:02 — with
GitHub Actions
Inactive
Collaborator
Author
|
Closing as no gain: writing batches straight into the slicer's output chunk saved 22.7% on an 80M-row drain with row materialization off, but slowed materialized object reads by 13–21% (more GC, about 2x peak heap), and three capacity variants didn't remove the regression. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not a shipping candidate: extended verification found materialized-object regressions, so this PR remains a draft for evidence only. Main spends 402 ms copying 80M row references in
concatChunks(405 ms in a live kernel profile).The prototype lets the shared Arrow converter append into the slicer's output and materialize overflow into an owned tail, preserving row conversion, chunk boundaries and clear-on-take behavior. It improves the placeholder drain but increases materialized-object heap/GC costs; three capacity-allocation variants did not fix that regression and are not included.
Verification: 1876 unit tests, 57 live e2e tests, 64 main/candidate checksum/lifecycle comparisons, build, type-check, lint and formatting pass. Fresh Node 24.22.1 processes; five rotated local pairs, real IPC, no network (sample p95/p99 are both the maximum):
Exact-dashboard and bounded materialized live comparisons cover both backends; shared-warehouse wall times are mixed/noisy, not a uniform speedup. The 5M-object CPU profiles show GC self time 31 → 50 ms; observed peak heap rises roughly 46 → 104 MiB, while forced-GC retained heap stays equal.
Adversarial review: not requested; self-verification fails the materialized-read safety bar. Do not mark ready or merge.
This pull request and its description were written by Isaac.