Repository navigation
feat(kernel): expose HTTP/2 opt-out #1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
449e23e
faa36ab
1b895c6
12855a7
9a88f32
cbbd342
5f7db3e
d517411
6bc721f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| # Release History | ||
|
|
||
| # Unreleased | ||
| - Kernel HTTPS traffic negotiates HTTP/2 with HTTP/1.1 fallback. Set `enable_http2=False` to force HTTP/1.1. Configured proxies also force HTTP/1.1. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 Low — The kernel floor is still ^1.4.0, so older wheels may not negotiate HTTP/2 or force HTTP/1.1 behind a proxy as the CHANGELOG and README claim. Explicit 🔀 Found by Claude Opus 5.5 · confirmed by the judge
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicate of #1070 (comment). This PR will merge only with the kernel requirement and lockfile raised to the release providing kernel #483. The installed-wheel capability check handles explicit values in the meantime; the release floor remains a merge prerequisite. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| - Honor `max_download_threads` on kernel connections, with a default download window of 16 and explicit chunk-setting overrides. Invalid values raise `ValueError` when connecting with `use_kernel=True`. | ||
| - Fix the kernel backend ignoring `use_cloud_fetch=False`, so complete results can be fetched without cloud-storage downloads. | ||
| - Fix inline parameters (`use_inline_params=True`) so a sequence directly after `IN` renders as a list again: `x IN %(ids)s` renders as `x IN (1,2,3)` instead of `x IN ARRAY(1,2,3)`, which Spark rejects. Inside the list, tuples render as rows for a multi-column `IN`, and a `set` or `frozenset` is accepted again. Sequences anywhere else still render as `ARRAY(...)` ([#629](https://github.com/databricks/databricks-sql-python/issues/629)) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 Low — The CHANGELOG entry says kernel HTTPS negotiates HTTP/2 and that
enable_http2=Falseforces HTTP/1.1. The floor is still^1.4.0, and the code raises NotSupportedError when the installed wheel lacks the kwarg, so the entry is only true with a newer wheel. Name the required kernel version in the entry, or raise the pyproject floor once that wheel ships.🔀 Found by Claude Opus 5.5 · confirmed by the judge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unsupported-wheel error is now explicit, but the actual kernel requirement and lockfile still need to move to the release providing the option before this PR merges. The changelog will ship with that pin update; this release prerequisite remains open.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still open at d517411: CHANGELOG.md:4 doesn't name a kernel version, and the kernel floor and lockfile haven't been raised.