Skip to content

jprakash db/test gh #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jprakash-db wants to merge 2 commits into from
Closed

jprakash db/test gh #758

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d86d663
Updated some lines
jprakash-db Mar 20, 2026
8455fad
Setting up hatch
jprakash-db Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,10 @@ See [CONTRIBUTING.md](CONTRIBUTING.md)
## License

[Apache License 2.0](LICENSE)


## Testing new lines
Added a new line describing the efforts
Comment on lines +98 to +99
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new section title "Testing new lines" and the sentence below it read like placeholder text and don’t communicate actionable testing guidance. Consider removing this section or replacing it with actual test instructions (e.g., how to run the existing pytest suite).

Copilot uses AI. Check for mistakes.

## How to setup the Python Connector
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header uses "setup" as a verb; standard usage is "set up" (two words) for the action. Please adjust the heading to "How to set up the Python Connector" for correctness and consistency.

Suggested change
## How to setup the Python Connector
## How to set up the Python Connector

Copilot uses AI. Check for mistakes.
Python Connector needs to setup using hatch
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line says the connector needs to be set up using Hatch, but the repository’s pyproject.toml is configured for Poetry (no Hatch configuration present). Either update the docs to reflect Poetry-based setup, or add the missing Hatch configuration/instructions if Hatch is intended going forward.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar/formatting: "needs to setup using hatch" should be "needs to be set up using Hatch" (and remove the double space).

Suggested change
Python Connector needs to setup using hatch
The Python connector needs to be set up using Hatch.

Copilot uses AI. Check for mistakes.
Loading