Repository navigation
Conversation
Starting a tunnel needs the host's Remote - SSH extension (ms-vscode-remote.remote-ssh, or anysphere.remote-ssh in Cursor). When the `extensions.allowed` policy blocks it, the connect fails late and confusingly. Check the setting up front and show a modal error with a shortcut to the setting instead. The check follows VS Code's precedence: an extension ID rule beats a publisher rule (including the `microsoft` special case), which beats the `*` wildcard. Co-authored-by: Isaac <no-reply@databricks.com>
|
🤖 Integration tests ✅ passed for |
|
🤖 Integration tests ✅ passed for |
| extensionId, | ||
| }; | ||
| } | ||
| return {allowed: allowedExtensions["*"] !== false, extensionId}; |
There was a problem hiding this comment.
If allowedExtensions is missing "*" as a key, allowed will be true but VS Code blocks extension.
E.g. extensions.allowed: {"databricks": true, "github": true} - VS Code would block the installation in this case, but checkSshExtensionAllowed would return true.
There was a problem hiding this comment.
@louis-johnston-db The default setting is true, so when no "*" key exists every extension is allowed unless explicitly disabled. In your example {"databricks": true, "github": true} is equivalent to {"*": true}
…lues Lowercase the setting's keys so lookups are case-insensitive, as VS Code does. Treat null and arrays as allow-all instead of crashing on null and accidentally matching on arrays. Co-authored-by: Isaac <no-reply@databricks.com>
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
🤖 Integration tests ✅ passed for |
…SH (#2299) ## Changes Port of #2290 to the 3.0 release branch Starting a tunnel needs the host's Remote - SSH extension (ms-vscode-remote.remote-ssh, or anysphere.remote-ssh in Cursor). When the extensions.allowed policy blocks it, the connect fails late and confusingly. Check the setting up front and show a modal error with a shortcut to the setting instead. The check follows VS Code's precedence: an extension ID rule beats a publisher rule (including the microsoft special case), which beats the * wildcard. ## Tests unit tests added --------- Co-authored-by: Isaac <no-reply@databricks.com>
Pull request was closed
Changes
Starting a tunnel needs the host's Remote - SSH extension (ms-vscode-remote.remote-ssh, or anysphere.remote-ssh in Cursor). When the
extensions.allowedpolicy blocks it, the connect fails late and confusingly. Check the setting up front and show a modal error with a shortcut to the setting instead.The check follows VS Code's precedence: an extension ID rule beats a publisher rule (including the
microsoftspecial case), which beats the*wildcard.Tests
unit tests added