Repository navigation
Patch @vscode/test-electron 2.5.2 so a dropped VS Code download retries - #2328
Merged
Merged
Conversation
wdio-vscode-service@8 pulls in @vscode/test-electron@^2.4.1 (2.5.2). Its unzipVSCode() leaves the stream-checksum promise unawaited when the write fails first, so a mid-download ECONNRESET becomes an unhandled rejection that kills the e2e run before the built-in retry runs. Backport the upstream fix (microsoft/vscode-test#340), which only shipped in 3.x. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Contributor
|
🤖 Integration tests ✅ passed for |
Contributor
Author
|
@louis-johnston-db @rclarey could one of you review this? It's a one-line yarn patch (backport of microsoft/vscode-test#340) that keeps a dropped VS Code download from crashing the e2e run before its retry. CI and integration tests pass on cc94ac3. |
louis-johnston-db
approved these changes
Nov 17, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The
vscode-isolated-nightlyrun on 2026-11-17 (run) failed in one Linux e2e job. A connection reset (ECONNRESET) while downloading VS Code crashed the run instead of retrying:wdio-vscode-service@8depends on@vscode/test-electron@^2.4.1, which resolves to 2.5.2. In 2.5.2,unzipVSCode()starts avalidateStreamchecksum promise and never handles its rejection when the file write fails first. On Node 22 the unhandled rejection kills the process, so the built-in retry never runs for errors that happen mid-download. Upstream added the missing handler (checksum.catch(() => {})) in microsoft/vscode-test#340, but it shipped only in 3.0.0. No 2.x release has it.This PR backports that one line as a yarn patch:
.yarn/patches/@vscode-test-electron-npm-2.5.2-7b7f19ec88.patch, which addschecksum.catch(() => { });toout/download.js.resolutionsentry that points@vscode/test-electron@^2.4.1at the patched 2.5.2, in the same style as the existing@databricks/sdk-experimentalpatch.yarn.lock. The repo's direct@vscode/test-electron@^3.1.0dependency is unchanged.Forcing the 2.x copy up to 3.x would also work, but nobody has checked that
wdio-vscode-service@8works with the 3.x API, so this patch is the lower-risk option.Tests
yarn install --immutable(yarn 3.2.1, Node 22) passes the resolution step locally, so the lockfile matchespackage.json. The fetch step couldn't run on my devbox because it has no access to the public registry, so CI's install is the full check.This pull request and its description were written by Isaac.