Balance CI shards and consolidate static checks to cut wallclock#175
Open
parthban-db wants to merge 1 commit into
Open
Balance CI shards and consolidate static checks to cut wallclock#175parthban-db wants to merge 1 commit into
parthban-db wants to merge 1 commit into
Conversation
|
Please ensure that the NEXT_CHANGELOG.md file is updated with any relevant changes. |
000f849 to
c9a5422
Compare
Alphabetical sharding piled 37 of 86 packages into the [s-z] shard (every uc-* package starts with `u`), making Lint([s-z]) the ~232s CI long pole. The protected runner pool also serves only ~8-12 jobs before autoscaling kicks in, so simply adding shards trades work time for queue time and does not help wallclock. Replace alphabetical sharding with weight-balanced shards computed by scripts/ci-shards.mjs (8 shards, sized to the runner pool), and fold build, lint, and format:check into one per-shard `static` job so each shard builds its dependency closure once instead of repeating it across separate lint, typecheck, and build jobs. The standalone typecheck pass is dropped because the build task (`tsc -b`) already type-checks src while emitting, making a separate `tsc --noEmit` over the same files redundant. Co-authored-by: Isaac
c9a5422 to
90729aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Summary
Alphabetical sharding piled 37 of 86 packages into the [s-z] shard
(every uc-* package starts with
u), making Lint([s-z]) the ~232s CIlong pole. Replace it with weight-balanced shards computed by
scripts/ci-shards.mjs, and fold build, lint, typecheck, and
format:check into one per-shard
staticjob so each shard builds itsdependency closure once instead of repeating it across separate lint,
typecheck, and build jobs.
Co-authored-by: Isaac
Why
What changed
Interface changes
Behavioral changes
Internal changes
How is this tested?