Repository navigation
Conversation
|
/ug-review This comment was generated with GitHub MCP. |
UG review recommendationRECOMMENDATION: APPROVE Reasons:
Findings considered: 1 (severities: medium: 1); see the inline review comments. Advisory only: this recommendation never approves or merges the pull request. The |
Polly AI ReviewBlocking issuesNone identified. Security vulnerabilitiesNone identified. Diagnostic output retains existing redaction. Non-blocking notes
ApproachThe approach is sound: reuse SummaryDiff size (computed): 2 files; +17 / -1 lines (18 changed text lines); 0 binary files.
Shares use additions + deletions, including generated text and lockfiles. Binary files have no line count. Tests include fixtures/helpers under test paths and colocated test/spec files; categories are path-based, not coverage measurements. ChangesAdds control-wait timing and scan evidence, captures the searched subtree, and documents how to interpret a later snapshot. The implementation and documentation are proportional to that outcome; no concrete size reduction is warranted. TestsTest-by-test assessmentNo test cases were added, modified, or removed. Existing coverage does not establish delivery of the new timeout diagnostics.
PowerShell syntax parsing and a synthetic ordered-dictionary JSON round-trip passed. Existing test suites and Windows UI Automation were not run; actual failure-artifact delivery remains unverified. No API or usage-attribution behavior changes. To verify on Windows, run the existing Cowork job. On a control timeout, inspect ScopeBoth changed files support the stated diagnostic outcome. No unrelated changes were found. Wait budgets, selectors, consent clicks, and completed-task assertions remain unchanged. Automated review by Polly · workflow run |
|
Both Polly follow-ups are addressed: snapshot errors are recorded separately while retaining the original timeout (55a1319), and the focused PowerShell self-check validates searched-root forwarding, a ready control, missing control evidence, and failed capture. d42946f additionally checks the actual JSON round-trip so field serialization is covered. The self-check runs in the native Windows validation step. PowerShell is unavailable locally; CI remains the execution evidence. This comment was generated with GitHub MCP. |
What did you change, and why?
The Windows Hosted Cowork file task failed waiting for its folder-permission dialog in CI 44751086897. Both failure snapshots already contain the exact expected label, enabled and onscreen, so they cannot distinguish late dialog arrival from a slow or inconsistent UI Automation lookup.
Record requested labels, scan count, configured wait budget, elapsed time at timeout and snapshot completion time in the existing
result.json. Capturewait-failed.jsonfrom the actual subtree searched, including native folder dialogs. If capture fails, record its exception class and retain the original control timeout. Document interpretation and add a Windows script-validation self-check. Wait budgets, selectors, consent clicks and completed-task assertions remain unchanged.How do you know it works?
Confirmed the downloaded failure artifact contains the exact enabled, onscreen permission label.
git diff --check, YAML parsing of the Windows validation step and commit/push secret scans passed.The final-head PowerShell self-check passed in the Windows Hosted and Anthropic Relay validation steps (Hosted job, Relay job). It executes the real wait function with external UI Automation calls substituted, checking a ready control, JSON-serialized timing fields, searched-root forwarding and snapshot failure preserving the original timeout.
PowerShell/UI Automation is unavailable on this Linux Arclet. Actual native control-timeout artifact delivery remains unverified; passing component checks do not establish the underlying UI flake is fixed.
tests/README.mdis unchanged.Checklist before requesting review
/ug-reviewand address the comments. The connector footer prevented exact command matching, so the supportedug-reviewlabel triggered the completed review. Recommendation: APPROVE. The snapshot-error thread is fixed, replied to and resolved; Polly's failure-capture and serialization suggestions are addressed./integration-testwill not be commented, as instructed.