fix: Validate Firebase config before injection (DAT-11942)#2
Open
riffellabot wants to merge 1 commit intomainfrom
Open
fix: Validate Firebase config before injection (DAT-11942)#2riffellabot wants to merge 1 commit intomainfrom
riffellabot wants to merge 1 commit intomainfrom
Conversation
Implements "Atomic Config or Nothing" principle to fix issue where incomplete Firebase config breaks Preview with auth/invalid-api-key error. Changes: - Added isFirebaseConfigComplete() to validate required keys (apiKey, projectId, appId) - Only inject __FIREBASE_CONFIG__ if validation passes - Log warning when config is incomplete instead of injecting partial config - Prevents crash in generated auth/config.ts module Fixes DAT-11942 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes DAT-11942: Incomplete Firebase config injection breaks Preview with
auth/invalid-api-keyerror.This implements the "Atomic Config or Nothing" principle - Firebase config is only injected if it contains all required keys (apiKey, projectId, appId).
Changes
isFirebaseConfigComplete()validation helper infrontend/vite.config.tsauth/config.tsmoduleImpact
Test Plan
Related Issues
🤖 Generated with Claude Code