WHO Tuberculosis Rifampicin Resistant Data Import#2016
WHO Tuberculosis Rifampicin Resistant Data Import#2016pravnkumar-cloudsufi wants to merge 10 commits into
Conversation
|
Hi @saanikaaa Please review the PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new data import for WHO Tuberculosis treatment outcomes related to rifampicin-resistant and MDR-TB. The implementation includes a Python script for data retrieval and merging, along with the required configuration and test files. Feedback focuses on correcting the manifest's script paths and filenames, adding timeouts to network requests, handling potential unmapped countries during data merging to avoid invalid DCIDs, and resolving inconsistencies between the metadata configuration and the test output format.
saanikaaa
left a comment
saanikaaa
left a comment
There was a problem hiding this comment.
Lets remove schema and statvar file from test as they are one time activity and wont be generated once CL is submitted
saanikaaa
left a comment
saanikaaa
left a comment
There was a problem hiding this comment.
pls provide a better name to test data files
…erculosis_rr_mdr_tb_output_stat_vars_schema.mcf Deleting the .mcf file
…erculosis_rr_mdr_tb_output_stat_vars.mcf Deleting the .mcf file
2 participants
Kindly find the PR Checklist: https://docs.google.com/spreadsheets/d/1DP2SvoEwoU6VXvKucE9xiABKRVDzEx-D/edit?resourcekey=0-AaGcMXwYDzrz9obQi2_JbQ&gid=262592105#gid=262592105