fix: Register ValuesEntry helper in Observations PROTO BUNDLE#2023
Merged
Conversation
To enable native Spanner SQL engines and BigQuery Federation queries to parse map keys/values directly from the Observations PROTO column, the internal nested map-helper message `org.datacommons.Observations.ValuesEntry` must be explicitly registered inside the PROTO BUNDLE. Without this, Spanner SQL queries fail when calling `UNNEST(observations.values)` with a "placeholder descriptor" error.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the schema.sql file to include org.datacommons.Observations.ValuesEntry in the PROTO BUNDLE to support UNNEST operations on map fields. Feedback indicates that this change will not be automatically applied to existing databases because the initialization logic skips DDL updates if tables are already present; manual updates or logic adjustments are recommended to ensure the schema is correctly updated.
vish-cs
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue observed in http://b/511329206#comment9.
To enable native Spanner SQL engines and BigQuery Federation queries to parse map keys/values directly from the Observations PROTO column, the internal nested map-helper message
org.datacommons.Observations.ValuesEntrymust be explicitly registered inside the PROTO BUNDLE.Without this, Spanner SQL queries fail when calling
UNNEST(observations.values)with a "placeholder descriptor" error.