Skip to content

Add timeout for aggregations#2026

Open
vish-cs wants to merge 1 commit into
datacommonsorg:masterfrom
vish-cs:timeout
Open

Add timeout for aggregations#2026
vish-cs wants to merge 1 commit into
datacommonsorg:masterfrom
vish-cs:timeout

Conversation

@vish-cs
Copy link
Copy Markdown
Contributor

@vish-cs vish-cs commented May 21, 2026

Default timeout is 5 minutes causing workflow failures. Increased to max supported.

@vish-cs vish-cs requested a review from SandeepTuniki May 21, 2026 17:26
@vish-cs vish-cs enabled auto-merge (squash) May 21, 2026 17:27
@vish-cs vish-cs disabled auto-merge May 21, 2026 17:27
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the deployment configuration for the ingestion-helper-service in cloudbuild.yaml to include a 60-minute timeout and adds a 30-minute timeout to the HTTP POST call in spanner-ingestion-workflow.yaml. Feedback suggests increasing the workflow timeout to 3600 seconds to match the service's deployment timeout and avoid premature failures.

call: http.post
args:
url: ${helper_url}
timeout: 1800
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The timeout for the run_aggregation HTTP call is set to 1800 seconds (30 minutes), but the service is deployed with a 60-minute timeout. To avoid premature workflow failures, these timeouts should be consistent. Note that per repository rules, the import-aggregation-helper is responsible for graph data aggregation, while the spanner-ingestion-helper works on metadata tables. Ensure the correct service is being targeted and consider increasing this value to 3600 seconds.

                  timeout: 3600
References
  1. The import-aggregation-helper works on graph data and does not need access to the metadata tables.
  2. The spanner-ingestion-workflow uses the graph database for its dataflow job, while the spanner-ingestion-helper works on the metadata tables in a separate database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants