Open
Conversation
nicolaskempf57
force-pushed
the
feat_add_viz_poc_1
branch
from
0d4cfa5 to
e6e3f61
Compare
function as source of truth
- Convert resources to computed from savedResources - Add loadChart() to fetch chart and extract resource IDs from series - Add loadMissingResourcesForChart() to fetch individual resources - Add loadSelectedChart() triggered by Charger button - Switch form from reactive to ref - Move dataset initialization to top level - Fetch charts list at top level instead of onMounted
… debounced preview
Also add translations
nicolaskempf57
force-pushed
the
feat_add_viz_poc_1
branch
from
5844cc1 to
2291cc3
Compare
ThibaudDauce
requested changes
Apr 20, 2026
|
|
||
| await page.getByLabel('Titre').fill('Test Chart') | ||
| await page.getByLabel('Description').fill('Test Description') | ||
| await page.waitForTimeout(500) |
Contributor
There was a problem hiding this comment.
Do we need this timeout? Could we have something more precise?
Contributor
Author
There was a problem hiding this comment.
There is a debounce for the title / description
Contributor
Author
There was a problem hiding this comment.
I changed it to 300, I don't think we can do it differently
Contributor
There was a problem hiding this comment.
There is no text appearing after the debounce?
Contributor
Author
There was a problem hiding this comment.
The chart title is updated but we can't select it for now, it's inside the canvas. Later it'll be replace with a p tag and one for the description too but this is not done yet
| // Check that this function return wanted data | ||
| const response = await getData(config, props.resource.id, page, sortConfig) | ||
| if ('data' in response && response.data && response.data.length > 0) { | ||
| if ('data' in response && response.data && 0 in response.data) { |
Contributor
Author
There was a problem hiding this comment.
I think it was a type issue, but I will double check
Contributor
Author
There was a problem hiding this comment.
Yep, the issue from the typecheck is :
Error: src/components/ResourceAccordion/Preview.vue(148,35): error TS2769: No overload matches this call.
Overload 1 of 2, '(o: {}): string[]', gave the following error.
Argument of type 'Record<string, unknown> | undefined' is not assignable to parameter of type '{}'.
Type 'undefined' is not assignable to type '{}'.
Overload 2 of 2, '(o: object): string[]', gave the following error.
Argument of type 'Record<string, unknown> | undefined' is not assignable to parameter of type 'object'.
Type 'undefined' is not assignable to type 'object'.
Now that we are live on demo, we can remove the base URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes datagouv/data.gouv.fr#1972