Add OrderedDict. Refactor Dict.render to utilize OrderedDict#116
Open
rainforest-bailey wants to merge 1 commit intodave:masterfrom
Open
Add OrderedDict. Refactor Dict.render to utilize OrderedDict#116rainforest-bailey wants to merge 1 commit intodave:masterfrom
rainforest-bailey wants to merge 1 commit intodave:masterfrom
Conversation
Author
|
For additional context on why this feature is useful. When generating code to initialize a struct, it is beneficial to be able to control the order in which fields are defined. I found myself comparing my code gen to an existing spec definition. Ideally, I would be able to visually scan the 2 side by side, but I had to search each field individually, which was more cumbersome. |
Owner
|
When creating a struct definition, you don't need to use c := Type().Id("foo").Struct(
List(Id("x"), Id("y")).Int(),
Id("u").Float32(),
)
fmt.Printf("%#v", c)
// Output:
// type foo struct {
// x, y int
// u float32
// }See https://github.com/dave/jennifer?tab=readme-ov-file#interface-struct |
Author
|
@dave How would I initialize a struct with a defined field ordering? |
Owner
|
Can you show me the code you want it to output? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to add a companion type to 'Dict', an 'OrderedDict', that will retain original ordering on keys.