refactor(streamable_http): remove writer notification on ClientDisconnect#6
Closed
wiggzz wants to merge 2 commits intodbt-labs/patched-1.27.0from
Closed
refactor(streamable_http): remove writer notification on ClientDisconnect#6wiggzz wants to merge 2 commits intodbt-labs/patched-1.27.0from
wiggzz wants to merge 2 commits intodbt-labs/patched-1.27.0from
Conversation
The low-level server's generic case-Exception handler logs any exception from the session stream at ERROR level. When the streamable HTTP transport sends ClientDisconnect through the writer (to unblock the inner session task), it was caught here and logged as ERROR — producing the same noise we're trying to eliminate. Add a guard clause matching Disconnect/Cancel exception types (by name, to keep the low-level server transport-agnostic) and log at DEBUG instead. Also skip sending 'Internal Server Error' to the client (there is none).
…sconnect The connect() context manager closing streams is sufficient to unblock the session task — no need to send ClientDisconnect through the writer. This avoids the low-level server's case-Exception handler catching it and producing ERROR-level noise (or requiring a separate DEBUG-level handler). Session task exits cleanly when streams are closed on context manager exit.
wiggzz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
writer.send(ClientDisconnect())call was intended to unblock the inner session task by sending a poison pill through the session stream. But this caused the low-level server'scase Exception():handler to catch it and log ERROR-level noise, requiring a separate fix in the low-level server.Solution
Remove the writer notification. The
connect()context manager already closes streams when the request handler returns, which is sufficient to unblock the session task (it getsClosedResourceError/EndOfStreamon the nextreceive()).This eliminates the need for the low-level server fix entirely — no Disconnect/Cancel exceptions reach it anymore.
Changes
writer.send(ClientDisconnect())from_handle_post_request