refactor(streamable_http): remove writer notification on ClientDisconnect#7
Merged
wiggzz merged 1 commit intodbt-labs/patched-1.27.0from May 5, 2026
Merged
Conversation
…nect The writer.send(ClientDisconnect()) call was intended to unblock the inner session task by sending a poison pill through the session stream. But this caused the low-level server's case-Exception handler to catch it and log ERROR-level noise. Removing it — the connect() context manager closing streams is sufficient to unblock the session task (ClosedResourceError/EndOfStream on next receive()). No low-level server change needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
writer.send(ClientDisconnect())call was intended to unblock the inner session task by sending a poison pill through the session stream. ButClientDisconnectinherits fromException, so the low-level server'scase Exception():handler catches it and logs:This produces the same ERROR-level noise in Datadog that the fix is trying to eliminate.
Solution
Remove the writer notification entirely. The
connect()context manager already closes streams when the request handler returns — this is sufficient to unblock the session task (it getsClosedResourceError/EndOfStreamon the nextreceive()).No low-level server change needed.