feat(dl-item-tooltip): match in-game tooltip styling#10
Conversation
|
maybe some specific items aren't displaying correctly some colors, but we can fix them if we notice |
9d4f48b to
86b9cb0
Compare
|
for me this looks way more different to the game, at least the background is missing |
86b9cb0 to
3fc90c1
Compare
3fc90c1 to
2320a08
Compare
|
Hey @victorblino! The visual result looks great, especially the alignment with the in-game tooltip. Before approving, I'd like to request a few targeted adjustments. Nothing that changes the end result, just to reduce the diff size and keep consistency with the rest of the project. 1. Class naming convention The rest of the project uses kebab-case throughout ( Suggestion: normalize the API classes inside html
.replace(/class="InlineAttributeName ([^"]+)"/g, 'class="inline-attribute-label $1"')
.replace(/class="InlineKey"/g, 'class="inline-key"')Then drop all 2. Duplicated CSS variables There are two schemes living side by side: 3. Category variants The inline coloring rules list every variation ( const ATTR_CATEGORY = { Heals: 'heal', Healing: 'heal', Regen: 'heal', /* ... */ };And the CSS becomes one rule per category via 4. Could you add a quick test ensuring raw HTML input ( The rest looks great. The breakdown into |


Updates
dl-item-tooltipto more closely match the in-game tooltip layout and visual behavior.Changes include:
Spirit,SpiritDamage,BulletResist,MeleeDamage,Heal,MoveSpeed,Slow, and related variants.Before:

After:

Validation: