[deckhouse-cli] fix: dcql and pull#357
Merged
Merged
Conversation
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
d8 mirror pullfor edition-scoped sources (FE/EE/SE, etc.): platform, modules, and security services now build download-list URLs fromGetEditionRoot()instead of the bare registry root, so entries like.../deckhouse/release-channel:stableare no longer enqueued alongside the correct.../deckhouse/fe/release-channel:stablepaths.registry.Service.GetEditionRoot()and keepGetRoot()for services that live outside the edition sub-tree (installer, plugins).d8 mirror push: makeImageLayout.AddImageidempotent for the same(tag, digest)pair, and deduplicate OCI layout manifests byio.deckhouse.image.short_tagin the pusher (last descriptor wins).d8 system queue watchby rendering each frame in an alt-screen buffer (cursor home + clear-to-end) instead of clearing the screen before every refresh.Problem
When pulling from edition-scoped registries (e.g.
--source=registry.deckhouse.ru/deckhouse/fe), the download list mixed bare-root and edition-scoped URLs for the same images/channels. That caused redundant network work and confusing logs.Separately, repeated
AddImagecalls during platform pulls could append duplicate descriptors with the same short tag to the OCI layout, which then surfaced in push logs as the same tag being pushed multiple times (e.g.[1 / 337] ... cse:v1.73.2and later[125 / 337] ... cse:v1.73.2).