[dmt] require x-config-version when conversions exist#367
Draft
diyliv wants to merge 1 commit into
Draft
Conversation
6c9e6f2 to
d849c11
Compare
Signed-off-by: diyliv <onlogn081@gmail.com>
d849c11 to
22dfdb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conversions.go): whenopenapi/conversions/directory exists with valid conversion files butopenapi/config-values.yamlhas nox-config-version, dmt now reports an error instead of silently passing. Also checks thatx-config-versionmatches the latest conversion version.tester.go): the conversion tester now reports an error when conversions exist butx-config-versionis 0, instead of returning "not applicable".Context
When a module has conversion files but
x-config-versionis missing fromconfig-values.yaml, the Deckhouse platform cannot generate the ModuleSettingsDefinition with schemas for all versions — the UI shows no configuration form for the module. See deckhouse/sds-replicated-volume#680 for a concrete example.Example
Module with
openapi/conversions/v2.yamlbutopenapi/config-values.yamlmissingx-config-version:Before:
dmt lintpasses silently,dmt test conversionsskips the module.After:
dmt linterrors:dmt test conversionserrors with the same message.