Skip to content

refactor(core): Refactor the Virtualization Controller configuration #1213

Draft
yaroslavborbat wants to merge 6 commits into
mainfrom
refactor/config
Draft

refactor(core): Refactor the Virtualization Controller configuration #1213
yaroslavborbat wants to merge 6 commits into
mainfrom
refactor/config

Conversation

@yaroslavborbat
Copy link
Copy Markdown
Member

@yaroslavborbat yaroslavborbat commented Jul 1, 2025

Description

This PR refactors the Virtualization Controller configuration by consolidating disparate settings previously scattered across flags and environment variables into a unified configuration object:

apiVersion: configuration.virtualization.deckhouse.io/v1alpha1
kind: VirtualizationControllerConfiguration

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: core
type: chore
summary: Refactor the Virtualization Controller configuration 
impact_level: low

@yaroslavborbat yaroslavborbat force-pushed the refactor/config branch 2 times, most recently from 645e06c to 9a16f88 Compare July 2, 2025 12:28
@yaroslavborbat yaroslavborbat changed the title refactor configuration refactor(core): Refactor the Virtualization Controller configuration Jul 2, 2025
@yaroslavborbat yaroslavborbat added this to the v0.22.0 milestone Jul 2, 2025
@yaroslavborbat yaroslavborbat marked this pull request as ready for review July 2, 2025 14:44
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
@yaroslavborbat yaroslavborbat added the validation/skip/doc_changes Skip doc changes validation label Jul 3, 2025
Copy link
Copy Markdown
Contributor

@Isteb4k Isteb4k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why do we need a cobra? Increases cognitive complexity.
  2. Why are some parameters stored in a config map, others passed through envs, and the third are passed as arguments?
  3. The controllers map is difficult to read, it is unclear what we gain by starting to use it. When constructors were called sequentially, the code was more sparse and perceived more orderly

@universal-itengineer universal-itengineer modified the milestones: v0.22.0, v0.23.0 Jul 10, 2025
@nevermarine nevermarine modified the milestones: v0.23.0, v0.24.0 Jul 24, 2025
Comment on lines 216 to +217
x-examples: ["sc-1", "sc-2"]
x-dmt-default: ["sc-1", "sc-2"]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
x-examples: ["sc-1", "sc-2"]
x-dmt-default: ["sc-1", "sc-2"]
x-dmt-default: ["sc-1", "sc-2"]
x-doc-examples:
- ["sc-1", "sc-2"]

@yaroslavborbat yaroslavborbat marked this pull request as draft July 31, 2025 08:22
@universal-itengineer universal-itengineer modified the milestones: v0.24.0, v0.25.0 Aug 8, 2025
@nevermarine nevermarine modified the milestones: v0.25.0, v0.26.0 Aug 29, 2025
@nevermarine nevermarine modified the milestones: v1.0.0, v1.1.0 Sep 11, 2025
@nevermarine nevermarine modified the milestones: v1.1.0, v1.2.0 Oct 6, 2025
@Isteb4k Isteb4k modified the milestones: v1.2.0, v1.1.1 Oct 14, 2025
@nevermarine nevermarine modified the milestones: v1.1.1, v1.2.0 Oct 16, 2025
@Isteb4k Isteb4k modified the milestones: v1.2.0, v1.3.0 Nov 26, 2025
@nevermarine nevermarine modified the milestones: v1.3.0, v1.4.0 Dec 16, 2025
@nevermarine nevermarine modified the milestones: v1.4.0, v1.5.0 Jan 23, 2026
@nevermarine nevermarine modified the milestones: v1.5.0, v1.6.0 Feb 9, 2026
@universal-itengineer universal-itengineer modified the milestones: v1.6.0, v1.7.0 Mar 3, 2026
@nevermarine nevermarine modified the milestones: v1.7.0, v1.8.0 Mar 31, 2026
@nevermarine nevermarine modified the milestones: v1.8.0, v1.9.0 Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validation/skip/doc_changes Skip doc changes validation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants