refactor(core): Refactor the Virtualization Controller configuration #1213
Draft
yaroslavborbat wants to merge 6 commits into
Draft
refactor(core): Refactor the Virtualization Controller configuration #1213yaroslavborbat wants to merge 6 commits into
yaroslavborbat wants to merge 6 commits into
Conversation
645e06c to
9a16f88
Compare
b5705f6 to
1eba4dc
Compare
Isteb4k
requested changes
Jul 3, 2025
Contributor
Isteb4k
left a comment
There was a problem hiding this comment.
- Why do we need a cobra? Increases cognitive complexity.
- Why are some parameters stored in a config map, others passed through envs, and the third are passed as arguments?
- The controllers map is difficult to read, it is unclear what we gain by starting to use it. When constructors were called sequentially, the code was more sparse and perceived more orderly
ldmonster
reviewed
Jul 28, 2025
Comment on lines
216
to
+217
| x-examples: ["sc-1", "sc-2"] | ||
| x-dmt-default: ["sc-1", "sc-2"] |
There was a problem hiding this comment.
Suggested change
| x-examples: ["sc-1", "sc-2"] | |
| x-dmt-default: ["sc-1", "sc-2"] | |
| x-dmt-default: ["sc-1", "sc-2"] | |
| x-doc-examples: | |
| - ["sc-1", "sc-2"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the Virtualization Controller configuration by consolidating disparate settings previously scattered across flags and environment variables into a unified configuration object:
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist
Changelog entries